From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by mx.groups.io with SMTP id smtpd.web12.26921.1629738108419128471 for ; Mon, 23 Aug 2021 10:01:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cwnhxxDF; spf=pass (domain: gmail.com, ip: 209.85.166.42, mailfrom: kingsumos@gmail.com) Received: by mail-io1-f42.google.com with SMTP id b10so10618364ioq.9 for ; Mon, 23 Aug 2021 10:01:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bbdoVcft0gp8pn5l9oFDsb/1hGt2G3fGhpeRn6sqsEI=; b=cwnhxxDFLvUsoaD0zBmF4cbUEjModMOrxriMuNaiLS4jFi2jEswzjzqEjb2m4AyDoM eicxMK/ubsvCq2KqU+uU/lT5grE8QhXMiu5ezF8txH72N3v+/zVeHY7rYIZ/47gcQMwA OG5e7fwRFZ4iGdtWFFYdFdkCJJ5ObsrWCAwp5dTeGbOJtJ8dkRcrcCIgPNYZb22kXu+v YWU1GsOVBBpF3tX19T6C9DbUWDPrS7f1vQwMhtKjqhaLY8Y7FP0wEbG3j4kzGnZ4gakx 7o7liPDbBuc2Sm0lDSuOyR7ddzquwESXQdsa7mrU5i/7+uzRxmWVVGrdrN7okXVo6xHN AvBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bbdoVcft0gp8pn5l9oFDsb/1hGt2G3fGhpeRn6sqsEI=; b=qkO4jYgSt2LmqfRGviYUpnUpU5IGxHi8zNY9VWLrasGtsMjkElPwp1SVIYs93ZhOdl ywFXxnAND5VjRWLjzWycgE/UA80na5pPs0VD9DD1dLKn9DUPhuedyVjF5BJeCzAwCGh3 5+spQ1PaC2yiSbni6MYNV83n/XQeiKtrXxkAYVBPM4jb4N31TT9F9F31xqw23DuzYxXH n9h6JAbTHPov1Ar+yzssumdBOU55DNzKmZSTKZfp43meFDeeUAtw/aY4iCh62Grg1M00 7XLNV3/4AvOayrCK0Sk02cyjjWk0LveBMg9XCG6d/9zZiRDG3gmOfTrl7w8PZGouhvg2 wc3w== X-Gm-Message-State: AOAM533zStx9KU19r8LP/nk8VeuCD6WfBS8AHE9j5JFlXzCEVjr/vdYq aui4HkDGlSkRhVjvyqwYED82sC6mUEsmVhrnghDNUOWAs6ZGHg== X-Google-Smtp-Source: ABdhPJzYagFdxO6jkqDz5rZKhzyAyovEANpJqWnL4KCxVajDGguiZW4jJx9K4J+5NzWuhA3Dv0C0IlGhX5fvTzRnDfU= X-Received: by 2002:a02:a98c:: with SMTP id q12mr14244038jam.59.1629738106252; Mon, 23 Aug 2021 10:01:46 -0700 (PDT) MIME-Version: 1.0 References: <20210714062445.340-1-zhiguang.liu@intel.com> In-Reply-To: From: "King Sumo" Date: Mon, 23 Aug 2021 14:01:35 -0300 Message-ID: Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV To: devel@edk2.groups.io, guo.dong@intel.com Cc: "Liu, Zhiguang" Content-Type: multipart/alternative; boundary="000000000000e66f3b05ca3cf891" --000000000000e66f3b05ca3cf891 Content-Type: text/plain; charset="UTF-8" Hi All, This patch broke the coreboot payload loading. Tested with: build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image: "Not a usable UEFI firmware volume" Trying to boot coreboot results in an exception and the following error message: "Payload not loaded" Probably it broke the interface. commit 4bac086e8e007c7143e33f87bb96238326d1d6ba Author: Zhiguang Liu Date: Wed Jul 14 14:24:45 2021 +0800 UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Signed-off-by: Zhiguang Liu Reviewed-by: Ray Ni Reviewed-by: Guo Dong Kind regards, Sumo On Wed, Jul 14, 2021 at 1:08 PM Guo Dong wrote: > > Signed-off-by: Guo Dong > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > Zhiguang Liu > > Sent: Tuesday, July 13, 2021 11:25 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and > > PLDFV > > > > Signed-off-by: Zhiguang Liu > > --- > > UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > > b/UefiPayloadPkg/UefiPayloadPkg.fdf > > index 2d51fdbacb..041fed842c 100644 > > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > > @@ -34,6 +34,7 @@ FV = PLDFV > > > > > > > > ########################################################## > > ###################### > > > > [FV.PLDFV] > > > > +FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45 > > > > BlockSize = $(FD_BLOCK_SIZE) > > > > FvAlignment = 16 > > > > ERASE_POLARITY = 1 > > > > @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B- > > E77F1DB2D793 { > > > > ########################################################## > > ###################### > > > > > > > > [FV.DXEFV] > > > > +FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23 > > > > BlockSize = $(FD_BLOCK_SIZE) > > > > FvForceRebase = FALSE > > > > FvAlignment = 16 > > > > -- > > 2.30.0.windows.2 > > > > > > > > -=-=-=-=-=-= > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762 > > Mute This Topic: https://groups.io/mt/84196221/1781375 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com] > > -=-=-=-=-=-= > > > > > > > > > --000000000000e66f3b05ca3cf891 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi All,

This patch broke the coreboot p= ayload loading. Tested with:
build -a IA32 -a X64 -p UefiPayloadP= kg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=3DCOREBOOT
=

Basically the coreboot cbfstool reports the following error when c= reating the CBFS / flash image:
"Not a usable UEFI firmware = volume"

Trying to boot coreboot results i= n an exception and the following=C2=A0error message:
"Payloa= d not loaded"

Probably it broke the interface.
=

commit 4bac086e8e007c7143e33f87bb96238326d1d6ba
Auth= or: Zhiguang Liu <zhiguang.liu= @intel.com>
Date: =C2=A0 Wed Jul 14 14:24:45 2021 +0800

= =C2=A0 =C2=A0 UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

=C2=A0= =C2=A0 Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
=C2=A0 =C2=A0 Reviewed-by: Ray Ni = <ray.ni@intel.com>
=C2=A0 = =C2=A0 Reviewed-by: Guo Dong <guo.= dong@intel.com>


Kind reg= ards,
Sumo

On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@intel.com> wrote:

Signed-off-by: Guo Dong <guo.dong@intel.com>

> -----Original Message-----
> From: devel@= edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Zhiguang Liu
> Sent: Tuesday, July 13, 2021 11:25 PM
> To: devel@ed= k2.groups.io
> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV an= d
> PLDFV
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>=C2=A0 UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
>=C2=A0 1 file changed, 2 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index 2d51fdbacb..041fed842c 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -34,6 +34,7 @@ FV =3D PLDFV
>
>
>
> ##########################################################
> ######################
>
>=C2=A0 [FV.PLDFV]
>
> +FvNameGuid=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D 96E75986-6FDD-491E-9F= D5-35E21AC45B45
>
>=C2=A0 BlockSize=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D $(FD_BLOCK_SIZE)=
>
>=C2=A0 FvAlignment=C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D 16
>
>=C2=A0 ERASE_POLARITY=C2=A0 =C2=A0 =C2=A0=3D 1
>
> @@ -62,6 +63,7 @@ FILE FV_IMAGE =3D 4E35FD93-9C72-4c15-8C4B-
> E77F1DB2D793 {
>
> ##########################################################
> ######################
>
>
>
>=C2=A0 [FV.DXEFV]
>
> +FvNameGuid=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D 8063C21A-8E58-4576-95= CE-089E87975D23
>
>=C2=A0 BlockSize=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D $(FD_BLOCK_SIZE)=
>
>=C2=A0 FvForceRebase=C2=A0 =C2=A0 =C2=A0 =3D FALSE
>
>=C2=A0 FvAlignment=C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D 16
>
> --
> 2.30.0.windows.2
>
>
>
> -=3D-=3D-=3D-=3D-=3D-=3D
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#77762): https://edk2.groups.io/= g/devel/message/77762
> Mute This Topic: https://groups.io/mt/84196221/1781375=
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com]=
> -=3D-=3D-=3D-=3D-=3D-=3D
>






--000000000000e66f3b05ca3cf891--