From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by mx.groups.io with SMTP id smtpd.web10.26079.1629734066248806233 for ; Mon, 23 Aug 2021 08:54:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=exqbB1GS; spf=pass (domain: gmail.com, ip: 209.85.166.50, mailfrom: kingsumos@gmail.com) Received: by mail-io1-f50.google.com with SMTP id a21so22408536ioq.6 for ; Mon, 23 Aug 2021 08:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=SJimtQk/DTC0weiR9DjZ+y088/pJYqBiN1QnaFMcLU4=; b=exqbB1GSf+qhhEockz61b9ubSMHVaLwJ+bPja88Ydx89xkdk5w7GHhobgBYRPzmWzy /sc19cWToUgiBiwFMi4+zLlopE59ad2/xGgnuBOiwgQz0nhMcJ2Z+M4vKtPRXBYHNp0w iD7b/9yvZTxs4UM8B+j2atMnMwzBy+Bi6/P30ionW0tnQB/lb/jnWNHE1KXNVT/yPLuB M5h1bIHggy7j80f/7lTUbEJPtveE3cInnNZZ4vIOwxEkKpRld941UQLbIaBdsF0OLZWO HMS+wNcl3OAc4n+zymQyOfyTxKg/7e3fgFKmV5MWAfJqNWQDTyyAqgtxbz1cnOt/8Wu4 0pBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=SJimtQk/DTC0weiR9DjZ+y088/pJYqBiN1QnaFMcLU4=; b=bGoV/PVCZuKgPYKBUbsss3Bds8iVx0CkJV1YXFwf2y6VZtUGNIN8hI8/bgMKftsOpf L2uHqjPtnkz8L7+LEDLnnsz1J+wcBE1Nvi2CHL0RtctV0NJAdPLKUM1VscbZfpsTa1+h 2IYWhxCWploVlDnUlGpdU+p8j01DLPb81JDFFHiC7t0Cll7tzIGCI1ZOumcPLr4GXW+P 4uesf+MKMqqxA897bwrbF1+BtzmKapdOTE2BIzVYHyS9HrQ08mrLg4MDmSyg8ymBRGwo iOMkrFJb69LsH3m9bMzV9qMaCbfC+MtNOHESVxNA5xBaqs13Y/vg9JLO7TGBt2zL4R2z CaxQ== X-Gm-Message-State: AOAM530zrGnij63XftQe8leppDFIPMOC8u8i94yusgyjsr4JWSkzStRw DBJj5YqpuOXgGgAW6xs/EZI6vcpFAsVv67lLsPfPM7rB7ofmyw== X-Google-Smtp-Source: ABdhPJxfXkNGLWLL4KUBYhOuRuPMmVTGzweBE1cRrbmTrm5BgJPw5WxhOL5/K/0O26IxFvG3z+F8dwgsnMbbP4TUobo= X-Received: by 2002:a05:6602:d9:: with SMTP id z25mr27406867ioe.154.1629734065588; Mon, 23 Aug 2021 08:54:25 -0700 (PDT) MIME-Version: 1.0 From: "King Sumo" Date: Mon, 23 Aug 2021 12:54:14 -0300 Message-ID: Subject: UefiPayloadPkg build error To: devel@edk2.groups.io Content-Type: multipart/alternative; boundary="0000000000000ecda705ca3c0876" --0000000000000ecda705ca3c0876 Content-Type: text/plain; charset="UTF-8" Hi, The following commit broke the UefiPayloadPkg build: commit d63595c3c91624f258f291adee329724edeac12e (HEAD) Author: Zhiguang Liu Date: Sun Apr 25 15:50:46 2021 +0800 UefiPayloadPkg: Update the function definition of HobConstructor Environment: GCC5 / openSUSE 15.x build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b DEBUG -t GCC5 -D BOOTLOADER=COREBOOT Build log: /home/lxuser/edk2/edk2-orig/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c:80:30: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] Hob->EfiMemoryTop = (EFI_PHYSICAL_ADDRESS) EfiMemoryTop; ^ /home/lxuser/edk2/edk2-orig/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c:81:30: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] Hob->EfiMemoryBottom = (EFI_PHYSICAL_ADDRESS) EfiMemoryBottom; ^ /home/lxuser/edk2/edk2-orig/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c:82:30: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] Hob->EfiFreeMemoryTop = (EFI_PHYSICAL_ADDRESS) EfiFreeMemoryTop; ^ The below patch fixes the build, however I'm not sure if this is the best way to solve the issue - or if there are any side effects: diff --git a/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c b/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c index 768c3db770..53ee1440f5 100644 --- a/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c +++ b/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c @@ -77,9 +77,9 @@ HobConstructor ( Hob->Version = EFI_HOB_HANDOFF_TABLE_VERSION; Hob->BootMode = BOOT_WITH_FULL_CONFIGURATION; - Hob->EfiMemoryTop = (EFI_PHYSICAL_ADDRESS) EfiMemoryTop; - Hob->EfiMemoryBottom = (EFI_PHYSICAL_ADDRESS) EfiMemoryBottom; - Hob->EfiFreeMemoryTop = (EFI_PHYSICAL_ADDRESS) EfiFreeMemoryTop; + Hob->EfiMemoryTop = (EFI_PHYSICAL_ADDRESS) (UINTN)EfiMemoryTop; + Hob->EfiMemoryBottom = (EFI_PHYSICAL_ADDRESS) (UINTN)EfiMemoryBottom; + Hob->EfiFreeMemoryTop = (EFI_PHYSICAL_ADDRESS) (UINTN)EfiFreeMemoryTop; Hob->EfiFreeMemoryBottom = (EFI_PHYSICAL_ADDRESS) (UINTN) (HobEnd+1); Hob->EfiEndOfHobList = (EFI_PHYSICAL_ADDRESS) (UINTN) HobEnd; Thanks, Sumo --0000000000000ecda705ca3c0876 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

The following commit broke the Uefi= PayloadPkg build:
commit d63595c3c91624f258f291adee329724edeac12e (HEAD)
Author: Zhiguang Liu <z= higuang.liu@intel.com>
Date: =C2=A0 Sun Apr 25 15:50:46 20= 21 +0800

=C2=A0 =C2=A0 UefiPayloadPkg: Update th= e function definition of HobConstructor

Environment: GCC5 / openSUSE 15.x
=C2=A0build -a IA32 -a X64 -= p UefiPayloadPkg/UefiPayloadPkg.dsc -b DEBUG -t GCC5 -D BOOTLOADER=3DCOREBO= OT

Build log:
/home/lxuser/edk2/edk2-orig/UefiPayloadP= kg/Library/PayloadEntryHobLib/Hob.c:80:30: error: cast from pointer to inte= ger of different size [-Werror=3Dpointer-to-int-cast]
=C2=A0 =C2=A0Hob-&= gt;EfiMemoryTop =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D (EFI_PHYSICAL_ADDRESS) EfiMe= moryTop;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
/home/lxuser/edk2/edk2-orig/= UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c:81:30: error: cast from poi= nter to integer of different size [-Werror=3Dpointer-to-int-cast]
=C2=A0= =C2=A0Hob->EfiMemoryBottom =C2=A0 =C2=A0 =3D (EFI_PHYSICAL_ADDRESS) Efi= MemoryBottom;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
/home/lxuser/edk2/edk= 2-orig/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c:82:30: error: cast f= rom pointer to integer of different size [-Werror=3Dpointer-to-int-cast]=C2=A0 =C2=A0Hob->EfiFreeMemoryTop =C2=A0 =C2=A0=3D (EFI_PHYSICAL_ADDRE= SS) EfiFreeMemoryTop;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^


=

The below patch fixes the build, however I'm not su= re if this is the best way to solve the issue - or if there are any side ef= fects:

diff --git a/UefiPayloadPkg/Library/Payload= EntryHobLib/Hob.c b/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c
inde= x 768c3db770..53ee1440f5 100644
--- a/UefiPayloadPkg/Library/PayloadEntr= yHobLib/Hob.c
+++ b/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c
@= @ -77,9 +77,9 @@ HobConstructor (
=C2=A0 =C2=A0Hob->Version =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D EFI_HOB_HANDOFF_TABLE_VERSION;
= =C2=A0 =C2=A0Hob->BootMode =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D = BOOT_WITH_FULL_CONFIGURATION;

- =C2=A0Hob->EfiMemoryTop =C2=A0 = =C2=A0 =C2=A0 =C2=A0=3D (EFI_PHYSICAL_ADDRESS) EfiMemoryTop;
- =C2=A0Hob= ->EfiMemoryBottom =C2=A0 =C2=A0 =3D (EFI_PHYSICAL_ADDRESS) EfiMemoryBott= om;
- =C2=A0Hob->EfiFreeMemoryTop =C2=A0 =C2=A0=3D (EFI_PHYSICAL_ADDR= ESS) EfiFreeMemoryTop;
+ =C2=A0Hob->EfiMemoryTop =C2=A0 =C2=A0 =C2=A0= =C2=A0=3D (EFI_PHYSICAL_ADDRESS) (UINTN)EfiMemoryTop;
+ =C2=A0Hob->E= fiMemoryBottom =C2=A0 =C2=A0 =3D (EFI_PHYSICAL_ADDRESS) (UINTN)EfiMemoryBot= tom;
+ =C2=A0Hob->EfiFreeMemoryTop =C2=A0 =C2=A0=3D (EFI_PHYSICAL_ADD= RESS) (UINTN)EfiFreeMemoryTop;
=C2=A0 =C2=A0Hob->EfiFreeMemoryBottom = =3D (EFI_PHYSICAL_ADDRESS) (UINTN) (HobEnd+1);
=C2=A0 =C2=A0Hob->EfiE= ndOfHobList =C2=A0 =C2=A0 =3D (EFI_PHYSICAL_ADDRESS) (UINTN) HobEnd;

Thanks,
Sumo
--0000000000000ecda705ca3c0876--