From: "Ard Biesheuvel" <ardb@kernel.org>
To: Mike Beaton <mjsbeaton@gmail.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
devel@edk2.groups.io, Laszlo Ersek <lersek@redhat.com>,
mcb30@ipxe.org, Mikhail Krichanov <mikhailkrichanov@gmail.com>
Subject: Re: [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined
Date: Tue, 19 Dec 2023 10:06:44 +0100 [thread overview]
Message-ID: <CAGnOC3YMiAJe6A4CfczEoj=_oXFfo8=Ox1vYk55MiZ4GUTB9ow@mail.gmail.com> (raw)
In-Reply-To: <CAHzAAWSJwOje8cFAG18ju8gYzP5yR+Hv_uWajoDdBCN1WCtm-Q@mail.gmail.com>
On Fri, Dec 15, 2023 at 12:56 PM Mike Beaton <mjsbeaton@gmail.com> wrote:
>
> > For the exception handler case, we can just drop the #Ifdefs around
> > the definition of BaseName () entirely given that it will now always
> > be referenced. But that does depend a lot on how other toolchains deal
> > with this (VS201x primarily)
>
> The V5/V6 version of the patch builds on VS2019
Excellent, thanks for checking.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112714): https://edk2.groups.io/g/devel/message/112714
Mute This Topic: https://groups.io/mt/103166254/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-12-19 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 7:27 [edk2-devel] [PATCH V4 1/2] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined Mike Beaton
2023-12-14 7:27 ` [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined Mike Beaton
2023-12-14 7:33 ` Mike Beaton
2023-12-14 7:40 ` Ard Biesheuvel
2023-12-14 8:59 ` Ard Biesheuvel
2023-12-15 11:56 ` Mike Beaton
2023-12-19 9:06 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGnOC3YMiAJe6A4CfczEoj=_oXFfo8=Ox1vYk55MiZ4GUTB9ow@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox