From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4C35D9413BA for ; Tue, 19 Dec 2023 09:06:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2io1SAgTcwd1vQ8gI9AOiBOZ5VLTaiGL+RAl2R/uRv8=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702976817; v=1; b=gNrVRayKJfAC/t9fxNofwVCgcvDdH3wsoYNyd1bkD4rMNC2+9os/PpiIl2QKoGrErNxbM+ea d1wNt5Nc1OiB4ZoMXuAEwVzSaJvo3db78PAFdw10kKyWlKDoVb5k4YIqK9TP+GkHifMldE0CDvi fG9MeDO7/N47Jd0YRfKIsTvM= X-Received: by 127.0.0.2 with SMTP id Lqe4YY7687511xlooyziJorF; Tue, 19 Dec 2023 01:06:57 -0800 X-Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by mx.groups.io with SMTP id smtpd.web11.8420.1702976816904069978 for ; Tue, 19 Dec 2023 01:06:57 -0800 X-Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-42598c2b0b7so195031cf.1 for ; Tue, 19 Dec 2023 01:06:56 -0800 (PST) X-Gm-Message-State: mj7Mtb6lSBk2GWHKOXgYATXFx7686176AA= X-Google-Smtp-Source: AGHT+IET8HX8nxGn1z4+UB4sEeMKEkQ9Ku12D/y8+y6edCp+AcXD8xD3NJp9J6aiKNPeAmkt17mf7gWScculS8AiApY= X-Received: by 2002:a05:622a:1ba5:b0:425:8f81:6c8e with SMTP id bp37-20020a05622a1ba500b004258f816c8emr121975qtb.23.1702976815797; Tue, 19 Dec 2023 01:06:55 -0800 (PST) MIME-Version: 1.0 References: <20231214072743.6432-1-mjsbeaton@gmail.com> <20231214072743.6432-2-mjsbeaton@gmail.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 19 Dec 2023 10:06:44 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined To: Mike Beaton Cc: Ard Biesheuvel , devel@edk2.groups.io, Laszlo Ersek , mcb30@ipxe.org, Mikhail Krichanov Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=gNrVRayK; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Dec 15, 2023 at 12:56=E2=80=AFPM Mike Beaton = wrote: > > > For the exception handler case, we can just drop the #Ifdefs around > > the definition of BaseName () entirely given that it will now always > > be referenced. But that does depend a lot on how other toolchains deal > > with this (VS201x primarily) > > The V5/V6 version of the patch builds on VS2019 Excellent, thanks for checking. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112714): https://edk2.groups.io/g/devel/message/112714 Mute This Topic: https://groups.io/mt/103166254/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-