public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel via groups.io" <ardb=kernel.org@groups.io>
To: sami.mujawar@arm.com
Cc: Ard Biesheuvel <ardb+git@google.com>, devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/VExpress: Replace missing ArmGetCpuCountPerCluster()
Date: Fri, 30 Aug 2024 17:57:45 +0200	[thread overview]
Message-ID: <CAGnOC3Ymg9bpUddtk8XiKD0E3ZMBCOweF8OgCSvDQcQexxzV=g@mail.gmail.com> (raw)
In-Reply-To: <28815.1725032758218981318@groups.io>

On Fri, Aug 30, 2024 at 5:46 PM Sami Mujawar via Groups.Io
<sami.mujawar=arm.com@groups.io> wrote:
>
> Hi Ard,
>
> Thank you for this patch.
>
> These changes look good to me.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>

Thanks

> In addition to this patch I required the following changes for the FVP to boot to the UEFI shell.
>
> edk2 repo:
> -----------
> diff --git a/ArmPlatformPkg/PeilessSec/PeilessSec.inf b/ArmPlatformPkg/PeilessSec/PeilessSec.inf
> index 7ceeb74f69f2..d652b72e46b9 100644
> --- a/ArmPlatformPkg/PeilessSec/PeilessSec.inf
> +++ b/ArmPlatformPkg/PeilessSec/PeilessSec.inf
> @@ -43,6 +43,7 @@ [LibraryClasses]
>    DebugAgentLib
>    DebugLib
>    HobLib
> +  LzmaDecompressLib
>    MemoryInitPeiLib
>    PerformanceLib
>    PlatformPeiLib
>
>
> edk2-platforms repo:
> ---------------------
> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> index 931eff2355d4..a299d7ed559a 100644
> --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> @@ -194,6 +194,7 @@ [LibraryClasses.common.SEC]
>  !ifdef $(EDK2_SKIP_PEICORE)
>    PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
>    ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
> +  LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
>    MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf
>    HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
>    PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
>
> Without the above change the "SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF" is not found, see https://github.com/tianocore/edk2-platforms/blob/master/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf#L250
>

My bad. Could you please check whether the below works as well?

--- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
@@ -230,6 +230,7 @@ [Components.common]
   # UEFI is placed in RAM by bootloader
   ArmPlatformPkg/PeilessSec/PeilessSec.inf {
     <LibraryClasses>
+      NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
       ArmPlatformLib|Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf
   }
 !else


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120449): https://edk2.groups.io/g/devel/message/120449
Mute This Topic: https://groups.io/mt/108128468/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-08-30 15:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27 17:28 [edk2-devel] [PATCH edk2-platforms 1/1] Platform/VExpress: Replace missing ArmGetCpuCountPerCluster() Ard Biesheuvel via groups.io
2024-08-30 15:45 ` Sami Mujawar
2024-08-30 15:57   ` Ard Biesheuvel via groups.io [this message]
2024-08-30 16:04     ` Sami Mujawar
2024-08-30 17:25       ` Ard Biesheuvel via groups.io
2024-08-30 16:03   ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGnOC3Ymg9bpUddtk8XiKD0E3ZMBCOweF8OgCSvDQcQexxzV=g@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox