From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 43D28AC1592 for ; Fri, 30 Aug 2024 15:58:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5vHC+U9yihbC1kLW7GzvUZsPD70ilIqBNaz5I65VHYM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1725033479; v=1; b=qK0bQeQhu7hJAIC53xnwtTg3qwKl/wLOAULHEeTM09Z929aiphK8we6opQX0INlaUSQoOBwm bDoppyMaZJJwJjXLXtwT2q8VmQ7l/NWreQNDZp2BlIvBiZV/+smJIyXkiYjxHUOh23c2QVsYmk4 OPofTu9DAdYSagylLqAT13M/na58b3L0SB4EPhLMNm1BfnjfHT7lyfyzxtNQseZkHuwhIi49F8n P0CkYYCF8sSpBw0JlCCnHW+AAA+K0cHuLRkCoVgGKnOE+jaCXE0RQZPdg+DFn81oFpGGpN9An4T CDhY0zUNOa1IlDWUYSUYJ77hJ6hUswrtnPx0kmwOe+u7Q== X-Received: by 127.0.0.2 with SMTP id ArRDYY7687511xtkcE6spvyu; Fri, 30 Aug 2024 08:57:58 -0700 X-Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by mx.groups.io with SMTP id smtpd.web11.20058.1725033477785250582 for ; Fri, 30 Aug 2024 08:57:57 -0700 X-Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-45677965a3cso6917661cf.0 for ; Fri, 30 Aug 2024 08:57:57 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVYOwQ2PgZ/pZtbM75l468GFlsxtZUya1ZTVTZbicJRhbYL28AYUG/4CfH3O1dkfFf6WHAwrA==@edk2.groups.io X-Gm-Message-State: e8m1qdtobmwnNJEkisrhpkSEx7686176AA= X-Google-Smtp-Source: AGHT+IGxZqR/tvWH10wluFwJ0cUPkx+nL+GdFAWDZoGPLfQHVky09gy/3V/lzt9gXbild9PCtt1ZBjXH/30FqckFZOQ= X-Received: by 2002:ad4:42cd:0:b0:6c1:8663:5bc3 with SMTP id 6a1803df08f44-6c33e617559mr61746476d6.20.1725033476661; Fri, 30 Aug 2024 08:57:56 -0700 (PDT) MIME-Version: 1.0 References: <20240827172820.661646-1-ardb+git@google.com> <28815.1725032758218981318@groups.io> In-Reply-To: <28815.1725032758218981318@groups.io> From: "Ard Biesheuvel via groups.io" Date: Fri, 30 Aug 2024 17:57:45 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/VExpress: Replace missing ArmGetCpuCountPerCluster() To: sami.mujawar@arm.com Cc: Ard Biesheuvel , devel@edk2.groups.io Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 30 Aug 2024 08:57:58 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=qK0bQeQh; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Aug 30, 2024 at 5:46=E2=80=AFPM Sami Mujawar via Groups.Io wrote: > > Hi Ard, > > Thank you for this patch. > > These changes look good to me. > > Reviewed-by: Sami Mujawar > Thanks > In addition to this patch I required the following changes for the FVP to= boot to the UEFI shell. > > edk2 repo: > ----------- > diff --git a/ArmPlatformPkg/PeilessSec/PeilessSec.inf b/ArmPlatformPkg/Pe= ilessSec/PeilessSec.inf > index 7ceeb74f69f2..d652b72e46b9 100644 > --- a/ArmPlatformPkg/PeilessSec/PeilessSec.inf > +++ b/ArmPlatformPkg/PeilessSec/PeilessSec.inf > @@ -43,6 +43,7 @@ [LibraryClasses] > DebugAgentLib > DebugLib > HobLib > + LzmaDecompressLib > MemoryInitPeiLib > PerformanceLib > PlatformPeiLib > > > edk2-platforms repo: > --------------------- > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/= VExpressPkg/ArmVExpress.dsc.inc > index 931eff2355d4..a299d7ed559a 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -194,6 +194,7 @@ [LibraryClasses.common.SEC] > !ifdef $(EDK2_SKIP_PEICORE) > PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionL= ib/PrePiExtractGuidedSectionLib.inf > + LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCus= tomDecompressLib.inf > MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePi= MemoryAllocationLib.inf > HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf > PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/P= rePiHobListPointerLib.inf > > Without the above change the "SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7B= D79403CF" is not found, see https://github.com/tianocore/edk2-platforms/blo= b/master/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf#L250 > My bad. Could you please check whether the below works as well? --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc @@ -230,6 +230,7 @@ [Components.common] # UEFI is placed in RAM by bootloader ArmPlatformPkg/PeilessSec/PeilessSec.inf { + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompre= ssLib.inf ArmPlatformLib|Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/A= rmVExpressLib.inf } !else -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120449): https://edk2.groups.io/g/devel/message/120449 Mute This Topic: https://groups.io/mt/108128468/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-