Re: [V1 PATCH 1/1] MdePkg: TDX: Correct TDCALL_INFO_RETURN_DATA layout

["Vishal Annapurve" <vannapurve@google.com>]

On Wed, Feb 15, 2023 at 4:10 PM Xu, Min M <min.m.xu@intel.com> wrote:
>
> On February 16, 2023 3:51 AM, Vishal Annapurve wrote:
> >
> > TDCALL_INFO should return num_vcpus as lower 4 bytes of r8 register
> > according to the tdx spec, so reorder num_vcpus and max_vcpus fields to
> > match the spec.
> >
> > Reference: Table 22.210 TDG.VP.INFO output operands
> > https://cdrdv2.intel.com/v1/dl/getContent/733568
> >
> > Signed-off-by: Vishal Annapurve <vannapurve@google.com>
> > ---
> >  MdePkg/Include/IndustryStandard/Tdx.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/Tdx.h
> > b/MdePkg/Include/IndustryStandard/Tdx.h
> > index 81df136184..a17be61353 100644
> > --- a/MdePkg/Include/IndustryStandard/Tdx.h
> > +++ b/MdePkg/Include/IndustryStandard/Tdx.h
> > @@ -111,8 +111,8 @@ typedef struct {
> >  typedef struct {
> >    UINT64    Gpaw;
> >    UINT64    Attributes;
> > -  UINT32    MaxVcpus;
> >    UINT32    NumVcpus;
> > +  UINT32    MaxVcpus;
> >    UINT64    Resv[3];
> >  } TDCALL_INFO_RETURN_DATA;
> >
> Thanks much for the correction.
> Reviewed-by: Min Xu <min.m.xu@intel.com>

Hi Michael, Liming, Zhiguang,

Can you help review this patch?

Thanks,
Vishal