* [V1 PATCH 1/1] MdePkg: TDX: Correct TDCALL_INFO_RETURN_DATA layout @ 2023-02-15 19:50 Vishal Annapurve 2023-02-16 0:10 ` Min Xu 0 siblings, 1 reply; 3+ messages in thread From: Vishal Annapurve @ 2023-02-15 19:50 UTC (permalink / raw) To: devel Cc: michael.d.kinney, gaoliming, zhiguang.liu, min.m.xu, erdemaktas, jiewen.yao, Vishal Annapurve TDCALL_INFO should return num_vcpus as lower 4 bytes of r8 register according to the tdx spec, so reorder num_vcpus and max_vcpus fields to match the spec. Reference: Table 22.210 TDG.VP.INFO output operands https://cdrdv2.intel.com/v1/dl/getContent/733568 Signed-off-by: Vishal Annapurve <vannapurve@google.com> --- MdePkg/Include/IndustryStandard/Tdx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/Tdx.h b/MdePkg/Include/IndustryStandard/Tdx.h index 81df136184..a17be61353 100644 --- a/MdePkg/Include/IndustryStandard/Tdx.h +++ b/MdePkg/Include/IndustryStandard/Tdx.h @@ -111,8 +111,8 @@ typedef struct { typedef struct { UINT64 Gpaw; UINT64 Attributes; - UINT32 MaxVcpus; UINT32 NumVcpus; + UINT32 MaxVcpus; UINT64 Resv[3]; } TDCALL_INFO_RETURN_DATA; -- 2.39.1.637.g21b0678d19-goog ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [V1 PATCH 1/1] MdePkg: TDX: Correct TDCALL_INFO_RETURN_DATA layout 2023-02-15 19:50 [V1 PATCH 1/1] MdePkg: TDX: Correct TDCALL_INFO_RETURN_DATA layout Vishal Annapurve @ 2023-02-16 0:10 ` Min Xu 2023-04-25 18:25 ` Vishal Annapurve 0 siblings, 1 reply; 3+ messages in thread From: Min Xu @ 2023-02-16 0:10 UTC (permalink / raw) To: Annapurve, Vishal, devel@edk2.groups.io Cc: Kinney, Michael D, Gao, Liming, Liu, Zhiguang, Aktas, Erdem, Yao, Jiewen, Annapurve, Vishal On February 16, 2023 3:51 AM, Vishal Annapurve wrote: > > TDCALL_INFO should return num_vcpus as lower 4 bytes of r8 register > according to the tdx spec, so reorder num_vcpus and max_vcpus fields to > match the spec. > > Reference: Table 22.210 TDG.VP.INFO output operands > https://cdrdv2.intel.com/v1/dl/getContent/733568 > > Signed-off-by: Vishal Annapurve <vannapurve@google.com> > --- > MdePkg/Include/IndustryStandard/Tdx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Include/IndustryStandard/Tdx.h > b/MdePkg/Include/IndustryStandard/Tdx.h > index 81df136184..a17be61353 100644 > --- a/MdePkg/Include/IndustryStandard/Tdx.h > +++ b/MdePkg/Include/IndustryStandard/Tdx.h > @@ -111,8 +111,8 @@ typedef struct { > typedef struct { > UINT64 Gpaw; > UINT64 Attributes; > - UINT32 MaxVcpus; > UINT32 NumVcpus; > + UINT32 MaxVcpus; > UINT64 Resv[3]; > } TDCALL_INFO_RETURN_DATA; > Thanks much for the correction. Reviewed-by: Min Xu <min.m.xu@intel.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [V1 PATCH 1/1] MdePkg: TDX: Correct TDCALL_INFO_RETURN_DATA layout 2023-02-16 0:10 ` Min Xu @ 2023-04-25 18:25 ` Vishal Annapurve 0 siblings, 0 replies; 3+ messages in thread From: Vishal Annapurve @ 2023-04-25 18:25 UTC (permalink / raw) To: Xu, Min M Cc: devel@edk2.groups.io, Kinney, Michael D, Gao, Liming, Liu, Zhiguang, Aktas, Erdem, Yao, Jiewen On Wed, Feb 15, 2023 at 4:10 PM Xu, Min M <min.m.xu@intel.com> wrote: > > On February 16, 2023 3:51 AM, Vishal Annapurve wrote: > > > > TDCALL_INFO should return num_vcpus as lower 4 bytes of r8 register > > according to the tdx spec, so reorder num_vcpus and max_vcpus fields to > > match the spec. > > > > Reference: Table 22.210 TDG.VP.INFO output operands > > https://cdrdv2.intel.com/v1/dl/getContent/733568 > > > > Signed-off-by: Vishal Annapurve <vannapurve@google.com> > > --- > > MdePkg/Include/IndustryStandard/Tdx.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdePkg/Include/IndustryStandard/Tdx.h > > b/MdePkg/Include/IndustryStandard/Tdx.h > > index 81df136184..a17be61353 100644 > > --- a/MdePkg/Include/IndustryStandard/Tdx.h > > +++ b/MdePkg/Include/IndustryStandard/Tdx.h > > @@ -111,8 +111,8 @@ typedef struct { > > typedef struct { > > UINT64 Gpaw; > > UINT64 Attributes; > > - UINT32 MaxVcpus; > > UINT32 NumVcpus; > > + UINT32 MaxVcpus; > > UINT64 Resv[3]; > > } TDCALL_INFO_RETURN_DATA; > > > Thanks much for the correction. > Reviewed-by: Min Xu <min.m.xu@intel.com> Hi Michael, Liming, Zhiguang, Can you help review this patch? Thanks, Vishal ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-25 18:25 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-02-15 19:50 [V1 PATCH 1/1] MdePkg: TDX: Correct TDCALL_INFO_RETURN_DATA layout Vishal Annapurve 2023-02-16 0:10 ` Min Xu 2023-04-25 18:25 ` Vishal Annapurve
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox