From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 99C1274005B for ; Mon, 4 Nov 2024 14:05:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jrojmt3fg3EvCyv7XxGAYQ5bsgUN2YLaFkOqgeLrBJ8=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240830; t=1730729101; v=1; x=1730988300; b=hOEetHNO79p9QdBNPyklIP3ln+M+I+AAMclhhOACm10Rvnq5fO0SVF71V68j+l5myzX6KcLL sgK/Ln41goMscrlArdifNLb0RhywFcuCBiemhA5T90pggTCmzUDKrxzzIpGcp2AASVELXqy2hB/ fIKVhgJD66swMuE2l6s4tIHCCj2IcvzPXynAIAT3LiLP/7S+Vp6ApvRNyrtrcjB+2knyCXgfEew F+8UYyfbY/yemuOZZeHW2C+vWQ6gPy1duc/Twz1dxFVsmJW/LE6nK8nIubp2wAGMbdaBBNAhMPY l2lpYZ2V6dmX8CLuXiEHUvtcff5Ci4xYdgvQTQPhMGKRg== X-Received: by 127.0.0.2 with SMTP id 3sBiYY7687511xvatguJfWOS; Mon, 04 Nov 2024 06:05:00 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.53641.1730711702851893866 for ; Mon, 04 Nov 2024 01:15:03 -0800 X-Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-KZTA1pH3MTyyKvXsQOiN1g-1; Mon, 04 Nov 2024 04:15:00 -0500 X-MC-Unique: KZTA1pH3MTyyKvXsQOiN1g-1 X-Received: by mail-yb1-f200.google.com with SMTP id 3f1490d57ef6-e2e3321aae0so6005373276.1 for ; Mon, 04 Nov 2024 01:15:00 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV/VmZxopWPnSdsFGLO7m6m1P2TOApc8lWjonwUsKKOWsh7UG6QRRS21MP0eQoPU4KflHuSqQ==@edk2.groups.io X-Gm-Message-State: jTP2GcEVYKey7mrkMCW58OIGx7686176AA= X-Received: by 2002:a05:6902:144f:b0:e30:d383:9c24 with SMTP id 3f1490d57ef6-e30e5a1b4d7mr13971715276.1.1730711699958; Mon, 04 Nov 2024 01:14:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IElSnX8C/a6fEDKxiW4ZiJk3UO9D15/0aBJvLGqScjb13AAcJ3dDnLd9kdGoncNHnuJwDGBREp+jhgG6r1g5I4= X-Received: by 2002:a05:6902:144f:b0:e30:d383:9c24 with SMTP id 3f1490d57ef6-e30e5a1b4d7mr13971694276.1.1730711699417; Mon, 04 Nov 2024 01:14:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Stefano Garzarella Date: Mon, 4 Nov 2024 10:14:47 +0100 Message-ID: Subject: Re: [edk2-devel] OVMF Issue with Netboot, VirtioRng, and both COM1/COM2 configured To: Gerd Hoffmann Cc: Oliver Steffen , devel@edk2.groups.io, Jiewen Yao , Zachary Clark-williams , Saloni Kasbekar , Doug Flick , Daniel Berrange , Cong Li X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 04 Nov 2024 06:04:59 -0800 Resent-From: sgarzare@redhat.com Reply-To: devel@edk2.groups.io,sgarzare@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=hOEetHNO; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Gerd, On Fri, Nov 1, 2024 at 10:31=E2=80=AFAM Gerd Hoffmann w= rote: > > Hi, > > > By analyzing the calls to the dispatcher (`gDS->Dispatch ()`) I found > > that when we only have COM1, EfiBootManagerConnectDevicePath() at some > > point invokes `gDS->Dispatch ()` after VirtioRng has started. This call > > will then get DxeNetLib loaded. > > Ok, so it is probably a good idea to explicitly request a dispatch after > activating virtio-rng, so we do not depend on this happening by pure > luck for other reasons: > > --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > @@ -670,6 +670,7 @@ ConnectVirtioPciRng ( > if (EFI_ERROR (Status)) { > goto Error; > } > + gDS->Dispatch (); > } > > return EFI_SUCCESS; > > [ untested patch, and we probably should do something similar for ArmVirt= , > /me goes continue walking through my email backlog now ] > Yep, that should work. Last week I went a little deeper into the problem and basically starting with commit 4c4ceb2ceb ("NetworkPkg: SECURITY PATCH CVE-2023-45237") the network stack is no longer initialized during DXE, but in BDS (see https://issues.redhat.com/browse/RHEL-58631?focusedId=3D25981655&page=3Dcom= .atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-25981= 655). Is this intentional? Could there be other problems besides this one we just= had? Thanks, Stefano -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120709): https://edk2.groups.io/g/devel/message/120709 Mute This Topic: https://groups.io/mt/109008158/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-