From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=X9etQsLv; spf=pass (domain: gmail.com, ip: 209.85.161.54, mailfrom: siadriravikumaruefi@gmail.com) Received: from mail-yw1-f54.google.com (mail-yw1-f54.google.com [209.85.161.54]) by groups.io with SMTP; Thu, 13 Jun 2019 01:18:18 -0700 Received: by mail-yw1-f54.google.com with SMTP id n21so1915516ywh.0 for ; Thu, 13 Jun 2019 01:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yg5wV5+LvmeuA1DLsFzj1tpQyuBnTQTZBuJq9wunBrc=; b=X9etQsLvAzd5QpulQK4eHIPYieQRkbuQRODZTzRgbQKd1TjPb4Iw/a1mBP+w2tR4M7 ba29mqU6MWweH8ZhD7sLnqs9tbKZfVKBGzzgXmE2KVTSvnTpyOIWV5I9XeurT5pKPsju yio9hrHaAYZ7/S5PnSxhH0shaXF12Y1DjGMUWuHb0TBzuDtZtdSq4A0/ClwKIx320RAn 1uQXhdPlGN/vh92HXQxo1AE92tOuKVVFtZ6KWnSgqKh8FVv69slxlcIwvfY/80WKTIf6 w0DQk2nf12esrD3WyK/XMMPERa67syxwlctRP4Tt41L470O59lsDtvkVWMTVanPUtr+n 8PJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yg5wV5+LvmeuA1DLsFzj1tpQyuBnTQTZBuJq9wunBrc=; b=gZo3n3ZXscetN+RmiKIxOCuUfjTmmrunm8czSRE1H2toIBR4oJsHWzQJ2fbV7YB8/7 FxKO2AKIm8y+8tDg95J5VEzjaEQgMF+gch4BaKBC0DHeGuIg1o3iqjpd4zBWSq4Yp2Jg 6woXJH+kr9aFlPAy45rfcQ8p2nJR4CX/UvBlwNBC8rGF3RPcw43fRkE9EWHjcDGhDgyF JsQ8vRhdB4qOzFlMsMNkCH5C5OjKUY9OSbGArg1PldnJeIa5emoKm3SYQ5iBEGLza6qK lxD94tA/JwgiXay6X7ci1oqXCtjsSuK2g0+LXFxlBLd/e3JNxFcPmsykOD/Twql6nLVe tAJA== X-Gm-Message-State: APjAAAUlINcXJU5U7cSVM11D1YeuSGHzWxNXCn9oo7WxmmvSI0z11mkw l6sNuLWQek2+oCa1SxOo+iLpvyorX12X20q3zOo= X-Google-Smtp-Source: APXvYqxZ6yfg4ARZdcUq9iGAYki2N+zXqBQrK1VnoRmR1DTFDO/Mnqdq26E3UVmCRxD822kKkgIBpPVXhGlvLbXl62A= X-Received: by 2002:a81:6e82:: with SMTP id j124mr45225539ywc.27.1560413897267; Thu, 13 Jun 2019 01:18:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Ravi Kumar Siadri" Date: Thu, 13 Jun 2019 13:48:05 +0530 Message-ID: Subject: Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices To: "Wu, Hao A" Cc: "devel@edk2.groups.io" Content-Type: multipart/alternative; boundary="0000000000000c9dd9058b302c31" --0000000000000c9dd9058b302c31 Content-Type: text/plain; charset="UTF-8" Hi Wu Hao A, Thanks for the response. I have added my comments in line. Thanks, Ravi Kumar On Wed, Jun 12, 2019 at 1:26 PM Wu, Hao A wrote: > Hello Ravi Kumar, > > > > Inline comments below: > > > > *From:* devel@edk2.groups.io [mailto:devel@edk2.groups.io] *On Behalf Of *Ravi > Kumar Siadri > *Sent:* Wednesday, June 12, 2019 12:01 PM > *To:* devel@edk2.groups.io > *Subject:* Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI > devices > > > > Hi, > > > > Can someone help me in clarifying my queries ?? > > > > Thanks, > > Ravi Kumar > > > > On Mon, Jun 10, 2019 at 3:55 PM Ravi Kumar Siadri < > siadriravikumaruefi@gmail.com> wrote: > > Hi all, > > > > I have couple of queries regarding the > *EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL* attribute support in > *EFI_EXT_SCSI_PASS_THRU_PROTOCOL*. > > > > *1. * > > *The Attributes field of the EFI_EXT_SCSI_PASS_THRU_PROTOCOL interface > tells if the interface is for physical SCSI devices or logical SCSI > devices. Drivers for non-RAID SCSI controllers will set both the > EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL, and the > EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL bits.* > > > > If the Drivers is for non-RAID SCSI controllers why to set the > EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL bit. Will there be any case that > non-RAID SCSI controllers have Logical devices connected to it ?? > > > > Per my understanding, every partition on a physical HW device will be > treated > > as a logical device by the firmware. > > > > So for non-RAID case, both bits will be set for the PassThru protocol > produced > > for the physical device. > > > Ravi: > > As far as i know RAID controller will treat a partition/drive as logical > device only if has RIS (raid information sector) information in it. So i > don't think partition is treated as logical device. > > > > > > *2. * > > *Drivers for RAID controllers that allow access to the physical devices > and logical devices will produce two EFI_EXT_SCSI_PASS_THRU_PROTOCOL > interfaces: * > > *One with the just the EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL bit set > and another with just the EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL bit > set. One interface can be used to access the physical devices attached to > the RAID controller, and the other can be used to access the logical > devices attached to the RAID controller for its current configuration.* > > > > Any background why EFI_EXT_SCSI_PASS_THRU_PROTOCOL needed 2 instances ? > why can't we install attributes EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL > and EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL on same Instance ?? > > How User locates the Instance with > EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL bit set and Instance with > EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL bit set. ?? > > > > UEFI spec allows RAID drivers to only produce one PassThru protocol > interface > > with just the XXX_PASS_THRU_LOGICAL bit set when the RAID controller > select to > > not allow direct access to the underlying physical devices. > > Ravi: > If the RAID Driver supports only Logical or Physical Devices then it is > fine creating only 1 instance and not allowing other devices which Bit is > not set. (either EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL or > EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL). > > But if the RAID driver supports both the Logical and Physical Devices, > then we have to need 2 instances as per spec. This is going to be an over > head, while locating instances by the user who want to send commands to > Target devices connected to RAID controller. > > Since each EFI_EXT_SCSI_PASS_THRU_PROTOCOL instance must have an > associated device path. Only 1 instance can be installed on that particular > RAID controller handle since the GUID is same for both the instances. > > If our intention is to filter the Logical and Physical devices then, we > can add a parameter in GetNextTartget() function to inform RAID Driver > which type of targets the user is looking for. (Physical or Logical). > > Right ?? > > > > Thanks, > > Ravi Kumar > > > > > --0000000000000c9dd9058b302c31 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Wu Hao A,

Thanks for the r= esponse.
I have added my comments in line.

Thanks,
Ravi Kumar


=C2= = =A0

On Wed, Jun 12, 2019 at 1:26 PM Wu, Hao A &l= t;hao.a.wu@intel.com> wrote:

Hello Ravi Kumar,

=C2=A0

Inline comments below:=

=C2=A0

From: d= evel@edk2.groups.io [mailto:devel@e= dk2.groups.io] On Behalf Of Ravi Kumar Siadri
Sent: Wednesday, June 12, 2019 12:01 PM
To: devel= @edk2.groups.io
Subject: Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices=

=C2=A0

Hi,

=C2=A0

Can someone help me in clarifying my queries ??<= /u>

=C2=A0

Thanks,

Ravi Kumar

=C2=A0

On Mon, Jun 10, 2019 at 3:55 PM Ravi Kumar Siadri <siadriravikumaruefi@gmail.com> wrote:

Hi all,

=C2=A0

I have couple of queries regarding the EFI_EXT_S= CSI_PASS_THRU_ATTRIBUTES_LOGICAL attribute support in EFI_EXT_SCSI_PASS_THRU_PROTOCOL.

=C2=A0

1.=C2=A0

The Attributes field of the EFI_EXT_SCSI_PASS= _THRU_PROTOCOL interface tells if the interface is for physical SCSI device= s or logical SCSI devices. Drivers for non-RAID SCSI controllers will set b= oth the EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL, and the EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL bits.=

=C2=A0

If the Drivers is for non-RAID SCSI controllers why= to set the EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL bit. Will there be an= y case that non-RAID SCSI controllers have Logical devices connected to it = ??

=C2=A0

Per my understanding, every partition on a = physical HW device will be treated

as a logical device by the firmware.=

=C2=A0<= u>

So for non-RAID case, both bits will be set= for the PassThru protocol produced

for the physical device.

=C2=A0

Ravi:=C2=A0

=

As far as i know RAID controller will treat a par= tition/drive as logical device only if has RIS (raid information sector) in= formation in it.=C2=A0 So i don't think partition is treated as logical= device.

=C2=A0

= =C2=A0

2.=C2=A0

Drivers for RAID controllers that allow acces= s to the physical devices and logical devices will produce two EFI_EXT_SCSI= _PASS_THRU_PROTOCOL interfaces:=C2=A0=C2=A0

One with the just the EFI_EXT_SCSI_PASS_THRU_= ATTRIBUTES_PHYSICAL bit set and another with just the EFI_EXT_SCSI_PASS_THR= U_ATTRIBUTES_LOGICAL bit set. One interface can be used to access the physi= cal devices attached to the RAID controller, and the other can be used to access the logical devices attached to the R= AID controller for its current configuration.

=C2=A0

Any background why EFI_EXT_SCSI_PASS_THRU_PROTOCOL = needed 2 instances ? why can't we install attributes EFI_EXT_SCSI_PASS_= THRU_ATTRIBUTES_LOGICAL and EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL on s= ame Instance ??

How User locates the Instance with EFI_EXT_SCSI_PAS= S_THRU_ATTRIBUTES_LOGICAL bit set and Instance with EFI_EXT_SCSI_PASS_THRU_= ATTRIBUTES_PHYSICAL bit set. ??

=C2=A0<= u>

UEFI spec allows RAID drivers to only produ= ce one PassThru protocol interface

with just the XXX_PASS_THRU_LOGICAL bit set= when the RAID controller select to

not allow direct access to the underlying p= hysical devices.

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Ravi:

If the RAID D= river supports only Logical or Physical Devices then it is fine creating on= ly 1 instance and not allowing other devices which Bit is not set. (either= =C2=A0 EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL or EFI_EXT_SCSI_PASS_THRU= _ATTRIBUTES_PHYSICAL).

But if the RAID driver supports both the Logical and Physical Devices, = then we have to need 2 instances as per spec. This is going to be an over h= ead, while locating instances by the user who want to send commands to Targ= et devices connected to RAID controller.

Since each EFI_EXT_SCSI_PASS_THRU_PROTOCOL instance mus= t have an associated device path. Only 1 instance can be installed on that = particular RAID controller handle since the GUID is same for both the insta= nces.

If our intention is to filter the Logical= and Physical devices then, we can add a parameter in GetNextTartget() func= tion to inform RAID Driver which type of targets the user is looking for. (= Physical or Logical).

=C2=A0Right ??

=C2=A0

Thanks,

Ravi Kumar

=C2=A0

--0000000000000c9dd9058b302c31--