From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=sng.lists@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 28C51202E5462 for ; Mon, 9 Jul 2018 01:35:33 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id q4-v6so16331133iob.2 for ; Mon, 09 Jul 2018 01:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dxaAMdYqKsae53lNrYNE2cX0QtPdrqkKYr/S+VBo0sY=; b=Si8UOCzeG47IMC5ujkfJg4gtrBlFGFJJFGsma9CWTjjiVLqpWlCj1R1WccoS1G5rlp VadW4eEX7coVjmV5Ou+Zors5oqBKtjcteEf6nW1TETzlULfrQ4XA9+DelL83wNHE3RrC hMglBd/bNvLDyM1QsdXtBKK3hNwNk2377ZUqKfgxOmaUFo7R7wrImdCqmv8NbNzvEL9/ STLYUAuHB8BX09cm8yGd27faDVUEju825OP8NrmjpmOo7iOlxZR7Vnh8pKroNqBFvCq/ R5m7CWlTN0JDW0qEszLPJtiaFBY3qVS4cVlb005oDZK02teg4JCcJZB74VEtFrKsn/GZ 3HqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dxaAMdYqKsae53lNrYNE2cX0QtPdrqkKYr/S+VBo0sY=; b=An3hSP9R5bbJQ3vwvhsor36srNlq9aFnPxzebkA46zyB86BLItEYEt2JaXXQuBS7BW XdRduKq8v53u7iUYtxZ6LLH2GJZY4p1eYrxlunsBtSsk3YgtZvK0zKVdxURwaFiC1C04 s87DE7J5s8o4Xo9JP7ainD+rCt5cOta2W+bTlN0iRKi4UVwOfAAHSOGJaV/+iTvJsm7s kNVksJW1kJGXlipALG7mVWmPmkzSbcp7vohRbZzTALQpBvsJepGMLrxgbaN0QizWyzpM GJPiDLl8eMpMyXK6IVIG1XLe0R4bnMyfYDIzMsUE8r4JIh5z3OVT0Ck8Sqo1YT5vBj4f gntg== X-Gm-Message-State: APt69E3ptYOsXvUg6j3b94T2HVqIBBlXO+jlybMJgivdGOYZqn2WNcOn wrYKaWuysUS6Ii0g+xR5fGq4a7emiUGEP7TJB9A= X-Google-Smtp-Source: AAOMgpeGjElP2qCFDOq5ad8SnPUHCmj1OyvE73lb30bi5N9rb2bdtB55aocPKlOhGvhM7/TcDlLPPFDdBjccKy/LLN8= X-Received: by 2002:a6b:a58f:: with SMTP id o137-v6mr16299029ioe.63.1531125333062; Mon, 09 Jul 2018 01:35:33 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:8c53:0:0:0:0:0 with HTTP; Mon, 9 Jul 2018 01:35:32 -0700 (PDT) In-Reply-To: <20180703141206.xyqthexlyucxknoo@bivouac.eciton.net> References: <1530611715-9819-1-git-send-email-supreeth.venkatesh@arm.com> <1530611715-9819-3-git-send-email-supreeth.venkatesh@arm.com> <20180703141206.xyqthexlyucxknoo@bivouac.eciton.net> From: Sughosh Ganu Date: Mon, 9 Jul 2018 14:05:32 +0530 Message-ID: To: Leif Lindholm Cc: Supreeth Venkatesh , edk2-devel@lists.01.org Subject: Re: [PATCH 2/6] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 08:35:34 -0000 Content-Type: text/plain; charset="UTF-8" hi Leif, On Tue, Jul 3, 2018 at 7:42 PM, Leif Lindholm wrote: > On Tue, Jul 03, 2018 at 03:25:11PM +0530, Supreeth Venkatesh wrote: >> PI v1.5 Specification Volume 4 defines Management Mode Core Interface >> and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a >> means of communicating between drivers outside of MM and MMI >> handlers inside of MM. >> >> This patch implements the EFI_MM_COMMUNICATION_PROTOCOL DXE runtime >> driver for AARCH64 platforms. It uses SMCs allocated from the standard >> SMC range defined in DEN0060A_ARM_MM_Interface_Specification.pdf > > I would prefer the document to be referred to by its official name and > its document number: > ARM Management Mode Interface Specification (ARM DEN0060A) > >> to communicate with the standalone MM environment in the secure world. >> >> This patch also adds the MM Communication driver (.inf) file to >> define entry point for this driver and other compile >> related information the driver needs. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Achin Gupta >> Signed-off-by: Supreeth Venkatesh > > Oh, and only one Signed-off-by per patch please. > If authorship is to be indicated, ensure that's correct in git before > calling format-patch. Supreeth has moved onto some other work, hence I will be working on the upstreaming of these patches henceforth. Will handle your comments on all the patches and send an updated version. Regarding the inclusion of a single Signed-off-By, i have a doubt. Work on these patches was initially done by Achin, and then Supreeth. I will be handling your review comments and posting the updated version. You have posted a comment saying that we can have only a single s-o-b in any given patch. In such a scenario, how can we attribute the work done by all the engineers for these patches. Can you please let me know on this. As per my understanding, other projects do allow multiple s-o-b's per patch. Thanks. -sughosh