From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1EF539419D8 for ; Wed, 6 Sep 2023 11:56:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ie4mUhoQLiPa9mS7FaUadOqkq3nLC5zRnLpmW4XgGgE=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1694001371; v=1; b=lI5BiRaLGQ/XjYc50tgoLKymMq71B4pXqSEwKX2B3h2pcGmWBEia5qjQHWjkO9B7GHlMPQhy IQ4DTtzazR2B5sShINzEYfetEmnjhV+vVsShN6ggjd9QeU5L/IRAe1y7Zk0jx4HQEgu6Ge0gsKy iDngGLxSTyElWj5N4i8fjhdA= X-Received: by 127.0.0.2 with SMTP id Mrc6YY7687511xZObOvwvgmO; Wed, 06 Sep 2023 04:56:11 -0700 X-Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.groups.io with SMTP id smtpd.web11.6463.1694001371114535593 for ; Wed, 06 Sep 2023 04:56:11 -0700 X-Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-401bbfc05fcso36869435e9.3 for ; Wed, 06 Sep 2023 04:56:10 -0700 (PDT) X-Gm-Message-State: DXZrDtY6J7Jh7ac5tlYsD3oex7686176AA= X-Google-Smtp-Source: AGHT+IFfrtdc8AQhWqUGrL1FdeEyEw6AG5cNIAugirzGjKvSGZ3oTE9nnroRo+uttllJV/m1Fy+efrwHPbqxi4knV4Y= X-Received: by 2002:a5d:67c8:0:b0:319:6896:6e8e with SMTP id n8-20020a5d67c8000000b0031968966e8emr2027756wrw.62.1694001369034; Wed, 06 Sep 2023 04:56:09 -0700 (PDT) MIME-Version: 1.0 References: <20230906103338.3320-2-mjsbeaton@gmail.com> In-Reply-To: <20230906103338.3320-2-mjsbeaton@gmail.com> From: "Mike Beaton" Date: Wed, 6 Sep 2023 12:55:57 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH v3] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size To: devel@edk2.groups.io Cc: Eric Dong , Dandan Bi , Ard Biesheuvel Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mjsbeaton@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lI5BiRaL; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 6 Sept 2023 at 11:34, Mike Beaton wrote: > > AsciiStrLen was one byte too short (though with alignment up from an odd size > would probably always have had the required space in practice). AsciiStrSize > matches usage elsewhere in this file and in the codebase. I was intended to cc Ard Biesheuvel as well - I hope that is okay, since you have definitely committed on this file (as no doubt many others!) - but I managed to use your now-bouncing old email address from one of those earlier commits, so I have fixed that in this reply, and also removed from the cc list the addresses of a couple of Intel employees who originally authored or worked on this file but which now bounce. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108328): https://edk2.groups.io/g/devel/message/108328 Mute This Topic: https://groups.io/mt/101189764/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-