From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EE6FAD81195 for ; Thu, 14 Dec 2023 09:37:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WMXwkS5NGZ10WFxuqoTrpeAJ4QnSsxrPOZXC7FW/cso=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1702546673; v=1; b=oCHJM/Bs9yfIUIkSu4UKc+QI8VfdqIsnrf8exW9p7eiNxQCmIMX/4BAQhphRcGNfYf+6fiOr 0FTQTGJD9lkmHNKJN/C40TLzvYGLR69muz3RSMPLAe5mEuJiwyc3Y4XcYxet+uV5fTS8V8Md6IM oYCVSUW1I3BQsUUK83z/IwY0= X-Received: by 127.0.0.2 with SMTP id 14ZqYY7687511xh9OWQDKG2i; Thu, 14 Dec 2023 01:37:53 -0800 X-Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.groups.io with SMTP id smtpd.web10.18399.1702546672821785161 for ; Thu, 14 Dec 2023 01:37:53 -0800 X-Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-40c2308faedso81180325e9.1 for ; Thu, 14 Dec 2023 01:37:52 -0800 (PST) X-Gm-Message-State: LZ31XrFT99MdrwSIOQN2ngyWx7686176AA= X-Google-Smtp-Source: AGHT+IFLpCmaFThS617TBjGzQYG2HtMnI78bZ7mm6VZ0y4I+JDMlgKBt4ZoPkP5Q1pogKCCmZG9KoJz1HyfHM4hh3bM= X-Received: by 2002:a05:600c:3b26:b0:40c:de2:148c with SMTP id m38-20020a05600c3b2600b0040c0de2148cmr4938310wms.47.1702546670428; Thu, 14 Dec 2023 01:37:50 -0800 (PST) MIME-Version: 1.0 References: <20231214075748.9682-1-mjsbeaton@gmail.com> In-Reply-To: From: "Mike Beaton" Date: Thu, 14 Dec 2023 09:37:39 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH V5] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined To: Ard Biesheuvel Cc: devel@edk2.groups.io, Michael Kubacki , lersek@redhat.com, rebecca@bsdio.com, gaoliming@byosoft.com.cn, michael.d.kinney@intel.com, afish@apple.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mjsbeaton@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="oCHJM/Bs"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) > IOW, please don't send a v6 until the discussion comes to a conclusion. Apologies, I did _not_ see this before sending. > > - #if !defined (MDEPKG_NDEBUG) > > + #if defined (__CC_ARM) || defined (__GNUC__) > > No, this is not going to be acceptable to me. You noted that only the > ARM code seems to suffer from this issue, so surely, we can find a way > to change this code that doesn't introduce spurious dependencies on > the exact toolchain we are using. With all due respect, I believe that you are incorrect that this is spurious. Please check the surrounding code (specifically, this compiler dependency exactly matches - and is there because of - a compiler dependency in the surrounding code). (Additionally, though it doesn't affect the point either way, I thought this is what you had spotted and were asking for, when previously saying "What about GCC?"!) Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112515): https://edk2.groups.io/g/devel/message/112515 Mute This Topic: https://groups.io/mt/103166459/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-