From: "Mike Beaton" <mjsbeaton@gmail.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: devel@edk2.groups.io, ardb@google.com, lersek@redhat.com
Subject: Re: [edk2-devel] [PATCH] DebugLib: Allow -Wunneeded-internal-declaration with clang
Date: Tue, 12 Dec 2023 12:57:08 +0000 [thread overview]
Message-ID: <CAHzAAWQB82VUj771etdKNP3+6R0di7aapX+ciyJPptvVb+ra7g@mail.gmail.com> (raw)
In-Reply-To: <CAMj1kXHKKQAH3Xc_m1PuT3EqF_3hKxAksRA+fpf4D-j9i7ak-A@mail.gmail.com>
> You failed to mention where you found this patch.
It's from https://github.com/acidanthera/audk/commit/dcd0a768b0f
(which actually contains the code described in its commit message, but
I believe some other code, including this specific part, which got
squashed in at some point, and I believe is from the committer, not
the alleged author actually!).
Would it work to just add that origin commit to the commit message
(given the licensing, which is the same as EDK-II, ofc), or would you
prefer/need an additional Signed-off-by:? (Instead?)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112390): https://edk2.groups.io/g/devel/message/112390
Mute This Topic: https://groups.io/mt/103126777/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-12-12 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 8:48 [edk2-devel] [PATCH] DebugLib: Allow -Wunneeded-internal-declaration with clang Mike Beaton
2023-12-12 9:26 ` Ard Biesheuvel
2023-12-12 10:33 ` Mike Beaton
2023-12-12 15:26 ` Laszlo Ersek
2023-12-12 12:57 ` Mike Beaton [this message]
2023-12-12 15:28 ` Laszlo Ersek
2023-12-12 15:33 ` Mike Beaton
2023-12-12 16:52 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHzAAWQB82VUj771etdKNP3+6R0di7aapX+ciyJPptvVb+ra7g@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox