From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B94527803D1 for ; Tue, 12 Dec 2023 12:57:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rXNziXZixsqB/+qNIJBO3DjQMrUXIfgRysYNjFvD450=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1702385842; v=1; b=R6wYOF10xVipyz9hPpzH4x7z6pvC/afyb0NNXsgO869cfNbzAXCZ73btL30nafWalxeyr3xC yI1Wrjo3HFCDOKdME3GgveiHMdk+V7/GF7825h3Ej5DmWNQDpBhDr4Sv+mW5guUHs3mBq7fag6G 0X3Fk7m+r4YsN5EXJ6k1Xxdk= X-Received: by 127.0.0.2 with SMTP id PvuZYY7687511x1OKB0fyFPV; Tue, 12 Dec 2023 04:57:22 -0800 X-Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.groups.io with SMTP id smtpd.web10.992.1702385841415738819 for ; Tue, 12 Dec 2023 04:57:21 -0800 X-Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3360ae1b937so2735747f8f.0 for ; Tue, 12 Dec 2023 04:57:21 -0800 (PST) X-Gm-Message-State: U7H9hT8cubNi0wzIxXQGJotSx7686176AA= X-Google-Smtp-Source: AGHT+IGfS1Gxni1JGEsQjg3fMH1r0/pFmlGZqWsJfuoyx8gWet+S6IR0HjhBxvaM4VuBafVZUDz9/w9bqtIeyJRJWt8= X-Received: by 2002:adf:ed07:0:b0:333:3d3d:3219 with SMTP id a7-20020adfed07000000b003333d3d3219mr3434275wro.81.1702385839691; Tue, 12 Dec 2023 04:57:19 -0800 (PST) MIME-Version: 1.0 References: <20231212084856.118099-1-mjsbeaton@gmail.com> In-Reply-To: From: "Mike Beaton" Date: Tue, 12 Dec 2023 12:57:08 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH] DebugLib: Allow -Wunneeded-internal-declaration with clang To: Ard Biesheuvel Cc: devel@edk2.groups.io, ardb@google.com, lersek@redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mjsbeaton@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=R6wYOF10; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > You failed to mention where you found this patch. It's from https://github.com/acidanthera/audk/commit/dcd0a768b0f (which actually contains the code described in its commit message, but I believe some other code, including this specific part, which got squashed in at some point, and I believe is from the committer, not the alleged author actually!). Would it work to just add that origin commit to the commit message (given the licensing, which is the same as EDK-II, ofc), or would you prefer/need an additional Signed-off-by:? (Instead?) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112390): https://edk2.groups.io/g/devel/message/112390 Mute This Topic: https://groups.io/mt/103126777/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-