From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3967C74004D for ; Tue, 12 Dec 2023 10:12:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LCqPr84QFTVC56uJD9zTUvvGx6RHdZF2AEQwwjCLIvI=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1702375952; v=1; b=d7IexDr2s9f7Zo2I309898XXa1mnfvdC7j3iuNKIWd5XVNSjyfMKeS+E0LC8f85FFG4Ul0gI /Cp3+FTcaKQ9byIp228u5LjRJAiUurAjWouOUuC/9cSgx1JJiEvrW2NVUfdP6JIFi5A8xHjwAXV eW9w5dfxFMHghUWhm1bZroeY= X-Received: by 127.0.0.2 with SMTP id bFeiYY7687511xfjgwvHKyzi; Tue, 12 Dec 2023 02:12:32 -0800 X-Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.groups.io with SMTP id smtpd.web10.13428.1702375952080647785 for ; Tue, 12 Dec 2023 02:12:32 -0800 X-Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-336210c34ebso1903101f8f.1 for ; Tue, 12 Dec 2023 02:12:31 -0800 (PST) X-Gm-Message-State: Crb5Ee6FiieFYQp91KX99vqsx7686176AA= X-Google-Smtp-Source: AGHT+IF+RbpYawmayZeKjaNTyRx4ShLGvUwOjWQnqkwYV86kopi9ueJgfFHZ6QiuA7guq4G0BHUIMyr/N5ZBRTZPaI0= X-Received: by 2002:a5d:58ea:0:b0:336:3456:fd1d with SMTP id f10-20020a5d58ea000000b003363456fd1dmr162160wrd.82.1702375950250; Tue, 12 Dec 2023 02:12:30 -0800 (PST) MIME-Version: 1.0 References: <20231210101859.19198-1-mjsbeaton@gmail.com> <9b333ba1-7ce6-5be7-6482-3aadef7f1973@redhat.com> <12387048-80bf-87db-c15e-55583678863f@redhat.com> <1a51ab01-6a06-af3d-5068-86e6668fd6ec@redhat.com> In-Reply-To: From: "Mike Beaton" Date: Tue, 12 Dec 2023 10:12:18 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH] BaseTools/tools_def: Disable unneeded-internal-declaration warning in CLANGPDB To: Ard Biesheuvel Cc: Laszlo Ersek , devel@edk2.groups.io, Ard Biesheuvel Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mjsbeaton@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=d7IexDr2; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > I have realised that this was already fixed (i.e. allowing keeping the > warning) in Acidanthera fork of EDK-II. Discussed here > https://bugzilla.tianocore.org/show_bug.cgi?id=3704 - includes the fix > in question and other fixes for newer gcc as well. I'll post a new > patch to the list proposing just the relevant fix for clang. I'm discussing this with the Acidanthera authors, and coming round to prefer the version proposed above, with no pragmas, actually. I think Ard is saying that, while I misdescribed somewhat when things would be optimised away, that they will be optimised away, and that probably the object files wouldn't be polluted, with this version? I'm running some further tests to confirm that the simple version proposed above builds in all the Acidanthera test environments, which is relevant in that it should rule out at least any obvious problems with it building in all edk-2 environments, too. (I had already run quick tests for CLANGDWARF, CLANGPDB and GCC RELEASE in edk2, with no problems.) If there aren't any issues there, I'd prefer to submit a patch for this simple version instead (combined with removing the -Wno-unneeded-internal-declaration for clangdwarf). -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112385): https://edk2.groups.io/g/devel/message/112385 Mute This Topic: https://groups.io/mt/103087794/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-