Re: [edk2-devel] [PATCH v3] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size

["Mike Beaton" <mjsbeaton@gmail.com>]

On Wed, 6 Sept 2023 at 12:55, Mike Beaton <mjsbeaton@gmail.com> wrote:
>
> On Wed, 6 Sept 2023 at 11:34, Mike Beaton <mjsbeaton@gmail.com> wrote:
> >
> > AsciiStrLen was one byte too short (though with alignment up from an odd size
> > would probably always have had the required space in practice). AsciiStrSize
> > matches usage elsewhere in this file and in the codebase.

Have just realised that the severity is worse than implied in my
current commit message,
since not only are (potentially - though almost certainly not, in practice) too
few bytes allocated, but definitely too few bytes are then copied, so
the resulting string is
only null terminated by the grace of the specific implementation, too.
Could update to a v4
of this (small) patch with a commit message mentioning this?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108329): https://edk2.groups.io/g/devel/message/108329
Mute This Topic: https://groups.io/mt/101189764/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-