From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5F1D4AC0DF1 for ; Wed, 21 Aug 2024 11:36:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=vrtHfBcUaTUKywOKXQlDh884ZsFQunlU8W0K0KK/8U4=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1724240202; v=1; b=vB9TNCnUmy14VlJqGO08pKCPvjUFaH2IhYSB7JBqF8fn/IcKoNxlSwg7WhoT9V4jN5zQLNp2 BA1ehbAtQ804cXSd5FuJK2N8RHulTcS3BNua6Df3kxW07hecDmqoK7Iq8VwqPZaIYHz/+4mNDHc u/8do9wS92c5vxQvtp5d9K9EdKA2LphTuPp9SFyaPHpmdam3HmmlvD9MCiBmDV/rt1gbbrCT1F3 6m/DMwTStcs0rKmc2ZC2yYG+QPklk4H+D8IDaV8JBOBBQcSH9n7xV2lSiJto6x5tHD/hXaDhRmU miJhPveDSZuvHIJXN+38rRX/Xs79yeNwxhchtHv2Ps0Cw== X-Received: by 127.0.0.2 with SMTP id Dqb1YY7687511xraapsUovaC; Wed, 21 Aug 2024 04:36:40 -0700 X-Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.groups.io with SMTP id smtpd.web10.17580.1724240194973055030 for ; Wed, 21 Aug 2024 04:36:35 -0700 X-Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-42816ca782dso55435155e9.2 for ; Wed, 21 Aug 2024 04:36:34 -0700 (PDT) X-Gm-Message-State: BILiTiEGg2HONYO9zqPRFH9Vx7686176AA= X-Google-Smtp-Source: AGHT+IGtXyCQyZLx9yGn+j4j5bcIpihaM767IfwKbfBfTUuAKSihfIMziKl1PIgPHPgsMjNyoX4fPBFokM27x8smCI0= X-Received: by 2002:a5d:4539:0:b0:368:48b1:803 with SMTP id ffacd0b85a97d-372fd57c9abmr1173200f8f.12.1724240192287; Wed, 21 Aug 2024 04:36:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Mike Beaton" Date: Wed, 21 Aug 2024 12:36:20 +0100 Message-ID: Subject: Re: [edk2-devel] Non-obvious network boot stack issues in OVMF after 4c4ceb2 (NetworkPkg: SECURITY PATCH CVE-2023-45237) To: Gerd Hoffmann Cc: devel@edk2.groups.io, Ard Biesheuvel , dougflick@microsoft.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 21 Aug 2024 04:36:35 -0700 Resent-From: mjsbeaton@gmail.com Reply-To: devel@edk2.groups.io,mjsbeaton@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=vB9TNCnU; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 21 Aug 2024 at 11:38, Gerd Hoffmann wrote: > > On Sat, Aug 10, 2024 at 10:08:20AM GMT, Mike Beaton wrote: > > The network boot stack fails to load in OVMF after > > 4c4ceb2ceb80c42fd5545b2a4bd80321f07f4345 (NetworkPkg: SECURITY PATCH > > CVE-2023-45237): https://bugzilla.tianocore.org/show_bug.cgi?id=4827 > > > > I have now understood that this is because the network stack drivers > > have been updated to require an instance of gEfiRngProtocolGuid, so > > OVMF now requires the `-device virtio-rng-pci` qemu option in order > > for the network stack to load (this flag is required in order for > > VirtioRngDxe to be able to provide the required protocol). > > FYI: With the upcoming 2024-08 stable tag this will be relaxed, > a CPU with rdrand instruction support will work too as source > for random numbers. > > See https://github.com/tianocore/edk2/pull/5714 for details. > > > 1. This is rather non-obvious - previously, the user set the > > compilation options for the network stack, and the network stack > > started. Ideally, perhaps, this would be fixed by adding some > > documentation somewhere easily found, but I am not sure where. (By the > > way, we don't get any helpful asserts which would lead us in the right > > direction; the depex is never satisfied, so the network stack drivers > > just never load.) > > Yep. When it comes to diagnostics there is clearly room for > improvement. > > > 2. I also spotted that OvmfXen has neither RngDxe nor VirtioRngDxe - I > > have never used OvmfXen, so I am not sure about this but (since these > > seem to be the only two drivers which produce gEfiRngProtocolGuid) at > > least at first glance it looks as if OvmfXen won't have any RNG for > > the network stack now, so that it's network stack would not start? > > There is a patch for that too in master branch, so upcoming 2024-08 > should be fine here. > > It has been somewhat bumpy road due to the last minute merge of the > fixes so some fallout has been fixed only after the 2024-05 stable tag. > > HTH & take care, > Gerd Thank you for these clarifications, that is helpful. Appreciated! Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120388): https://edk2.groups.io/g/devel/message/120388 Mute This Topic: https://groups.io/mt/107822587/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-