From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B611A74004D for ; Mon, 4 Sep 2023 14:25:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6WUneUVG/nhUBnAmhJIr6oNDGI4+qRWeNRSdxS5VRaI=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1693837508; v=1; b=d0+F0MPU0LOhuNbyvANeBigbGdgl6U9uhUd/DncDwnwDnnqOq3BIjAB/I8M9wT0PDCesKT6L P1zJhrJzVqV1VImcH0Qp58z7jqhQYRjwQv/TavtiQODSJXiPTi9PrxCsEjMP3ZvL9lT1rFvbXyO u5Gke/52FMgyHrI96WJQICJo= X-Received: by 127.0.0.2 with SMTP id MZ1ZYY7687511xe54HkGB157; Mon, 04 Sep 2023 07:25:08 -0700 X-Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mx.groups.io with SMTP id smtpd.web11.49546.1693837507622497677 for ; Mon, 04 Sep 2023 07:25:07 -0700 X-Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-31c8321c48fso1458433f8f.1 for ; Mon, 04 Sep 2023 07:25:07 -0700 (PDT) X-Gm-Message-State: E4ngLcYXj63PpnLWGm8q3BHEx7686176AA= X-Google-Smtp-Source: AGHT+IF65eD0dVlqpfjSJxqVChq+GQIZqExrXwfn92oxp/FQfZvGfVtVtNWyNHdFW3j569VakEc2mE/LVnW3CxHKs58= X-Received: by 2002:a5d:48ce:0:b0:317:417e:a467 with SMTP id p14-20020a5d48ce000000b00317417ea467mr9883960wrs.6.1693837505520; Mon, 04 Sep 2023 07:25:05 -0700 (PDT) MIME-Version: 1.0 References: <20230208180138.430549-1-rebecca@quicinc.com> In-Reply-To: From: "Mike Beaton" Date: Mon, 4 Sep 2023 15:24:54 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU To: devel@edk2.groups.io Cc: Rebecca Cran , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mjsbeaton@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=d0+F0MPU; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > -----Original Message----- > From: Rebecca Cran > Sent: Wednesday, February 8, 2023 6:02 PM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Ard Biesheuvel ; Jiewen Yao ; Jordan Justen ; Gerd Hoffmann > Subject: [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU > > Allow users to build OVMF then run QEMU by moving the build block above > the run block and removing the exit line. > > Signed-off-by: Rebecca Cran > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > --- > OvmfPkg/build.sh | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh > index 91b1442ade6b..b0334fb76e74 100755 > --- a/OvmfPkg/build.sh > +++ b/OvmfPkg/build.sh > @@ -245,6 +245,11 @@ else > echo using prebuilt tools > fi > > +# > +# Build the edk2 OvmfPkg > +# > +echo Running edk2 build for OvmfPkg$Processor > +build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER -DDEBUG_ON_SERIAL_PORT=TRUE > > if [[ "$RUN_QEMU" == "yes" ]]; then > if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then > @@ -260,11 +265,3 @@ if [[ "$RUN_QEMU" == "yes" ]]; then > $QEMU_COMMAND "$@" > exit $? > fi > - > -# > -# Build the edk2 OvmfPkg > -# > -echo Running edk2 build for OvmfPkg$Processor > -build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER > -exit $? > - > -- > 2.30.2 Hi, I was trying to raise the issue that I believe this change from Feb. of this year breaks intended and useful previous behaviour. It occurred to me that replying to the original post might make most sense. I've raised what I think are the issues here: https://bugzilla.tianocore.org/show_bug.cgi?id=4528 . WIth many thanks in advance for your attention. Mike Beaton -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108260): https://edk2.groups.io/g/devel/message/108260 Mute This Topic: https://groups.io/mt/96836052/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-