[PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU

[PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU

[Rebecca Cran]

Allow users to build OVMF then run QEMU by moving the build block above
the run block and removing the exit line.

Signed-off-by: Rebecca Cran <rebecca@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
---
 OvmfPkg/build.sh | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 91b1442ade6b..b0334fb76e74 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -245,6 +245,11 @@ else
   echo using prebuilt tools
 fi
 
+#
+# Build the edk2 OvmfPkg
+#
+echo Running edk2 build for OvmfPkg$Processor
+build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER -DDEBUG_ON_SERIAL_PORT=TRUE
 
 if [[ "$RUN_QEMU" == "yes" ]]; then
   if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then
@@ -260,11 +265,3 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
   $QEMU_COMMAND "$@"
   exit $?
 fi
-
-#
-# Build the edk2 OvmfPkg
-#
-echo Running edk2 build for OvmfPkg$Processor
-build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER
-exit $?
-
-- 
2.30.2

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU

[Gerd Hoffmann]

On Wed, Feb 08, 2023 at 11:01:38AM -0700, Rebecca Cran wrote:
> Allow users to build OVMF then run QEMU by moving the build block above
> the run block and removing the exit line.
> 
> Signed-off-by: Rebecca Cran <rebecca@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU

[Ard Biesheuvel]

On Thu, 9 Feb 2023 at 14:22, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Wed, Feb 08, 2023 at 11:01:38AM -0700, Rebecca Cran wrote:
> > Allow users to build OVMF then run QEMU by moving the build block above
> > the run block and removing the exit line.
> >
> > Signed-off-by: Rebecca Cran <rebecca@quicinc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
>

Merged as #4024

Thanks,

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU

[Mike Beaton]

> -----Original Message-----
> From: Rebecca Cran <quic_rcran@quicinc.com>
> Sent: Wednesday, February 8, 2023 6:02 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Jiewen Yao <jiewen.yao@intel.com>; Jordan Justen <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
> Subject: [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU
>
> Allow users to build OVMF then run QEMU by moving the build block above
> the run block and removing the exit line.
>
> Signed-off-by: Rebecca Cran <rebecca@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  OvmfPkg/build.sh | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 91b1442ade6b..b0334fb76e74 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -245,6 +245,11 @@ else
>    echo using prebuilt tools
>  fi
>
> +#
> +# Build the edk2 OvmfPkg
> +#
> +echo Running edk2 build for OvmfPkg$Processor
> +build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER -DDEBUG_ON_SERIAL_PORT=TRUE
>
>  if [[ "$RUN_QEMU" == "yes" ]]; then
>    if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then
> @@ -260,11 +265,3 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>    $QEMU_COMMAND "$@"
>    exit $?
>  fi
> -
> -#
> -# Build the edk2 OvmfPkg
> -#
> -echo Running edk2 build for OvmfPkg$Processor
> -build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER
> -exit $?
> -
> --
> 2.30.2

Hi,

I was trying to raise the issue that I believe this change from Feb.
of this year breaks intended and useful previous behaviour. It
occurred to me that replying to the original post might make most
sense. I've raised what I think are the issues here:
https://bugzilla.tianocore.org/show_bug.cgi?id=4528 .

WIth many thanks in advance for your attention.

Mike Beaton


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108260): https://edk2.groups.io/g/devel/message/108260
Mute This Topic: https://groups.io/mt/96836052/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU

[Rebecca Cran]

Sorry I've not responded to your emails before now.

I don't normally use the build.sh script, so I'm fine with reverting to 
the previous behavior.


-- 

Rebecca Cran


On 9/4/23 08:24, Mike Beaton wrote:
>> -----Original Message-----
>> From: Rebecca Cran <quic_rcran@quicinc.com>
>> Sent: Wednesday, February 8, 2023 6:02 PM
>> To: devel@edk2.groups.io
>> Cc: Rebecca Cran <rebecca@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Jiewen Yao <jiewen.yao@intel.com>; Jordan Justen <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
>> Subject: [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU
>>
>> Allow users to build OVMF then run QEMU by moving the build block above
>> the run block and removing the exit line.
>>
>> Signed-off-by: Rebecca Cran <rebecca@quicinc.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>>   OvmfPkg/build.sh | 13 +++++--------
>>   1 file changed, 5 insertions(+), 8 deletions(-)
>>
>> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
>> index 91b1442ade6b..b0334fb76e74 100755
>> --- a/OvmfPkg/build.sh
>> +++ b/OvmfPkg/build.sh
>> @@ -245,6 +245,11 @@ else
>>     echo using prebuilt tools
>>   fi
>>
>> +#
>> +# Build the edk2 OvmfPkg
>> +#
>> +echo Running edk2 build for OvmfPkg$Processor
>> +build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER -DDEBUG_ON_SERIAL_PORT=TRUE
>>
>>   if [[ "$RUN_QEMU" == "yes" ]]; then
>>     if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then
>> @@ -260,11 +265,3 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>>     $QEMU_COMMAND "$@"
>>     exit $?
>>   fi
>> -
>> -#
>> -# Build the edk2 OvmfPkg
>> -#
>> -echo Running edk2 build for OvmfPkg$Processor
>> -build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER
>> -exit $?
>> -
>> --
>> 2.30.2
> Hi,
>
> I was trying to raise the issue that I believe this change from Feb.
> of this year breaks intended and useful previous behaviour. It
> occurred to me that replying to the original post might make most
> sense. I've raised what I think are the issues here:
> https://bugzilla.tianocore.org/show_bug.cgi?id=4528 .
>
> WIth many thanks in advance for your attention.
>
> Mike Beaton
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108265): https://edk2.groups.io/g/devel/message/108265
Mute This Topic: https://groups.io/mt/96836052/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU

[Mike Beaton]

[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]

On Mon, 4 Sept 2023, 21:14 Rebecca Cran, <rebecca@bsdio.com> wrote:

> Sorry I've not responded to your emails before now.
>
> I don't normally use the build.sh script, so I'm fine with reverting to
> the previous behavior.
>

Ah - thank you for the response - that'd be great, if the original people
who ack-d and committed are fine to approve the change back too.

I did put up a patch to this list (my v2 patch reverts the change, and at
the same time removes an unwanted extra white space line which was actually
there at the end of the original file) - but I am tbh not as familiar as I
should be with text-based patches, I'll double check the process and check
that it applies using (whatever I find out) the normal commands (are...!).

Mike

>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108275): https://edk2.groups.io/g/devel/message/108275
Mute This Topic: https://groups.io/mt/96836052/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 2131 bytes --]