From: "Mike Beaton" <mjsbeaton@gmail.com>
To: devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size
Date: Thu, 24 Aug 2023 06:54:54 +0100 [thread overview]
Message-ID: <CAHzAAWS9xoCR5CNOu0SAzpnD=XO9fjWE+8SDAMc_hxnDC3X39Q@mail.gmail.com> (raw)
In-Reply-To: <CAHzAAWQWOhr2pjgL6Mqd6WYE-OimUyEHMdAjQ-v46-QvnfaEqw@mail.gmail.com>
Apologies, no Signed-off-by, I will send v2.
On Thu, 24 Aug 2023 at 06:52, Mike Beaton <mjsbeaton@gmail.com> wrote:
>
> ---
> MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
> index 96e05d4cf9..f67b7760f0 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
> @@ -1987,7 +1987,7 @@ GetNameFromId (
> NULL
> );
> if (BestLanguage == NULL) {
> - BestLanguage = AllocateCopyPool (AsciiStrLen ("en-US"), "en-US");
> + BestLanguage = AllocateCopyPool (AsciiStrSize ("en-US"), "en-US");
> ASSERT (BestLanguage != NULL);
> }
> --
> 2.37.5
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107999): https://edk2.groups.io/g/devel/message/107999
Mute This Topic: https://groups.io/mt/100930530/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-08-24 5:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 5:52 [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size Mike Beaton
2023-08-24 5:54 ` Mike Beaton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHzAAWS9xoCR5CNOu0SAzpnD=XO9fjWE+8SDAMc_hxnDC3X39Q@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox