From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 00F06AC0AEE for ; Thu, 24 Aug 2023 05:55:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9TcDWJu+4ukdEsUBgu3lfg2xM54ADk9ykkV/FH8889w=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1692856508; v=1; b=OUkODpR5OzOCbcQUp843yYR2ycMNSpLP+vNjKs1m/9JKlC97zBaSLI+k9ayXKUIbIKd8ochi /IeNg1lFgpW9abh2QBT4MWpYZ4idL+UcSnaXkUwsQ6bQOCPB3Zyftrc7pJ6VBs3iGpczpUxsxtY Zvj730qkXYjEejVZSw4CEXEg= X-Received: by 127.0.0.2 with SMTP id SHwcYY7687511xJ5rIxRL1a5; Wed, 23 Aug 2023 22:55:08 -0700 X-Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.groups.io with SMTP id smtpd.web11.4745.1692856507689250844 for ; Wed, 23 Aug 2023 22:55:08 -0700 X-Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4018af1038cso1297465e9.0 for ; Wed, 23 Aug 2023 22:55:07 -0700 (PDT) X-Gm-Message-State: t6wx35F3l9be5KKoZWJ5CwGCx7686176AA= X-Google-Smtp-Source: AGHT+IHRPMz+SXv93fwYnrMAEUZ8rb3YxPNOis5B5v0asase7CD7IfT98Zh0ujJ/U0bVh98BFbfVVBkUK6PrSL79S98= X-Received: by 2002:adf:e94a:0:b0:314:39d0:26f6 with SMTP id m10-20020adfe94a000000b0031439d026f6mr10885369wrn.18.1692856505537; Wed, 23 Aug 2023 22:55:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Mike Beaton" Date: Thu, 24 Aug 2023 06:54:54 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size To: devel@edk2.groups.io Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mjsbeaton@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OUkODpR5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Apologies, no Signed-off-by, I will send v2. On Thu, 24 Aug 2023 at 06:52, Mike Beaton wrote: > > --- > MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c > b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c > index 96e05d4cf9..f67b7760f0 100644 > --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c > @@ -1987,7 +1987,7 @@ GetNameFromId ( > NULL > ); > if (BestLanguage == NULL) { > - BestLanguage = AllocateCopyPool (AsciiStrLen ("en-US"), "en-US"); > + BestLanguage = AllocateCopyPool (AsciiStrSize ("en-US"), "en-US"); > ASSERT (BestLanguage != NULL); > } > -- > 2.37.5 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107999): https://edk2.groups.io/g/devel/message/107999 Mute This Topic: https://groups.io/mt/100930530/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-