From: "Mike Beaton" <mjsbeaton@gmail.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb@google.com>
Subject: Re: [edk2-devel] RELEASE CLANGPDB OVMF currently does not compile
Date: Sun, 10 Dec 2023 09:41:57 +0000 [thread overview]
Message-ID: <CAHzAAWSOmsh8tGbnbdH0iADQnZGkdXHfn+HGi7pnPXeb=fZCmA@mail.gmail.com> (raw)
In-Reply-To: <CAMj1kXEs6dxgxBBG63ypYOW24+DQJ172UidaOVBB8Fix_ch4_w@mail.gmail.com>
> Removing STATIC means that (modulo LTO) the compiler will not know
> whether or not the definition can be dropped. It also pollutes the
> global namespace.
>
> IMO, lack of the use of STATIC where appropriate is a severe issue
> with the EDK2 codebase. Removing STATIC to appease compiler
> diagnostics is *not* the way to solve this.
Thank you for your feedback. On reflection, since gcc still _can_
distinguish between genuinely unused variables and variables who usage
was optimized away like this (I think that's well known; but I just
double-checked by adding a similar, but entirely unused variable to
the same file - gcc then complains), and since all code in the project
is going to end up being compiled under gcc as well clang, then just
squelching the (slightly broken) warning under clang is not really
losing useful information after all, in this case. So thank you for
the ack, and agreed, now, that it is the best way to proceed.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112258): https://edk2.groups.io/g/devel/message/112258
Mute This Topic: https://groups.io/mt/103083030/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-12-10 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 0:25 [edk2-devel] RELEASE CLANGPDB OVMF currently does not compile Mike Beaton
2023-12-10 8:07 ` Ard Biesheuvel
2023-12-10 9:41 ` Mike Beaton [this message]
2023-12-10 10:20 ` Mike Beaton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHzAAWSOmsh8tGbnbdH0iADQnZGkdXHfn+HGi7pnPXeb=fZCmA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox