From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 67BB4AC1C67 for ; Wed, 13 Dec 2023 23:44:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mnvBfy+HJ3NQl8fH76Iy+Dl/Yd9/s8jlmh639KhYO9M=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1702511072; v=1; b=Kz5ld2/a1hAvd/Fp63/52gy0YnE3GpJGniWntp8ViPfwuJylrKNSM5o6FSx1C0BCVPDFEYQB wvDe8RXlQUD6F9Yx45PGsDYbCa1+dXiZbNBA8Y3n23/r6H0pF4XGEWqqi4GdNmbAAO485bsiKrC qnlZI227DZldJjQ0e6Om595w= X-Received: by 127.0.0.2 with SMTP id ReZLYY7687511xv67IHeTcEM; Wed, 13 Dec 2023 15:44:32 -0800 X-Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.groups.io with SMTP id smtpd.web11.9296.1702511072081301167 for ; Wed, 13 Dec 2023 15:44:32 -0800 X-Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-40c3f68b79aso55977505e9.0 for ; Wed, 13 Dec 2023 15:44:31 -0800 (PST) X-Gm-Message-State: QWqtHMDfcqrmkbfcSNNNTENjx7686176AA= X-Google-Smtp-Source: AGHT+IGVRg1XiMnIDd7eJnivcgv9Jn68THd4T5L3Rx775HDCsEN0S+VFG0+8JyMicgU2T/j82geIUNaJVft3JNsF60o= X-Received: by 2002:a05:600c:444f:b0:40c:5e5f:d3c0 with SMTP id v15-20020a05600c444f00b0040c5e5fd3c0mr749804wmn.21.1702511069814; Wed, 13 Dec 2023 15:44:29 -0800 (PST) MIME-Version: 1.0 References: <20231213230741.168859-1-mjsbeaton@gmail.com> In-Reply-To: <20231213230741.168859-1-mjsbeaton@gmail.com> From: "Mike Beaton" Date: Wed, 13 Dec 2023 23:44:18 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH V3] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined To: devel@edk2.groups.io Cc: ardb@google.com, lersek@redhat.com, mcb30@ipxe.org, Mikhail Krichanov Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mjsbeaton@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Kz5ld2/a"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io I have currently gone with `if (FALSE)` in the above, even though Michael Brown kindly offered tests which showed that `if ((FALSE))` might help in a closely related context - i.e. when discussing Mikhail's variant of this and related code - two years ago now: https://edk2.groups.io/g/devel/message/83938 (and see https://bugzilla.tianocore.org/show_bug.cgi?id=3704). I cannot replicate that finding, or so far find any info about it, but possibly it relates to an older version of clang? (Which if so, possibly means it doesn't matter now anyway?) >From my own tests and fairly extensive Acidanthera CI suite, `if (FALSE)` works on all current toolchains. @Ard - Does this variant still fail on Arm? It would be interesting to know which specific build of what is/was failing. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112493): https://edk2.groups.io/g/devel/message/112493 Mute This Topic: https://groups.io/mt/103160238/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-