public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Mike Beaton" <mjsbeaton@gmail.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
	devel@edk2.groups.io, Ard Biesheuvel <ardb@google.com>
Subject: Re: [edk2-devel] [PATCH] DebugLib: Allow -Wunneeded-internal-declaration with clang
Date: Tue, 12 Dec 2023 15:33:01 +0000	[thread overview]
Message-ID: <CAHzAAWSsbVikXcBA+sR6Q07xFSvdN3nb8HEXGE-h8YAzmEMT=A@mail.gmail.com> (raw)
In-Reply-To: <979a081a-eb98-2c08-4119-fcdce5552ca0@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

> I believe one way to approach it would be to (a) amend the patch with
>
>    --author="Marvin Häuser <mhaeuser@posteo.de>"
>
> and (b) have S-o-b's from both Marvin and you at the end of the commit
> message.
>

As I say, I think the code in question is actual by Mikhail, despite
appearances, but I should be able to get one of them to sign it off. Cheers.

>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112450): https://edk2.groups.io/g/devel/message/112450
Mute This Topic: https://groups.io/mt/103126777/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1686 bytes --]

  reply	other threads:[~2023-12-12 15:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12  8:48 [edk2-devel] [PATCH] DebugLib: Allow -Wunneeded-internal-declaration with clang Mike Beaton
2023-12-12  9:26 ` Ard Biesheuvel
2023-12-12 10:33   ` Mike Beaton
2023-12-12 15:26     ` Laszlo Ersek
2023-12-12 12:57   ` Mike Beaton
2023-12-12 15:28     ` Laszlo Ersek
2023-12-12 15:33       ` Mike Beaton [this message]
2023-12-12 16:52         ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHzAAWSsbVikXcBA+sR6Q07xFSvdN3nb8HEXGE-h8YAzmEMT=A@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox