public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Mike Beaton" <mjsbeaton@gmail.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Laszlo Ersek <lersek@redhat.com>,
	devel@edk2.groups.io,  Ard Biesheuvel <ardb@google.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools/tools_def: Disable unneeded-internal-declaration warning in CLANGPDB
Date: Tue, 12 Dec 2023 10:30:00 +0000	[thread overview]
Message-ID: <CAHzAAWTDRdhNOV2+GCWvLmRC-6TNyr8QWS_rYpbo4B-iD09XKw@mail.gmail.com> (raw)
In-Reply-To: <CAHzAAWQC5ge-c0TU2gMY1M=+Crb03w6TZz6wrCHjwRYmDzCcfw@mail.gmail.com>

> I'm running some further tests to confirm that the simple version
> proposed above builds in all the Acidanthera test environments, which
> is relevant in that it should rule out at least any obvious problems
> with it building in all edk-2 environments, too. (I had already run
> quick tests for CLANGDWARF, CLANGPDB and GCC RELEASE in edk2, with no
> problems.) If there aren't any issues there, I'd prefer to submit a
> patch for this simple version instead (combined with removing the
> -Wno-unneeded-internal-declaration for clangdwarf).

Apologies for the running commentary, from these tests it appears that
the VS2019 toolchain does not like the 'simple' version of the fix. So
I'm back to proposing the version in
https://edk2.groups.io/g/devel/topic/103126777 .


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112386): https://edk2.groups.io/g/devel/message/112386
Mute This Topic: https://groups.io/mt/103087794/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2023-12-12 10:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-10 10:18 [edk2-devel] [PATCH] BaseTools/tools_def: Disable unneeded-internal-declaration warning in CLANGPDB Mike Beaton
2023-12-10 10:22 ` Mike Beaton
2023-12-10 10:25   ` Mike Beaton
2023-12-11 15:00 ` Laszlo Ersek
2023-12-11 15:18   ` Mike Beaton
2023-12-11 16:22     ` Laszlo Ersek
2023-12-11 17:26       ` Mike Beaton
2023-12-12  0:41         ` Laszlo Ersek
2023-12-12  7:17           ` Mike Beaton
2023-12-12  7:49             ` Ard Biesheuvel
2023-12-12  8:48               ` Mike Beaton
2023-12-12 10:12                 ` Mike Beaton
2023-12-12 10:30                   ` Mike Beaton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHzAAWTDRdhNOV2+GCWvLmRC-6TNyr8QWS_rYpbo4B-iD09XKw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox