From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 42A18AC0E71 for ; Tue, 12 Dec 2023 10:30:16 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YG114giAE6OjacyKIC2OIX7shwgyt7B767ygwBdUaaw=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1702377014; v=1; b=xOXsOmBXC1fdJzNd9M24Pf9Sux/9Tq0YltcDnNnVt8OWkKR5X+0a5nZqVkA4TnC/ATU0NXLR ibe4gOYH1n0GaOiGDgHemfmCgzHSkvYzTUEBPO7BS1pUsIVXJ4oxNg6+Vkz/otChJ9306yj69pV 1MxzsxXOvyOO0S1cIfjlIH+o= X-Received: by 127.0.0.2 with SMTP id E2qbYY7687511xNhfiifzRlv; Tue, 12 Dec 2023 02:30:14 -0800 X-Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.groups.io with SMTP id smtpd.web10.13643.1702377014097287323 for ; Tue, 12 Dec 2023 02:30:14 -0800 X-Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-336346769faso219465f8f.0 for ; Tue, 12 Dec 2023 02:30:13 -0800 (PST) X-Gm-Message-State: IOlgmsYgHc3wesEMTouIClhex7686176AA= X-Google-Smtp-Source: AGHT+IHF2vbuGSATGqDKDEfOYRd9vs+Fd3siITVgWIgHEeTQj/BzOt5J203h6GL/a57z1YOiqd1zEvqbcGC7GzNe9Rw= X-Received: by 2002:a5d:4c82:0:b0:32f:7c6c:aa18 with SMTP id z2-20020a5d4c82000000b0032f7c6caa18mr2426350wrs.38.1702377012387; Tue, 12 Dec 2023 02:30:12 -0800 (PST) MIME-Version: 1.0 References: <20231210101859.19198-1-mjsbeaton@gmail.com> <9b333ba1-7ce6-5be7-6482-3aadef7f1973@redhat.com> <12387048-80bf-87db-c15e-55583678863f@redhat.com> <1a51ab01-6a06-af3d-5068-86e6668fd6ec@redhat.com> In-Reply-To: From: "Mike Beaton" Date: Tue, 12 Dec 2023 10:30:00 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH] BaseTools/tools_def: Disable unneeded-internal-declaration warning in CLANGPDB To: Ard Biesheuvel Cc: Laszlo Ersek , devel@edk2.groups.io, Ard Biesheuvel Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mjsbeaton@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=xOXsOmBX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > I'm running some further tests to confirm that the simple version > proposed above builds in all the Acidanthera test environments, which > is relevant in that it should rule out at least any obvious problems > with it building in all edk-2 environments, too. (I had already run > quick tests for CLANGDWARF, CLANGPDB and GCC RELEASE in edk2, with no > problems.) If there aren't any issues there, I'd prefer to submit a > patch for this simple version instead (combined with removing the > -Wno-unneeded-internal-declaration for clangdwarf). Apologies for the running commentary, from these tests it appears that the VS2019 toolchain does not like the 'simple' version of the fix. So I'm back to proposing the version in https://edk2.groups.io/g/devel/topic/103126777 . -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112386): https://edk2.groups.io/g/devel/message/112386 Mute This Topic: https://groups.io/mt/103087794/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-