[edk2-devel] OVMF build.sh change is incorrect

[edk2-devel] OVMF build.sh change is incorrect

[Mike Beaton]

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

I believe this change
https://github.com/tianocore/edk2/commit/173a7a7daaad560cd69e1000faca1d2b91774c46
may have misunderstood the purpose of the previous code.

I used to frequently use:

`./build.sh -a X64 -b RELEASE` (or whichever arch and build target I
required) to build OVMF

and then:

`./build.sh -a X64 -b RELEASE qemu {my-qemu-flags}` to run OVMF

This now no longer works, since the second command also attempts to rebuild
OVMF every time you run it.

I believe the previous behaviour was intended and more useful.

Mike Beaton


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107749): https://edk2.groups.io/g/devel/message/107749
Mute This Topic: https://groups.io/mt/100750154/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1661 bytes --]

Re: [edk2-devel] OVMF build.sh change is incorrect

[Mike Beaton]

[-- Attachment #1: Type: text/plain, Size: 1546 bytes --]

Perhaps I can briefly clarify:

"This now no longer works" was too brief - of course the listed command
does build and start QEMU. But, to clarify, a rebuild is not what is wanted
here, both for the additional time it takes, and for the fact that it
resets (rebuilds) the NVRAM of the VM.

The advantage of using `build.sh -a ... -b ... qemu ...` to launch QEMU
without building (as was previously possible) is that it automatically
selects the correct qemu command and correct built OVMF BIOS binary to
match the related build command.

Mike

On Sun, 13 Aug 2023 at 11:13, Mike Beaton <mjsbeaton@gmail.com> wrote:

> I believe this change
> https://github.com/tianocore/edk2/commit/173a7a7daaad560cd69e1000faca1d2b91774c46
> may have misunderstood the purpose of the previous code.
>
> I used to frequently use:
>
> `./build.sh -a X64 -b RELEASE` (or whichever arch and build target I
> required) to build OVMF
>
> and then:
>
> `./build.sh -a X64 -b RELEASE qemu {my-qemu-flags}` to run OVMF
>
> This now no longer works, since the second command also attempts to
> rebuild OVMF every time you run it.
>
> I believe the previous behaviour was intended and more useful.
>
> Mike Beaton
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107750): https://edk2.groups.io/g/devel/message/107750
Mute This Topic: https://groups.io/mt/100750154/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 2641 bytes --]

Re: [edk2-devel] OVMF build.sh change is incorrect

[Mike Beaton]

This is now in https://bugzilla.tianocore.org/show_bug.cgi?id=4528 as
it should have been in the first place!

On Sun, 13 Aug 2023 at 11:34, Mike Beaton <mjsbeaton@gmail.com> wrote:
>
> Perhaps I can briefly clarify:
>
> "This now no longer works" was too brief - of course the listed command does build and start QEMU. But, to clarify, a rebuild is not what is wanted here, both for the additional time it takes, and for the fact that it resets (rebuilds) the NVRAM of the VM.
>
> The advantage of using `build.sh -a ... -b ... qemu ...` to launch QEMU without building (as was previously possible) is that it automatically selects the correct qemu command and correct built OVMF BIOS binary to match the related build command.
>
> Mike
>
> On Sun, 13 Aug 2023 at 11:13, Mike Beaton <mjsbeaton@gmail.com> wrote:
>>
>> I believe this change https://github.com/tianocore/edk2/commit/173a7a7daaad560cd69e1000faca1d2b91774c46 may have misunderstood the purpose of the previous code.
>>
>> I used to frequently use:
>>
>> `./build.sh -a X64 -b RELEASE` (or whichever arch and build target I required) to build OVMF
>>
>> and then:
>>
>> `./build.sh -a X64 -b RELEASE qemu {my-qemu-flags}` to run OVMF
>>
>> This now no longer works, since the second command also attempts to rebuild OVMF every time you run it.
>>
>> I believe the previous behaviour was intended and more useful.
>>
>> Mike Beaton
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107897): https://edk2.groups.io/g/devel/message/107897
Mute This Topic: https://groups.io/mt/100750154/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-