From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 89879740034 for ; Tue, 15 Aug 2023 01:04:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DxI0w7dBfgLh4M+YqWhVAPD6Lf6wZXow2IZJyzCQsLM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1692061445; v=1; b=txSkHLm84rLxKXJOfGnhe2jhAeKRFpmieURKkVflgFiCxHxoRnbT0/syvIHaUtfowBXPgTEp SxFSxjBnzLwgvJ4zpiuYqwQauBIyK0e+0nKv+edKdENFKVXcM1i0l1mSZukD3VzqY5aQx7T/nvw oN8rd7pDC7yM3TbibvUVTAIk= X-Received: by 127.0.0.2 with SMTP id ixAYYY7687511xRR7kud8fYr; Mon, 14 Aug 2023 18:04:05 -0700 X-Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.groups.io with SMTP id smtpd.web11.82850.1691922869684639466 for ; Sun, 13 Aug 2023 03:34:30 -0700 X-Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-31972944f30so380063f8f.0 for ; Sun, 13 Aug 2023 03:34:29 -0700 (PDT) X-Gm-Message-State: 2ePB55qKvrZ5vM9i5ZYr1Xowx7686176AA= X-Google-Smtp-Source: AGHT+IFiCM39ipiivvbU8+jWJd0FFtWzZPNMqWc3Plvj10DkQpopw8QVdIOsszkFM9MANkuKoQzoc28M0Ocx7ee/UBw= X-Received: by 2002:a05:6000:12c4:b0:317:ef76:b773 with SMTP id l4-20020a05600012c400b00317ef76b773mr5422755wrx.45.1691922867576; Sun, 13 Aug 2023 03:34:27 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Mike Beaton" Date: Sun, 13 Aug 2023 11:34:16 +0100 Message-ID: Subject: Re: [edk2-devel] OVMF build.sh change is incorrect To: devel@edk2.groups.io Cc: Rebecca Cran , Gerd Hoffmann Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mjsbeaton@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="0000000000008263490602cb7d82" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=txSkHLm8; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --0000000000008263490602cb7d82 Content-Type: text/plain; charset="UTF-8" Perhaps I can briefly clarify: "This now no longer works" was too brief - of course the listed command does build and start QEMU. But, to clarify, a rebuild is not what is wanted here, both for the additional time it takes, and for the fact that it resets (rebuilds) the NVRAM of the VM. The advantage of using `build.sh -a ... -b ... qemu ...` to launch QEMU without building (as was previously possible) is that it automatically selects the correct qemu command and correct built OVMF BIOS binary to match the related build command. Mike On Sun, 13 Aug 2023 at 11:13, Mike Beaton wrote: > I believe this change > https://github.com/tianocore/edk2/commit/173a7a7daaad560cd69e1000faca1d2b91774c46 > may have misunderstood the purpose of the previous code. > > I used to frequently use: > > `./build.sh -a X64 -b RELEASE` (or whichever arch and build target I > required) to build OVMF > > and then: > > `./build.sh -a X64 -b RELEASE qemu {my-qemu-flags}` to run OVMF > > This now no longer works, since the second command also attempts to > rebuild OVMF every time you run it. > > I believe the previous behaviour was intended and more useful. > > Mike Beaton > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107750): https://edk2.groups.io/g/devel/message/107750 Mute This Topic: https://groups.io/mt/100750154/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --0000000000008263490602cb7d82 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Perhaps I can briefly clarify:

"This now no longer works" was too brief - of course the= listed command does build and start QEMU. But, to clarify, a rebuild is no= t what is wanted here, both for the additional time it=C2=A0takes, and for = the fact that it resets (rebuilds) the NVRAM of the VM.

The advantage of using `build.sh -a ... -b ... qemu ...` to launch QE= MU without building (as was previously possible) is that it automatically s= elects the correct qemu command and correct built OVMF BIOS binary to match= the related=C2=A0build command.

Mike

On = Sun, 13 Aug 2023 at 11:13, Mike Beaton <mjsbeaton@gmail.com> wrote:
I believe this change https://github.com/tianocore/edk2/commit/173a7a7= daaad560cd69e1000faca1d2b91774c46 may have misunderstood the purpose of= the previous code.

I used to frequently use:
=
`./build.sh -a X64 -b RELEASE` (or whichever arch and build = target I required) to build OVMF

and then:

`./build.sh -a X64 -b RELEASE qemu {my-qemu-flags}` = to run OVMF

This now no longer works, since the se= cond command also attempts=C2=A0to rebuild OVMF every time you run it.

I believe the previous=C2=A0behaviour was intended and= more useful.

Mike Beaton

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#107750) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--0000000000008263490602cb7d82--