public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Marcin Wojtas" <marcin.s.wojtas@gmail.com>
To: Narinder Dhillon <ndhillon@marvell.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	 "quic_llindhol@quicinc.com" <quic_llindhol@quicinc.com>,
	 "ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
	"mw@semihalf.com" <mw@semihalf.com>
Subject: Re: [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix build
Date: Wed, 3 Jan 2024 00:39:12 +0100	[thread overview]
Message-ID: <CAHzn2R0H7+h=cpawwhTJ_DAP4Zf3ZQdCnVstNp0mSzmB7DKAfw@mail.gmail.com> (raw)
In-Reply-To: <SA1PR18MB46776252184E9C50C32FE42DD261A@SA1PR18MB4677.namprd18.prod.outlook.com>

Hi Narinder,

wt., 2 sty 2024 o 21:57 Narinder Dhillon <ndhillon@marvell.com> napisał(a):
>
> Marcin,
> I don't see this folder in code, how is it generated ?

It's simply exisitng there:
Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc in edk2-platforms,
nothing is generated.

Here's part of the patch, that introduced regression:
https://github.com/tianocore/edk2-platforms/commit/ec5de71d83f3a6327c90887456782d15565e6e36#diff-ce7de187b6e203a8e22916145bdc2a35f7c922609105c4282932f02dee7bb84fL34

Best regards,
Marcin


> Thanks
> Narinder
>
> > -----Original Message-----
> > From: Marcin Wojtas <marcin.s.wojtas@gmail.com>
> > Sent: Sunday, December 31, 2023 3:07 AM
> > To: devel@edk2.groups.io
> > Cc: quic_llindhol@quicinc.com; ardb+tianocore@kernel.org;
> > mw@semihalf.com; Narinder Dhillon <ndhillon@marvell.com>; Marcin
> > Wojtas <marcin.s.wojtas@gmail.com>
> > Subject: [EXT] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix build
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > Commit ec5de71d83 ("Silicon/Marvell: Restructure package") broke
> > Armada80x0Db build by unintentional removal of device tree component.
> > Restore it.
> >
> > Signed-off-by: Marcin Wojtas <marcin.s.wojtas@gmail.com>
> > ---
> >  Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> > b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> > index 22a0040265..501811a050 100644
> > --- a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> > +++ b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> > @@ -31,6 +31,9 @@
> >   !include MdePkg/MdeLibs.dsc.inc +[Components.common]+
> > Silicon/Marvell/Armada7k8k/DeviceTree/Armada80x0Db.inf+
> > [Components.AARCH64]
> > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db.inf --
> > 2.34.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113053): https://edk2.groups.io/g/devel/message/113053
Mute This Topic: https://groups.io/mt/103490025/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-01-03  0:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-31 11:06 [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix build Marcin Wojtas
2024-01-02 20:57 ` Narinder Dhillon
2024-01-02 23:39   ` Marcin Wojtas [this message]
2024-01-02 23:46     ` Marcin Wojtas
2024-01-02 23:49       ` Narinder Dhillon
2024-01-03 13:24 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHzn2R0H7+h=cpawwhTJ_DAP4Zf3ZQdCnVstNp0mSzmB7DKAfw@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox