From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6CF10740038 for ; Wed, 3 Jan 2024 00:59:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=eNhSEckuPTKFNffI8xoLEGEi75Kss2kOhOlFVKe7UWM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704243571; v=1; b=MwgQK+aOarVxEh0o0xG9CTxycrUJ9/86CuD9uZABBr7D3eRPgoc3ihCu1d/efGGt6MRp7kZq ChMvycbgbk0EhrfYpXudvfoY+6+zJ4WQG8mCGU2ps3G9WNBSiQJo8WrpCxPfwiJJFOT/pC7JFHG NQKPedRqzHY9rv/twRl+rJJs= X-Received: by 127.0.0.2 with SMTP id I4BTYY7687511xHWqIg2gfYo; Tue, 02 Jan 2024 16:59:31 -0800 X-Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by mx.groups.io with SMTP id smtpd.web10.2048.1704239181551990311 for ; Tue, 02 Jan 2024 15:46:21 -0800 X-Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2ccba761783so81353431fa.1 for ; Tue, 02 Jan 2024 15:46:21 -0800 (PST) X-Gm-Message-State: aDIwA7gWFwVtWaiiG8qC2RQ3x7686176AA= X-Google-Smtp-Source: AGHT+IFY8Mzy4Uo56RMBYM1b7KuzriyIr8Wq3+CIwcSbbCczf8JULtm1suQD7cYLjaH0uMAnw+Ewf55O0uKjaUadOAs= X-Received: by 2002:a2e:9858:0:b0:2cd:1062:571c with SMTP id e24-20020a2e9858000000b002cd1062571cmr650722ljj.75.1704239179488; Tue, 02 Jan 2024 15:46:19 -0800 (PST) MIME-Version: 1.0 References: <20231231110651.84552-1-marcin.s.wojtas@gmail.com> In-Reply-To: From: "Marcin Wojtas" Date: Wed, 3 Jan 2024 00:46:08 +0100 Message-ID: Subject: Re: [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix build To: Narinder Dhillon Cc: "devel@edk2.groups.io" , "quic_llindhol@quicinc.com" , "ardb+tianocore@kernel.org" , "mw@semihalf.com" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.s.wojtas@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MwgQK+aO; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io =C5=9Br., 3 sty 2024 o 00:39 Marcin Wojtas napi= sa=C5=82(a): > > Hi Narinder, > > wt., 2 sty 2024 o 21:57 Narinder Dhillon napisa=C5= =82(a): > > > > Marcin, > > I don't see this folder in code, how is it generated ? > > It's simply exisitng there: > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc in edk2-platforms, > nothing is generated. > If you meant the device tree itself, it's part of edk2-non-osi: https://github.com/tianocore/edk2-non-osi/tree/master/Silicon/Marvell/Armad= a7k8k/DeviceTree > Here's part of the patch, that introduced regression: > https://github.com/tianocore/edk2-platforms/commit/ec5de71d83f3a6327c9088= 7456782d15565e6e36#diff-ce7de187b6e203a8e22916145bdc2a35f7c922609105c428293= 2f02dee7bb84fL34 > > Best regards, > Marcin > > > > Thanks > > Narinder > > > > > -----Original Message----- > > > From: Marcin Wojtas > > > Sent: Sunday, December 31, 2023 3:07 AM > > > To: devel@edk2.groups.io > > > Cc: quic_llindhol@quicinc.com; ardb+tianocore@kernel.org; > > > mw@semihalf.com; Narinder Dhillon ; Marcin > > > Wojtas > > > Subject: [EXT] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix b= uild > > > > > > External Email > > > > > > ---------------------------------------------------------------------= - > > > Commit ec5de71d83 ("Silicon/Marvell: Restructure package") broke > > > Armada80x0Db build by unintentional removal of device tree component. > > > Restore it. > > > > > > Signed-off-by: Marcin Wojtas > > > --- > > > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > > > b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > > > index 22a0040265..501811a050 100644 > > > --- a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > > > +++ b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > > > @@ -31,6 +31,9 @@ > > > !include MdePkg/MdeLibs.dsc.inc +[Components.common]+ > > > Silicon/Marvell/Armada7k8k/DeviceTree/Armada80x0Db.inf+ > > > [Components.AARCH64] > > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db.inf -- > > > 2.34.1 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113054): https://edk2.groups.io/g/devel/message/113054 Mute This Topic: https://groups.io/mt/103490025/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-