From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id F2078941232 for ; Thu, 8 Aug 2024 05:18:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=OCdwunBuNCj3QPrKzFJ4prI92m48djO4X5FTHuOgIMM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1723094317; v=1; b=wVlwiAFDILmgXseaP8Ab7KfKkp3em/1Diulb3ag1U5A/4wdrPHVxX1cS1fofuardZgZUFAOa 3HLEYnEl2RT7H2DDFZSdS9iwe5HayB5Ye0/AeZ/tcMmYAkOKn35NVjFwL230CA4Yt0mWaTIf2tr 6mDi0iLPSS32pIwkdFJApQGJFkTIB6gdqg6BoWotdJBoPSd/TC7RQmA6Pmy030aWvCJ6e6mry3u KPoWCBEJ3DwhHek5sHYAqfSR/f+izN8Gp9YnqDue9S9Fwb7etjfy72u6Hk6X5xffA2hfghzjKJ6 d0TOpdK1lN0fMe6fRjlCMh+/r8f8Liyr8xU98smZ537LA== X-Received: by 127.0.0.2 with SMTP id CQ23YY7687511xGlLtU08xN3; Wed, 07 Aug 2024 22:18:36 -0700 X-Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by mx.groups.io with SMTP id smtpd.web10.52986.1723094310387596935 for ; Wed, 07 Aug 2024 22:18:30 -0700 X-Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2ef2d96164aso5265401fa.3 for ; Wed, 07 Aug 2024 22:18:30 -0700 (PDT) X-Gm-Message-State: Ri3kyiA0GSP8o8k3Zwd3wntjx7686176AA= X-Google-Smtp-Source: AGHT+IHm6Oqd9sRQBn1DfSVmPyPC1ba44aqpe3CaAjq4b7WsWmHumjyMg2YfQcm8py75hxtkdhdd0ZNTHzWpLcN3kPU= X-Received: by 2002:a05:651c:2126:b0:2ef:20ae:d116 with SMTP id 38308e7fff4ca-2f19dd8a116mr5482001fa.0.1723094308071; Wed, 07 Aug 2024 22:18:28 -0700 (PDT) MIME-Version: 1.0 References: <20240720195323.130619-1-ndhillon@marvell.com> In-Reply-To: <20240720195323.130619-1-ndhillon@marvell.com> From: "Marcin Wojtas" Date: Thu, 8 Aug 2024 07:18:16 +0200 Message-ID: Subject: Re: [edk2-devel] [edk2-platforms PATCH v4 0/7] Silicon/Marvell/OdysseyPkg To: ndhillon@marvell.com Cc: devel@edk2.groups.io, quic_llindhol@quicinc.com, sbalcerak@marvell.com, AbdulLateef.Attar@amd.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 07 Aug 2024 22:18:30 -0700 Resent-From: marcin.s.wojtas@gmail.com Reply-To: devel@edk2.groups.io,marcin.s.wojtas@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=wVlwiAFD; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Narinder, sob., 20 lip 2024 o 21:54 napisa=C5=82(a): > > From: Narinder Dhillon > > New Marvell Odyssey SoC > > This patchset contains only the very basic elements needed to boot to > EDK2 UiApp on Marvell Odyssey SoC > - ARM BL31 firmware component copies EDK2 image into memory, so it is > always executing from memory > - There is a SMC library to get system information from BL31 > - There are drivers to get board configuration details from a device > tree > - Emulated variable storage is used for now > > v4: > -Added SmcLib to project declaration file > -Install FDT based on PcdPublishFdt > > v3: > -Added a helper library instead of overriding ArmPlatformPkg > -Use virtual RTC instead of adding a dummy RTC > -Put shell command in separate commit > -More specific names > > v2: > -Split patch into 8 commits > > v1: > -Original patch in single commit > > Narinder Dhillon (7): > Silicon/Marvell: New Marvell Odyssey processor > Silicon/Marvell: Odyssey SmcLib > Silicon/Marvell: Odyssey watchdog driver > Silicon/Marvell: Device tree driver > Silicon/Marvell: Driver to publish device tree > Silicon/Marvell: Command to dump device tree > Silicon/Marvell: Odyssey project description files Once again, apologies for the delays. Patches LGTM, pushed as 53b7ffa930..a8344967ba After the rebase the platform needed adjustments to allow successful build: please review https://github.com/tianocore/edk2-platforms/pull/179 Best regards, Marcin > > Platform/Marvell/OdysseyPkg/OdysseyPkg.dsc | 219 ++++++++++ > Platform/Marvell/OdysseyPkg/OdysseyPkg.fdf | 304 +++++++++++++ > .../Marvell/Applications/DumpFdt/DumpFdt.c | 344 +++++++++++++++ > .../Marvell/Applications/DumpFdt/DumpFdt.inf | 52 +++ > .../Marvell/Applications/DumpFdt/DumpFdt.uni | 35 ++ > .../Drivers/Fdt/FdtClientDxe/FdtClientDxe.c | 382 ++++++++++++++++ > .../Drivers/Fdt/FdtClientDxe/FdtClientDxe.inf | 43 ++ > .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.c | 255 +++++++++++ > .../Fdt/FdtPlatformDxe/FdtPlatformDxe.inf | 49 +++ > .../Drivers/Wdt/GtiWatchdogDxe/GtiWatchdog.c | 408 ++++++++++++++++++ > .../Wdt/GtiWatchdogDxe/GtiWatchdogDxe.inf | 45 ++ > Silicon/Marvell/Library/SmcLib/SmcLib.c | 24 ++ > Silicon/Marvell/Library/SmcLib/SmcLib.inf | 29 ++ > .../Include/IndustryStandard/SmcLib.h | 28 ++ > .../Include/Protocol/FdtClient.h | 180 ++++++++ > .../MarvellSiliconPkg/MarvellSiliconPkg.dec | 21 + > .../OdysseyLib/AArch64/ArmPlatformHelper.S | 97 +++++ > .../Library/OdysseyLib/OdysseyLib.c | 79 ++++ > .../Library/OdysseyLib/OdysseyLib.inf | 60 +++ > .../Library/OdysseyLib/OdysseyLibMem.c | 142 ++++++ > Silicon/Marvell/OdysseyPkg/OdysseyPkg.dsc.inc | 399 +++++++++++++++++ > 21 files changed, 3195 insertions(+) > create mode 100644 Platform/Marvell/OdysseyPkg/OdysseyPkg.dsc > create mode 100644 Platform/Marvell/OdysseyPkg/OdysseyPkg.fdf > create mode 100644 Silicon/Marvell/Applications/DumpFdt/DumpFdt.c > create mode 100644 Silicon/Marvell/Applications/DumpFdt/DumpFdt.inf > create mode 100644 Silicon/Marvell/Applications/DumpFdt/DumpFdt.uni > create mode 100644 Silicon/Marvell/Drivers/Fdt/FdtClientDxe/FdtClientDxe= .c > create mode 100644 Silicon/Marvell/Drivers/Fdt/FdtClientDxe/FdtClientDxe= .inf > create mode 100644 Silicon/Marvell/Drivers/Fdt/FdtPlatformDxe/FdtPlatfor= m.c > create mode 100644 Silicon/Marvell/Drivers/Fdt/FdtPlatformDxe/FdtPlatfor= mDxe.inf > create mode 100644 Silicon/Marvell/Drivers/Wdt/GtiWatchdogDxe/GtiWatchdo= g.c > create mode 100644 Silicon/Marvell/Drivers/Wdt/GtiWatchdogDxe/GtiWatchdo= gDxe.inf > create mode 100644 Silicon/Marvell/Library/SmcLib/SmcLib.c > create mode 100644 Silicon/Marvell/Library/SmcLib/SmcLib.inf > create mode 100644 Silicon/Marvell/MarvellSiliconPkg/Include/IndustrySta= ndard/SmcLib.h > create mode 100644 Silicon/Marvell/MarvellSiliconPkg/Include/Protocol/Fd= tClient.h > create mode 100644 Silicon/Marvell/OdysseyPkg/Library/OdysseyLib/AArch64= /ArmPlatformHelper.S > create mode 100644 Silicon/Marvell/OdysseyPkg/Library/OdysseyLib/Odyssey= Lib.c > create mode 100644 Silicon/Marvell/OdysseyPkg/Library/OdysseyLib/Odyssey= Lib.inf > create mode 100644 Silicon/Marvell/OdysseyPkg/Library/OdysseyLib/Odyssey= LibMem.c > create mode 100644 Silicon/Marvell/OdysseyPkg/OdysseyPkg.dsc.inc > > > base-commit: d97a14d69dd5fcb13d90207d13dbeb2730beb51d > -- > 2.34.1 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120290): https://edk2.groups.io/g/devel/message/120290 Mute This Topic: https://groups.io/mt/107457422/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-