From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by mx.groups.io with SMTP id smtpd.web09.512.1572840700036793775 for ; Sun, 03 Nov 2019 20:11:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Iwmhp3ff; spf=pass (domain: gmail.com, ip: 209.85.166.193, mailfrom: prabhakar.pkin@gmail.com) Received: by mail-il1-f193.google.com with SMTP id w1so4732674ilq.11 for ; Sun, 03 Nov 2019 20:11:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=biiD+OPReHNqrheyiYIT+11hDi6YnWBDGYFEVQK7nDA=; b=Iwmhp3fftzHT5oj73kxsjSH4NRJZ0tMeLvkr/pPjWhao9KqSUcIB1bf4MvaxRCTHbO FOptkduj4WETKjq093JzBnA3XJ8YiBN8ZpIoq3lE+casFwqoAD/4pW3EpcSYy30zE2nR YR6nZqrZ4wmhN7BnOVAE1mUCoUJKxJagT/InYy/UJJpjptRnZR46wRCs5AN/SaGB87Z6 +XEzmI8iF69PiDfgz+j0k0bcRELJFX/4zRbUmAf8s3saEAeeheiwlL0whIdRm1O6N6O+ AcOvq1dBhU2O5UpBx+DcqmpwuOhdAytAJy73xAJa8WpZFmfkqLyyu4s6Q7idSBdV4P1O ZXQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=biiD+OPReHNqrheyiYIT+11hDi6YnWBDGYFEVQK7nDA=; b=LrSeVLkj1ZsSnWMlDy9uMYhyLxCsmzBxV0ncBxSa65zqhmBC03pLg7cGtGvEf1BNK8 NvTNfBOTEZcHoVyhhorI4ykCbd2ssRkAA67j8+ZUTJcqYQKBM0ye374uyWwPryYuHYDb sjxIKkp0JmS9ZwtFG4PoAt0FP09heXAzYFuaHIhvxcMyHK6qmeKMoAIsirS16DxWUWop YffG5pQXsI73lwLrZ8VLMXe17vQnGzTkwD/9nfUG59GlLmMsp9JW07ouYitjYDUaPef8 DR74NAemBIHXOzYGyAoa3ezLygU261aXG7RquLbsmWWpyut92CnYwFioRGz1l0vhP9Ch ZnQw== X-Gm-Message-State: APjAAAV0QaCji3zmkjQ9wgYI9V/Vf1eN4VvLJixdLAWa2CVDamYI2QG4 hgGz4V3PIn1GR9nYM2DsYUnZNA76SAXE/8PYeb8= X-Google-Smtp-Source: APXvYqxvMQoz0Hwq3ExDt2WWHbTbNTjgj8SfIVRa5AgHByyZPNWpCk4iUxLaP7/XN74LrPj+AM2fLfOhPQgsJdd+QEg= X-Received: by 2002:a92:84c4:: with SMTP id y65mr25664666ilk.10.1572840699359; Sun, 03 Nov 2019 20:11:39 -0800 (PST) MIME-Version: 1.0 References: <2b268378-d9be-adb5-f139-a0ca8dab4329@redhat.com> <20191031121642.GA16820@bivouac.eciton.net> <15D2D0302F8A1888.21389@groups.io> <20191031203452.GA24512@xps13.dannf> <20191101162504.GD24512@xps13.dannf> In-Reply-To: <20191101162504.GD24512@xps13.dannf> From: "Prabhakar Kushwaha" Date: Mon, 4 Nov 2019 09:41:26 +0530 Message-ID: Subject: Re: [edk2-devel] How /sys/firmware/fdt getting created To: dann frazier Cc: Leif Lindholm , Laszlo Ersek , edk2-devel-groups-io , Ard Biesheuvel , Naresh Bhat , Ganapatrao Prabhakerrao Kulkarni Content-Type: text/plain; charset="UTF-8" Dear Dann Frazier, On Fri, Nov 1, 2019 at 9:55 PM dann frazier wrote: > > On Fri, Nov 01, 2019 at 10:17:30AM +0530, Prabhakar Kushwaha wrote: > > On Fri, Nov 1, 2019 at 2:04 AM dann frazier wrote: > > > > > > On Thu, Oct 31, 2019 at 12:55:10PM -0600, dann frazier wrote: > > > > On Thu, Oct 31, 2019 at 6:16 AM Leif Lindholm wrote: > > > > > > > > > > On Thu, Oct 31, 2019 at 11:07:52AM +0100, Laszlo Ersek wrote: > > > > > > +Leif, comment at bottom > > > > > > > > > > Thanks Laszlo. +Dann, -kexec. > > > > > > > > > > > On 10/30/19 09:16, Prabhakar Kushwaha wrote: > > > > > > >> So if you want to add these properties, you should add them there. > > > > > > >> > > > > > > >> Can you explain why doing this is necessary? > > > > > > > > > > > > > > I am trying to test kexec -p (kdump feature) on CentOS-release > > > > > > > 7.7.1908 and Ubuntu-18.04 distributions. > > > > > > > > > > > > > > "kexec -p" command show error on Ubuntu. While no error on CentOS > > > > > > > > > > > > > > CentOS: > > > > > > > $ kexec -p /boot/vmlinuz-`uname -r` --initrd=/boot/initramfs-`uname > > > > > > > -r`.img --reuse-cmdline > > > > > > > $ ==> No error > > > > > > > > > > > > > > Ubuntu > > > > > > > $ kexec -p /boot/vmlinuz-`uname -r` --initrd=/boot/initrd.img-`uname > > > > > > > -r` --reuse-cmdline > > > > > > > $ kexec: elfcorehdr doesn't fit cells-size. > > > > > > > $ kexec: setup_2nd_dtb failed. > > > > > > > $ kexec: load failed. > > > > > > > $ Cannot load /boot/vmlinuz-5.4.0-rc4+ > > > > > > > > > > > > > > Note: Both CentOS and Ubuntu has Linux-5.4-rc4 tag. > > > > > > > > > > > > > > When i debugged further reason for Ubuntu error is due to > > > > > > > address-cells and size-cells as "1" > > > > > > > log from kexec tool :- > > > > > > > load_crashdump_segments: elfcorehdr 0x7f7cbfc000-0x7f7cbff7ff > > > > > > > read_1st_dtb: found name =dtb_sys /sys/firmware/fdt > > > > > > > get_cells_size: #address-cells:1 #size-cells:1 > > > > > > > > > > > > > > On CentOS both values are "2". > > > > > > > log from kexec tool :- > > > > > > > load_crashdump_segments: elfcorehdr 0xbf98bf0000-0xbf98bf33ff > > > > > > > read_1st_dtb: found nmae=dtb_sys /sys/firmware/fdt > > > > > > > get_cells_size: #address-cells:2 #size-cells:2 > > > > > > > > > > > > > > Note: Kexec tool read values from /sys/firmware/fdt. > > > > > > > > > > > > > > I am trying to figure out why 2 distributions showing different values. > > > > > > > > > > > > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=347210a5d5ce655b95315f320faa515afb723c11 > > > > > > > > > > > > Ubuntu probably ships a grub version that lacks this commit. > > > > > > > > > > Yes, it came after the 18.04 release. > > > > > Dann: given that 18.04 is LTS, would it be reasonable to cherry-pick > > > > > this grub patch? I would consider the behaviour without it to be a > > > > > bug. > > > > > > > > Leif, > > > > > > > > Likely - I'll run some tests and get back to you... > > > > > > Can you help me understand the scenario in which the above patch is > > > required? I tested an 18.04 VM w/ AAVMF (ACPI-mode), and kexec -p > > > worked fine. I also verified that 18.04 does not carry the above patch. > > > > > > > This issue is only visible when crashkernel region reserved beyond 4GB > > by kernel. > > I reproduced this issue by providing "crashkernel=2G" in bootargs. > > Prabhakar, > > Thanks. I was able to reproduce w/ crashkernel=1G@4G. > > In order to get this addressed in 18.04 we'll need a LP bug to track > it - would you mind filing one at > https://bugs.launchpad.net/ubuntu/+source/grub2 and subscribing me > (lpid dannf) to it? > I raised https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1851190 for the same. I did not find your name in "subscribing someone else" option. So I request you to subscribe to your name. Thanks --pk