From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by mx.groups.io with SMTP id smtpd.web11.5572.1586424028988696621 for ; Thu, 09 Apr 2020 02:20:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uNja3Fcn; spf=pass (domain: gmail.com, ip: 209.85.210.68, mailfrom: keysound@gmail.com) Received: by mail-ot1-f68.google.com with SMTP id v2so9812164oto.2 for ; Thu, 09 Apr 2020 02:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=LtnU7irqD3V35aualAAGg7lqTB/m1OwDXOUqob3W1iA=; b=uNja3FcngrLm3Ml8wIG+SALgrre/WG0qjQJTsQ+5TncAXdwWGqQgv4KQN9nnu9Xy5O Wt+bvhA5ZCVoi5Xo3pwgktWAgb0y+7QgAicCZvVbOJEOCdRLutvNIdFKFyAhaUgUgQnd gBiC575DHT0NEPvortQQUP+vbLk2ypOB/umAYbkcb54bH+MS+6KnEh3Rb9/fSesLmUkg AKAzDuCuOZf8hEJrJxllrauXGQ5Q31M5yM8CrX6zhsj8Juz90XfHU2pRi3kwYU13tQRN 3vU8Zc02VpUfbRFxs/UNtCO3a6UJNgyGJkEee3u+bkNje1ATOHC+PNyri0JgiBCtZ78A 7ozA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=LtnU7irqD3V35aualAAGg7lqTB/m1OwDXOUqob3W1iA=; b=KT1edKVP4SE6QzsVXOmZtJmqeFvDHMgOegG6z+rIYfTHj4C700ZE39orMNK65jZloQ TGzOh6BiDNAlb4QgdFTR6tm1iHXsOR1pd6sSo2C/Iet9SgU2N4BozbiydqAv5xHhEJ6Z 073L/ub2HT2P376cf1scznWCvad9OL2c+L94ycDbwOt5d34eMycnp8djYS/E3fAIvv3S C6i1P0RHw8V0j10puuQsfcmh9VdupxY9R+3BizYQ90IwyaxA1qAVBpVKm9N33d0I3xAf qhNgBzzGCindpczxns0SSfawLdAl19bPE8PI13bHunEO1LpPnxfhl4hM2cRQcirHBCtS hUWA== X-Gm-Message-State: AGi0PuZtcu0vnJOg/gLoFaLELA4hmcINjuum4zqgb+PVx3f+g4iZskiQ y+wl1lX77NeM0etF6Jh1CXY7v7RVBwLNNdYNa6H5Kw== X-Google-Smtp-Source: APiQypJ2d40q2zH/2AONNT3LXodyWwn1B6YjS6sL2ICdC36azoxWIUUwddq3MG5PJfonuqu3McpGaDR01LuZRzxQTzI= X-Received: by 2002:a4a:d749:: with SMTP id h9mr8935364oot.15.1586424027964; Thu, 09 Apr 2020 02:20:27 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?5by16YeR5p2+?= Date: Thu, 9 Apr 2020 17:20:16 +0800 Message-ID: Subject: Re: [edk2-devel] [PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of CreatePopUp() To: devel@edk2.groups.io, siyuan.fu@intel.com Content-Type: multipart/alternative; boundary="000000000000a6698105a2d8209c" --000000000000a6698105a2d8209c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Siyuan, Sorry for making you confused. Actually all of 4 are the same just because I thought blocked by mail list and sent many times. Please use last one. Thanks. Keysound Siyuan, Fu =E6=96=BC 2020=E5=B9=B44=E6=9C=889=E6=97= =A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=884:28=E5=AF=AB=E9=81=93=EF=BC=9A > Hi, Chang > > I received 4 patch mails with the same title "[PATCH] > NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of CreatePopUp()". D= id > you sent them by mistake or they are different patches? Please update th= e > title with [PATCH v*] prefix if the patch content is changed so we could > know which is the latest one. Thanks > > Best Regards > Siyuan > > > -----Original Message----- > > From: Keysound Chang > > Sent: 2020=E5=B9=B44=E6=9C=889=E6=97=A5 14:57 > > To: devel@edk2.groups.io > > Cc: Keysound Chang ; Wu, Jiaxin > > ; Fu, Siyuan ; Maciej Rabeda > > > > Subject: [PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead o= f > > CreatePopUp() > > > > From: Keysound Chang > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2635 > > > > According to EDK2 Driver Writer's Guide For UEFI 2.3.1, 4.2.18 Offer > > alternatives to function keys. Configuration of drivers should be > > accomplished via HII and via OS-present interfaces. > > > > Cc: Jiaxin Wu > > Cc: Siyuan Fu > > Signed-off-by: Maciej Rabeda > > --- > > .../TlsAuthConfigDxe/TlsAuthConfigDxe.inf | 1 + > > .../TlsAuthConfigDxeStrings.uni | 2 ++ > > .../TlsAuthConfigDxe/TlsAuthConfigImpl.c | 20 +++++++++++++-----= - > > .../TlsAuthConfigDxe/TlsAuthConfigImpl.h | 1 + > > 4 files changed, 18 insertions(+), 6 deletions(-) > > > > diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf > > b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf > > index 3fc924a1d4..0ada835252 100644 > > --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf > > +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf > > @@ -52,6 +52,7 @@ > > [Protocols] > > > > gEfiDevicePathProtocolGuid ## PRODUCES > > > > gEfiHiiConfigAccessProtocolGuid ## PRODUCES > > > > + gEfiHiiPopupProtocolGuid ## CONSUMES > > > > > > > > [Guids] > > > > gTlsAuthConfigGuid ## PRODUCES ## GUID > > > > diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxeStrings.uni > > b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxeStrings.uni > > index 973b8b7716..2b4a27d24e 100644 > > --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxeStrings.uni > > +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxeStrings.uni > > @@ -28,6 +28,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #string STR_TLS_AUTH_CONFIG_SAVE_AND_EXIT #language en-US > > "Commit Changes and Exit" > > > > #string STR_TLS_AUTH_CONFIG_NO_SAVE_AND_EXIT #language en-US > > "Discard Changes and Exit" > > > > > > > > +#string STR_TLS_AUTH_ENROLL_CERT_FAILURE #language en-US > > "Enroll Cert Failure!" > > > > + > > > > #string STR_CERT_TYPE_PCKS_GUID #language en-US > "GUID for > > CERT" > > > > > > > > #string STR_NULL #language en-US = "" > > > > diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c > > b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c > > index 2481d1098f..0ef96dfaf2 100644 > > --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c > > +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c > > @@ -1383,7 +1383,6 @@ TlsAuthConfigAccessCallback ( > > OUT EFI_BROWSER_ACTION_REQUEST *ActionRequest > > > > ) > > > > { > > > > - EFI_INPUT_KEY Key; > > > > EFI_STATUS Status; > > > > RETURN_STATUS RStatus; > > > > TLS_AUTH_CONFIG_PRIVATE_DATA *Private; > > > > @@ -1391,6 +1390,8 @@ TlsAuthConfigAccessCallback ( > > TLS_AUTH_CONFIG_IFR_NVDATA *IfrNvData; > > > > UINT16 LabelId; > > > > EFI_DEVICE_PATH_PROTOCOL *File; > > > > + EFI_HII_POPUP_PROTOCOL *HiiPopUp; > > > > + EFI_HII_POPUP_SELECTION PopUpSelect; > > > > > > > > Status =3D EFI_SUCCESS; > > > > File =3D NULL; > > > > @@ -1402,6 +1403,11 @@ TlsAuthConfigAccessCallback ( > > Private =3D TLS_AUTH_CONFIG_PRIVATE_FROM_THIS (This); > > > > > > > > mTlsAuthPrivateData =3D Private; > > > > + Status =3D gBS->LocateProtocol (&gEfiHiiPopupProtocolGuid, NULL, > > &HiiPopUp); > > > > + if (EFI_ERROR (Status)) { > > > > + DEBUG ((DEBUG_ERROR, "Can't find Form PopUp protocol. Exit (%r)\n= ", > > Status)); > > > > + return Status; > > > > + } > > > > > > > > // > > > > // Retrieve uncommitted data from Browser > > > > @@ -1460,11 +1466,13 @@ TlsAuthConfigAccessCallback ( > > if (EFI_ERROR (Status)) { > > > > CleanFileContext (Private); > > > > > > > > - CreatePopUp ( > > > > - EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE, > > > > - &Key, > > > > - L"ERROR: Enroll Cert Failure!", > > > > - NULL > > > > + HiiPopUp->CreatePopup( > > > > + HiiPopUp, > > > > + EfiHiiPopupStyleError, > > > > + EfiHiiPopupTypeOk, > > > > + Private->RegisteredHandle, > > > > + STRING_TOKEN(STR_TLS_AUTH_ENROLL_CERT_FAILURE), > > > > + &PopUpSelect > > > > ); > > > > } > > > > break; > > > > diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h > > b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h > > index e9af492893..68c16845b3 100644 > > --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h > > +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h > > @@ -14,6 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > #include > > > > #include > > > > +#include > > > > > > > > // > > > > // Libraries > > > > -- > > 2.23.0.windows.1 > > >=20 > > --000000000000a6698105a2d8209c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Siyuan,

Sorry for making you confuse= d. Actually all of 4 are the same just because I thought blocked by mail li= st and sent many times. Please use last one.

Thank= s.

Keysound

Siyuan, Fu <siyuan.fu@intel.com> =E6=96=BC 2020=E5=B9=B44= =E6=9C=889=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=884:28=E5=AF=AB=E9= =81=93=EF=BC=9A
Hi, Chang

I received 4 patch mails with the same title "[PATCH] NetworkPkg/TlsA= uthConfigDxe: Use HiiPopUp() instead of CreatePopUp()". Did you sent t= hem by mistake or they are different patches? Please update the title with = [PATCH v*] prefix if the patch content is changed so we could know which is= the latest one. Thanks

Best Regards
Siyuan

> -----Original Message-----
> From: Keysound Chang <keysound_chang@phoenix.com>
> Sent: 2020=E5=B9=B44=E6=9C=889=E6=97=A5 14:57
> To: devel@e= dk2.groups.io
> Cc: Keysound Chang <Keysound_Chang@phoenix.com>; Wu, Jiaxin
> <jiaxin.w= u@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Maciej Rabeda
> <maciej.rabeda@linux.intel.com>
> Subject: [PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead = of
> CreatePopUp()
>
> From: Keysound Chang <Keysound_Chang@phoenix.com>
>
> REF:https://bugzilla.tianocore.org/show_b= ug.cgi?id=3D2635
>
> According to EDK2 Driver Writer's Guide For UEFI 2.3.1, 4.2.18 Of= fer
> alternatives to function keys. Configuration of drivers should be
> accomplished via HII and via OS-present interfaces.
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> ---
>=C2=A0 .../TlsAuthConfigDxe/TlsAuthConfigDxe.inf=C2=A0 =C2=A0 =C2=A0|= =C2=A0 1 +
>=C2=A0 .../TlsAuthConfigDxeStrings.uni=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 2 ++
>=C2=A0 .../TlsAuthConfigDxe/TlsAuthConfigImpl.c=C2=A0 =C2=A0 =C2=A0 | = 20 +++++++++++++------
>=C2=A0 .../TlsAuthConfigDxe/TlsAuthConfigImpl.h=C2=A0 =C2=A0 =C2=A0 |= =C2=A0 1 +
>=C2=A0 4 files changed, 18 insertions(+), 6 deletions(-)
>
> diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
> b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
> index 3fc924a1d4..0ada835252 100644
> --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
> +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
> @@ -52,6 +52,7 @@
>=C2=A0 [Protocols]
>
>=C2=A0 =C2=A0 gEfiDevicePathProtocolGuid=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ## PRODUCES
>
>=C2=A0 =C2=A0 gEfiHiiConfigAccessProtocolGuid=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0## PRODUCES
>
> +=C2=A0 gEfiHiiPopupProtocolGuid=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ## CONSUMES
>
>
>
>=C2=A0 [Guids]
>
>=C2=A0 =C2=A0 gTlsAuthConfigGuid=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= = =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ## PRODUCES=C2= = =A0 ## GUID
>
> diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxeStrings.uni<= br> > b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxeStrings.uni
> index 973b8b7716..2b4a27d24e 100644
> --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxeStrings.uni
> +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxeStrings.uni
> @@ -28,6 +28,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>=C2=A0 #string STR_TLS_AUTH_CONFIG_SAVE_AND_EXIT=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 #language en-US
> "Commit Changes and Exit"
>
>=C2=A0 #string STR_TLS_AUTH_CONFIG_NO_SAVE_AND_EXIT=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0#language en-US
> "Discard Changes and Exit"
>
>
>
> +#string STR_TLS_AUTH_ENROLL_CERT_FAILURE=C2=A0 =C2=A0 =C2=A0 =C2=A0 = = =C2=A0 =C2=A0 =C2=A0#language en-US
> "Enroll Cert Failure!"
>
> +
>
>=C2=A0 #string STR_CERT_TYPE_PCKS_GUID=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #language en-US "GUID f= or
> CERT"
>
>
>
>=C2=A0 #string STR_NULL=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = = =C2=A0 =C2=A0#language en-US ""
>
> diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
> b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
> index 2481d1098f..0ef96dfaf2 100644
> --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
> +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
> @@ -1383,7 +1383,6 @@ TlsAuthConfigAccessCallback (
>=C2=A0 =C2=A0 OUT=C2=A0 =C2=A0 EFI_BROWSER_ACTION_REQUEST=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*ActionRequest
>
>=C2=A0 =C2=A0 )
>
>=C2=A0 {
>
> -=C2=A0 EFI_INPUT_KEY=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0Key;
>
>=C2=A0 =C2=A0 EFI_STATUS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Status;
>
>=C2=A0 =C2=A0 RETURN_STATUS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0RStatus;
>
>=C2=A0 =C2=A0 TLS_AUTH_CONFIG_PRIVATE_DATA=C2=A0 =C2=A0 *Private;
>
> @@ -1391,6 +1390,8 @@ TlsAuthConfigAccessCallback (
>=C2=A0 =C2=A0 TLS_AUTH_CONFIG_IFR_NVDATA=C2=A0 =C2=A0 =C2=A0 *IfrNvDat= a;
>
>=C2=A0 =C2=A0 UINT16=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 LabelId;
>
>=C2=A0 =C2=A0 EFI_DEVICE_PATH_PROTOCOL=C2=A0 =C2=A0 =C2=A0 =C2=A0 *Fil= e;
>
> +=C2=A0 EFI_HII_POPUP_PROTOCOL=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 *Hii= PopUp;
>
> +=C2=A0 EFI_HII_POPUP_SELECTION=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0PopU= pSelect;
>
>
>
>=C2=A0 =C2=A0 Status=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D EFI_S= UCCESS;
>
>=C2=A0 =C2=A0 File=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D = NULL;
>
> @@ -1402,6 +1403,11 @@ TlsAuthConfigAccessCallback (
>=C2=A0 =C2=A0 Private =3D TLS_AUTH_CONFIG_PRIVATE_FROM_THIS (This); >
>
>
>=C2=A0 =C2=A0 mTlsAuthPrivateData =3D Private;
>
> +=C2=A0 Status =3D gBS->LocateProtocol (&gEfiHiiPopupProtocolG= uid, NULL,
> &HiiPopUp);
>
> +=C2=A0 if (EFI_ERROR (Status)) {
>
> +=C2=A0 =C2=A0 DEBUG ((DEBUG_ERROR, "Can't find Form PopUp p= rotocol. Exit (%r)\n",
> Status));
>
> +=C2=A0 =C2=A0 return Status;
>
> +=C2=A0 }
>
>
>
>=C2=A0 =C2=A0 //
>
>=C2=A0 =C2=A0 // Retrieve uncommitted data from Browser
>
> @@ -1460,11 +1466,13 @@ TlsAuthConfigAccessCallback (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (EFI_ERROR (Status)) {
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 CleanFileContext (Private);
>
>
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 CreatePopUp (
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 EFI_LIGHTGRAY | EFI_BACKGROUND_BL= UE,
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &Key,
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 L"ERROR: Enroll Cert Failure= !",
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 NULL
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 HiiPopUp->CreatePopup(
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 HiiPopUp,
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 EfiHiiPopupStyleError,
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 EfiHiiPopupTypeOk,
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Private->RegisteredHandle,
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 STRING_TOKEN(STR_TLS_AUTH_ENROLL_= CERT_FAILURE),
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &PopUpSelect
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 );
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 break;
>
> diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h
> b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h
> index e9af492893..68c16845b3 100644
> --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h
> +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h
> @@ -14,6 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>
>
>=C2=A0 #include <Protocol/HiiConfigAccess.h>
>
>=C2=A0 #include <Protocol/SimpleFileSystem.h>
>
> +#include <Protocol/HiiPopup.h>
>
>
>
>=C2=A0 //
>
>=C2=A0 // Libraries
>
> --
> 2.23.0.windows.1




--000000000000a6698105a2d8209c--