From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id CEA58203B8C87 for ; Fri, 27 Apr 2018 06:02:48 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 474CE165D for ; Fri, 27 Apr 2018 06:02:48 -0700 (PDT) Received: from mail-oi0-f46.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 303CD3F5BD for ; Fri, 27 Apr 2018 06:02:48 -0700 (PDT) Received: by mail-oi0-f46.google.com with SMTP id a6-v6so1494279oia.2 for ; Fri, 27 Apr 2018 06:02:48 -0700 (PDT) X-Gm-Message-State: ALQs6tCrBFhMis0B5Sxersi4VGc/n68dImECoq+6Ba7FjxAbwmKkIk12 53MjDlWWrNPj+ymX9yr8qXgF9Fo8M2Wpn/kuBEc= X-Google-Smtp-Source: AB8JxZoE37ICkKGQCH7IuCEmwyX9PLP3enWwOLT5HWr4i2+yU2uXSkHW9or8Nj5YbZIHiI90M/jG8aLDPx0ea63vGEo= X-Received: by 2002:aca:b687:: with SMTP id g129-v6mr1283427oif.168.1524834167486; Fri, 27 Apr 2018 06:02:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.95.212 with HTTP; Fri, 27 Apr 2018 06:02:46 -0700 (PDT) In-Reply-To: <20180426150831.7xo74s4cpkg62zst@bivouac.eciton.net> References: <20180426130121.154724-1-sami.mujawar@arm.com> <20180426150831.7xo74s4cpkg62zst@bivouac.eciton.net> From: Thomas Abraham Date: Fri, 27 Apr 2018 18:32:46 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Leif Lindholm Cc: Sami Mujawar , nd@arm.com, Arvind Chauhan , Nariman Poushin , ard.biesheuvel@linaro.org, edk2-devel@lists.01.org, Stephanie.Hughes-Fitt@arm.com, michael.d.kinney@intel.com Subject: Re: [PATCH v1] Platforms/ARM: Enable acpiview support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 13:02:49 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 26, 2018 at 8:38 PM, Leif Lindholm w= rote: > On Thu, Apr 26, 2018 at 02:01:21PM +0100, Sami Mujawar wrote: >> Acpiview is a program that allows examination of ACPI table >> contents from the UEFI Shell. >> >> Enable acpiview support as this can help with investigations, >> especially at that stage where the tables are not enabling an >> OS to boot. > > I have no objections to this, but I would prefer to see a comment from > Arvind, Thomas or Daniil before merging. > Adding Nariman to cc as well for good measure :) > > However, please use --subject-prefix=3D"PATCH edk2-platforms=E2=80=9C in = future. > >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Sami Mujawar >> Reviewed-by: Evan Lloyd >> --- >> The patch can be seen at: >> https://github.com/samimujawar/edk2-platforms/tree/254_enable_acpiview_v= 1 >> >> Notes: >> v1: >> - Enable acpiview support in the UEFI shell for ARM platforms. [SAM= I] >> >> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM= /VExpressPkg/ArmVExpress.dsc.inc >> index 7cb47937329efa1944ec4c156e2be995a755ce6f..0badb24f030a58363e7bee22= a7cc1e03040b60aa 100644 >> --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc >> +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc >> @@ -1,5 +1,5 @@ >> # >> -# Copyright (c) 2011-2015, ARM Limited. All rights reserved. >> +# Copyright (c) 2011-2018, ARM Limited. All rights reserved. >> # >> # This program and the accompanying materials >> # are licensed and made available under the terms and conditions of th= e BSD License >> @@ -450,6 +450,7 @@ [Components.common] >> NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1C= ommandsLib.inf >> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInsta= ll1CommandsLib.inf >> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwo= rk1CommandsLib.inf >> + NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiVi= ewCommandLib.inf > > Although I would probably move this line up a few to improve sorting. > > Reviewed-by: Leif Lindholm > >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandle= ParsingLib.inf >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShell= BcfgCommandLib.inf Tested this patch with the Base RevC AEMv8 fvp and acpiview command showed a very useful dump of the ACPI tables Tested-by: Thomas Abraham