From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 411152063D743 for ; Tue, 22 May 2018 21:08:10 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BC451165D for ; Tue, 22 May 2018 21:08:10 -0700 (PDT) Received: from mail-it0-f50.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A538A3F7B7 for ; Tue, 22 May 2018 21:08:10 -0700 (PDT) Received: by mail-it0-f50.google.com with SMTP id n64-v6so2710481itb.3 for ; Tue, 22 May 2018 21:08:10 -0700 (PDT) X-Gm-Message-State: ALKqPwcA/5ZQg9iEoJCNLIFbW8k0mH8WMk8MxNWL5q29dDaTvZV8UxD3 y/myxJE+SkbAHCWA3BlMQ0+X73rs0uZ5Q5AO7UA= X-Google-Smtp-Source: AB8JxZocYJHarPYrZxfc0cJ5rpxasGi6mlY8Mxb3ALVTWtwIFChyI2hiK973MhETCtM79vnD0SaW6qRa6iEX13nHyhA= X-Received: by 2002:a24:2796:: with SMTP id g144-v6mr3727339ita.71.1527048489901; Tue, 22 May 2018 21:08:09 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:97b8:0:0:0:0:0 with HTTP; Tue, 22 May 2018 21:08:09 -0700 (PDT) In-Reply-To: References: <1526891152-18739-1-git-send-email-thomas.abraham@arm.com> <1526891152-18739-4-git-send-email-thomas.abraham@arm.com> From: Thomas Abraham Date: Wed, 23 May 2018 09:38:09 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Ard Biesheuvel Cc: Thomas Abraham , "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH edk2-platforms v4 3/9] Platform/ARM/Sgi: add initial platform dxe driver implementation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 04:08:11 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, May 21, 2018 at 2:25 PM, Ard Biesheuvel wrote: > On 21 May 2018 at 10:25, Thomas Abraham wrote: >> From: Daniil Egranov >> >> Add a initial platform dxe driver which starts of being almost >> an empty implementation. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Daniil Egranov >> Signed-off-by: Thomas Abraham >> --- >> .../ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 25 ++++++++ >> .../ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 73 ++++++++++++++++++++++ >> 2 files changed, 98 insertions(+) >> create mode 100644 Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c >> create mode 100644 Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf >> >> diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c >> new file mode 100644 >> index 0000000..eb26fde >> --- /dev/null >> +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c >> @@ -0,0 +1,25 @@ >> +/** @file >> +* >> +* Copyright (c) 2018, ARM Limited. All rights reserved. >> +* >> +* This program and the accompanying materials are licensed and made available >> +* under the terms and conditions of the BSD License which accompanies this >> +* distribution. The full text of the license may be found at >> +* http://opensource.org/licenses/bsd-license.php >> +* >> +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. >> +* >> +**/ >> + >> +#include >> + >> +EFI_STATUS >> +EFIAPI >> +ArmSgiPkgEntryPoint ( >> + IN EFI_HANDLE ImageHandle, >> + IN EFI_SYSTEM_TABLE *SystemTable >> + ) >> +{ >> + return EFI_SUCCESS; >> +} >> diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf >> new file mode 100644 >> index 0000000..dbe04c5 >> --- /dev/null >> +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf >> @@ -0,0 +1,73 @@ >> +# >> +# Copyright (c) 2018, ARM Limited. All rights reserved. >> +# >> +# This program and the accompanying materials are licensed and made available >> +# under the terms and conditions of the BSD License which accompanies this >> +# distribution. The full text of the license may be found at >> +# http://opensource.org/licenses/bsd-license.php >> +# >> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. >> +# >> + >> +[Defines] >> + INF_VERSION = 0x0001001A >> + BASE_NAME = PlatformDxe >> + FILE_GUID = 54cee352-c4cd-4d80-8524-54325c3a528e >> + MODULE_TYPE = DXE_DRIVER >> + VERSION_STRING = 1.0 >> + ENTRY_POINT = ArmSgiPkgEntryPoint >> + >> +[Sources.common] >> + PlatformDxe.c >> + >> +[Packages] >> + ArmPkg/ArmPkg.dec >> + ArmPlatformPkg/ArmPlatformPkg.dec >> + EmbeddedPkg/EmbeddedPkg.dec >> + MdePkg/MdePkg.dec >> + OvmfPkg/OvmfPkg.dec >> + Platform/ARM/SgiPkg/SgiPlatform.dec >> + >> +[LibraryClasses] >> + AcpiLib >> + BaseMemoryLib >> + DebugLib >> + DxeServicesTableLib >> + FdtLib >> + HobLib >> + IoLib >> + PcdLib >> + PrintLib >> + SerialPortLib >> + UefiBootServicesTableLib >> + UefiRuntimeServicesTableLib >> + UefiLib >> + UefiDriverEntryPoint >> + VirtioMmioDeviceLib >> + >> +[Guids] >> + gEfiEndOfDxeEventGroupGuid >> + gEfiFileInfoGuid >> + gEfiHobListGuid >> + gFdtTableGuid >> + gEfiAcpi10TableGuid >> + gEfiAcpiTableGuid >> + gSgi575AcpiTablesiFileGuid >> + >> +[Protocols] >> + gEfiBlockIoProtocolGuid >> + gEfiDevicePathFromTextProtocolGuid >> + gEfiSimpleFileSystemProtocolGuid >> + >> +[FeaturePcd] >> + gArmSgiTokenSpaceGuid.PcdVirtioSupported >> + >> +[FixedPcd] >> + gArmTokenSpaceGuid.PcdSystemMemoryBase >> + gArmTokenSpaceGuid.PcdSystemMemorySize >> + gArmTokenSpaceGuid.PcdHypFvBaseAddress >> + gArmTokenSpaceGuid.PcdHypFvSize >> + > > As I mentioned in my review of v1: I think it is fine to start with an > empty stub for a driver, but please don't limit that to the C file. > > None of these library classes, guids, protocols or PCDs are being used > in this patch. References to them should be added along with the code > that actually uses those references. Yes, I missed this part. This will be fixed in the next version. Thanks, Thomas. > >> +[Depex] >> + TRUE >> -- >> 2.7.4 >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel