From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 6F16D211DB404 for ; Mon, 11 Mar 2019 06:31:00 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57F581688 for ; Mon, 11 Mar 2019 06:31:00 -0700 (PDT) Received: from mail-it1-f170.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3EB113F703 for ; Mon, 11 Mar 2019 06:31:00 -0700 (PDT) Received: by mail-it1-f170.google.com with SMTP id l139so7238168ita.5 for ; Mon, 11 Mar 2019 06:31:00 -0700 (PDT) X-Gm-Message-State: APjAAAVbxJwwBV+sEbc2PoS8dokAVHTcsvv/FGyGWw7+LIrMYLKc95pJ 2M3Xgziy3SnIA6cdq8dyuHrkWyhIGlWx0aVYTNg= X-Google-Smtp-Source: APXvYqxgOMVhBQ1SV2WCsKvwlTa2f76S2Moxa3K8Gk5qKFulJfdohfynFAKrZRnwNdBZEBVr+NH4/OSqnZafwvnQZVs= X-Received: by 2002:a24:c8c1:: with SMTP id w184mr16122215itf.135.1552311059284; Mon, 11 Mar 2019 06:30:59 -0700 (PDT) MIME-Version: 1.0 References: <20190308153010.18486-1-ard.biesheuvel@linaro.org> In-Reply-To: <20190308153010.18486-1-ard.biesheuvel@linaro.org> From: Thomas Abraham Date: Mon, 11 Mar 2019 19:00:47 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Subject: Re: [PATCH edk2-platforms 1/2] Platform/ARM/SgiPkg: align with upstream StandaloneMmPkg changes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 13:31:01 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, Mar 8, 2019 at 9:01 PM Ard Biesheuvel wrote: > > Bring SgiPkg in line with EDK2 core changes to StandaloneMmPkg: > - add a resolution for ExtractGuidedSectionLib > - remove reference to gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable > - update the resolution of StandaloneMmDriverEntryPoint > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > index 65dd6ac82c4a..ef16bfa9a20e 100644 > --- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > @@ -43,6 +43,7 @@ > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > + ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf The build fails with the following error /home/thopan01/devel/sgi/sgi-dev/uefi/edk2/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c:37: undefined reference to `memcpy' /tmp/ccOj5Ie6.ltrans0.ltrans.o: In function `ExtractGuidedSectionLibConstructor': /home/thopan01/devel/sgi/sgi-dev/uefi/edk2/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c:233: undefined reference to `memcpy' collect2: error: ld returned 1 exit status I will check further why the build fails here. Thanks, Thomas. > FvLib|StandaloneMmPkg/Library/FvLib/FvLib.inf > HobLib|StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf > IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > @@ -56,7 +57,7 @@ > # > # Entry point > # > - StandaloneMmDriverEntryPoint|StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf > + StandaloneMmDriverEntryPoint|MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf > > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > StandaloneMmMmuLib|ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf > @@ -81,9 +82,6 @@ > # Pcd Section - list of all EDK II PCD Entries defined by this Platform > # > ################################################################################ > -[PcdsFeatureFlag] > - gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable|TRUE > - > [PcdsFixedAtBuild] > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x800000CF > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xff > @@ -93,6 +91,8 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x7FF70000 > gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200 > > + gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x2 > + > ################################################################################################### > # > # Components Section - list of the modules and components that will be processed by compilation > -- > 2.20.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel