Re: [PATCH edk2-platforms v2 6/6] Platform/ARM/Sgi: add initial support for ARM SGI platform

[Thomas Abraham <thomas.abraham@arm.com>]

Hi Ard,

On Mon, Apr 16, 2018 at 4:14 PM, Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
> On 12 April 2018 at 20:47, Thomas Abraham <thomas.abraham@arm.com> wrote:
>> From: Vishwanatha HG <vishwanatha.hg@arm.com>
>>
>> Add the initial support for ARM's System Guidance for Infrastructure
>> (SGI) platforms. SGI-575 is the supported platform in this initial
>> implementation and can be extented to include support for upcoming
>> SGI platforms as well.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by:  Vishwanatha HG <vishwanatha.hg@arm.com>
>> Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
>> ---
>>  Platform/ARM/SgiPkg/SgiPlatform.dec |  36 ++++
>>  Platform/ARM/SgiPkg/SgiPlatform.dsc | 243 +++++++++++++++++++++++++++
>>  Platform/ARM/SgiPkg/SgiPlatform.fdf | 320 ++++++++++++++++++++++++++++++++++++
>>  3 files changed, 599 insertions(+)
>>  create mode 100644 Platform/ARM/SgiPkg/SgiPlatform.dec
>>  create mode 100644 Platform/ARM/SgiPkg/SgiPlatform.dsc
>>  create mode 100644 Platform/ARM/SgiPkg/SgiPlatform.fdf
>>

<snip>

>> +################################################################################
>> +#
>> +# Components Section - list of all EDK II Modules needed by this Platform
>> +#
>> +################################################################################
>> +[Components.common]
>> +  #
>> +  # PEI Phase modules
>> +  #
>> +  ArmPlatformPkg/PrePi/PeiMPCore.inf {
>
> Apologies for missing this before: please use PrePeiCore not PrePi.
> PrePi is a misguided optimization that skips the entire PEI phase,
> making ARM platforms deviate from other UEFI systems in ways that make
> it more difficult later on to reuse generic modules for things like
> capsule update etc.

Thank you for your comments. All the changes you have suggested has
been included in the v3 version of this patchset. As you have
suggested, the use of PrePi has been dropped and switched to using
PrePeiCore. Apologies for taking a lot of time to revert back on your
comments.

Thanks,
Thomas.

<snip>