From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 877492096AECB for ; Wed, 9 May 2018 01:56:27 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2E5EF15BF for ; Wed, 9 May 2018 01:56:27 -0700 (PDT) Received: from mail-it0-f48.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 172433F5BA for ; Wed, 9 May 2018 01:56:27 -0700 (PDT) Received: by mail-it0-f48.google.com with SMTP id z6-v6so19473707iti.4 for ; Wed, 09 May 2018 01:56:27 -0700 (PDT) X-Gm-Message-State: ALKqPwd/QFvsiEtMiOT5IhaoHTJUG9KJGULwFRD+cA8pakBEOG5nEvuB NNRpWW6bv9al8DD22SR8kE/MUJRTRqBSTrMAzLs= X-Google-Smtp-Source: AB8JxZovuU5LHPp9lfW4j2YaXa2kIXzfcathW8qT5w/GiwsLhh5WhdXAc8XnJyZDf7OS1EyEeSqCb+tg6TKxSsjSgl8= X-Received: by 2002:a24:a648:: with SMTP id r8-v6mr8712549iti.147.1525856186313; Wed, 09 May 2018 01:56:26 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:97b8:0:0:0:0:0 with HTTP; Wed, 9 May 2018 01:56:25 -0700 (PDT) In-Reply-To: References: <1523558863-5427-1-git-send-email-thomas.abraham@arm.com> <1523558863-5427-7-git-send-email-thomas.abraham@arm.com> From: Thomas Abraham Date: Wed, 9 May 2018 14:26:25 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Ard Biesheuvel Cc: Thomas Abraham , "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH edk2-platforms v2 6/6] Platform/ARM/Sgi: add initial support for ARM SGI platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 08:56:27 -0000 Content-Type: text/plain; charset="UTF-8" Hi Ard, On Mon, Apr 16, 2018 at 4:14 PM, Ard Biesheuvel wrote: > On 12 April 2018 at 20:47, Thomas Abraham wrote: >> From: Vishwanatha HG >> >> Add the initial support for ARM's System Guidance for Infrastructure >> (SGI) platforms. SGI-575 is the supported platform in this initial >> implementation and can be extented to include support for upcoming >> SGI platforms as well. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Vishwanatha HG >> Signed-off-by: Thomas Abraham >> --- >> Platform/ARM/SgiPkg/SgiPlatform.dec | 36 ++++ >> Platform/ARM/SgiPkg/SgiPlatform.dsc | 243 +++++++++++++++++++++++++++ >> Platform/ARM/SgiPkg/SgiPlatform.fdf | 320 ++++++++++++++++++++++++++++++++++++ >> 3 files changed, 599 insertions(+) >> create mode 100644 Platform/ARM/SgiPkg/SgiPlatform.dec >> create mode 100644 Platform/ARM/SgiPkg/SgiPlatform.dsc >> create mode 100644 Platform/ARM/SgiPkg/SgiPlatform.fdf >> >> +################################################################################ >> +# >> +# Components Section - list of all EDK II Modules needed by this Platform >> +# >> +################################################################################ >> +[Components.common] >> + # >> + # PEI Phase modules >> + # >> + ArmPlatformPkg/PrePi/PeiMPCore.inf { > > Apologies for missing this before: please use PrePeiCore not PrePi. > PrePi is a misguided optimization that skips the entire PEI phase, > making ARM platforms deviate from other UEFI systems in ways that make > it more difficult later on to reuse generic modules for things like > capsule update etc. Thank you for your comments. All the changes you have suggested has been included in the v3 version of this patchset. As you have suggested, the use of PrePi has been dropped and switched to using PrePeiCore. Apologies for taking a lot of time to revert back on your comments. Thanks, Thomas.