From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 937D321189FA4 for ; Thu, 1 Nov 2018 05:50:57 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B28F3A78 for ; Thu, 1 Nov 2018 05:50:56 -0700 (PDT) Received: from mail-it1-f180.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A8A23F6A8 for ; Thu, 1 Nov 2018 05:50:56 -0700 (PDT) Received: by mail-it1-f180.google.com with SMTP id p64-v6so1839338itp.0 for ; Thu, 01 Nov 2018 05:50:56 -0700 (PDT) X-Gm-Message-State: AGRZ1gIegeR2rf3SutSGEA66fjrT3BzT+XLGUoaLn/nuLbMEXVbRbPF1 N123dXsTKZcc4MaoMKLtDp2Pm1CA/FBNtALFKVo= X-Google-Smtp-Source: AJdET5fO2eWW5ysngzk90gb0Qe7dCYktmYTCNKFUeDMdKUawjvCjAzE3xkhxE073d4NjvFZu/st8V8Z60IPLxrWRsp0= X-Received: by 2002:a24:4a8f:: with SMTP id k137-v6mr5235931itb.136.1541076655971; Thu, 01 Nov 2018 05:50:55 -0700 (PDT) MIME-Version: 1.0 References: <20181101114758.ij3v72kqj4otdqpa@bivouac.eciton.net> In-Reply-To: <20181101114758.ij3v72kqj4otdqpa@bivouac.eciton.net> From: Thomas Abraham Date: Thu, 1 Nov 2018 18:20:44 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Leif Lindholm Cc: andrew@fubar.geek.nz, edk2-devel@lists.01.org, Nariman Poushin Subject: Re: [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 X-List-Received-Date: Thu, 01 Nov 2018 12:50:57 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, Nov 1, 2018 at 5:18 PM Leif Lindholm wrote: > > Thanks Andrew, > > Thomas, Nariman - can I have a review from one of you guys before I > push? > > Regards, > > Leif > > On Thu, Nov 01, 2018 at 11:35:42AM +0000, Andrew Turner wrote: > > The UEFI build fails for ArmVExpress-FVP-AArch64 when using the > > "-D DT_SUPPORT" buildoption. > > > > ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package > > and fails with: > > .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33: > > fatal error: VExpressMotherBoard.h: No such file or directory > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Andrew Turner > > --- > > .../ArmVExpressDtPlatformDtbLoaderLib.inf | 1 + > > 1 file changed, 1 insertion(+) Tested with -D DT_SUPPORT as additional build option and the below change does fix the build issue reported in this commit message. Tested-by: Thomas Abraham > > > > diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > index 5012101..eb821c7 100644 > > --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > @@ -26,6 +26,7 @@ > > [Packages] > > ArmPkg/ArmPkg.dec > > MdePkg/MdePkg.dec > > ++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec > > EmbeddedPkg/EmbeddedPkg.dec > > > > [LibraryClasses] > > -- > > 2.7.4 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel