From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 59D5220336AC9 for ; Fri, 6 Jul 2018 02:24:16 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C8EA1650 for ; Fri, 6 Jul 2018 02:24:16 -0700 (PDT) Received: from mail-it0-f46.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E987B3F6CA for ; Fri, 6 Jul 2018 02:24:15 -0700 (PDT) Received: by mail-it0-f46.google.com with SMTP id v71-v6so5692623itb.3 for ; Fri, 06 Jul 2018 02:24:15 -0700 (PDT) X-Gm-Message-State: APt69E0RbldkR6azu/YniikbnRfDkC3SVZhdeqSo8AmfO1AktiG9Wope FJZjiQSBvdyHaPZ0UAp6a41kMlRnrevVLo8a8hg= X-Google-Smtp-Source: AAOMgpdTmSXkV/wtW/L/faVXRuf7TYayfgXjZnfMKGvWR7+KQpOz+1kjGVcm2fyQ+9M7/GkjDHHAmMIpnPEvRkfNADU= X-Received: by 2002:a24:3ac3:: with SMTP id m186-v6mr7476099itm.106.1530869055267; Fri, 06 Jul 2018 02:24:15 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:c04e:0:0:0:0:0 with HTTP; Fri, 6 Jul 2018 02:24:14 -0700 (PDT) In-Reply-To: <20180704130440.32480-1-Alexei.Fedorov@arm.com> References: <20180704130440.32480-1-Alexei.Fedorov@arm.com> From: Thomas Abraham Date: Fri, 6 Jul 2018 14:54:14 +0530 X-Gmail-Original-Message-ID: Message-ID: To: AlexeiFedorov Cc: edk2-devel@lists.01.org, nd@arm.com, Stephanie.Hughes-Fitt@arm.com, Arvind Chauhan Subject: Re: [PATCH] Platform/ARM: Correct LevelID in PLPI packages of DSDT X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 09:24:16 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, Jul 4, 2018 at 6:34 PM, AlexeiFedorov wrote: > From: Alexei Fedorov > > Juno's DSDT contains 2 PLPI packages in Clusters #0 and #1 and > _OSC method reports support for platform coordinated mode only. > According to the description of LevelID field in > ACPI 6.2 Errata A Specification #8.4.4.3, > "In a platform that only supports platform coordinated mode, > this field must be 0." > > This patch fixes the above issue by changing value of LevelID > fields from 1 to 0. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alexei Fedorov > --- > All the changes can be reviewed at: > https://github.com/AlexeiFedorov/edk2-platforms/tree/282_correct_levelid_v1 > > Notes: > v1: > - Change LevelID Value of PLPI package from 1 to 0. > > Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl > index 07e32bae21f891461fde0183028e4c0f817e45a7..702b057757457fee40ddfc10e91d38c5dd7ca0b8 100644 > --- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl > +++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl > @@ -1,7 +1,7 @@ > /** @file > Differentiated System Description Table Fields (DSDT) > > - Copyright (c) 2014-2015, ARM Ltd. All rights reserved.
> + Copyright (c) 2014-2018, ARM Ltd. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD License > which accompanies this distribution. The full text of the license may be found at > @@ -65,7 +65,7 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O > }) > Name(PLPI, Package() { > 0, // Version > - 1, // Level Index > + 0, // Level Index > 2, // Count > Package() { // WFI for CPU > 1, // Min residency (uS) > @@ -157,7 +157,7 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O > }) > Name(PLPI, Package() { > 0, // Version > - 1, // Level Index > + 0, // Level Index > 2, // Count > Package() { // WFI for CPU > 1, // Min residency (uS) > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' Reviewed-by: Thomas Abraham