From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.15378.1601647952409020805 for ; Fri, 02 Oct 2020 07:12:32 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: thomas.abraham@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 87922106F for ; Fri, 2 Oct 2020 07:12:31 -0700 (PDT) Received: from mail-il1-f182.google.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 718D83FA32 for ; Fri, 2 Oct 2020 07:12:31 -0700 (PDT) Received: by mail-il1-f182.google.com with SMTP id q5so1373719ilj.1 for ; Fri, 02 Oct 2020 07:12:31 -0700 (PDT) X-Gm-Message-State: AOAM533evVfMp+RlyWTv6k9+5flmnuNXnl3KPyTftASdjcbOG24rtCHF F53NoWyXctpfjK8lDVKy7VhupakIOTsKKFmOQpg= X-Google-Smtp-Source: ABdhPJz8ib2SsS0kQ9S7qzSTG1b9926cKqEY+IOSzRZqAqqxU3fxXaS+1h8DD/YS0mBN79D+xPGdxRU5nfUKPVlIHzc= X-Received: by 2002:a92:bb57:: with SMTP id w84mr1973041ili.41.1601647942999; Fri, 02 Oct 2020 07:12:22 -0700 (PDT) MIME-Version: 1.0 References: <20201001231528.100364-1-sami.mujawar@arm.com> <53b238d1-41be-e3c6-12a3-e054536d815a@arm.com> In-Reply-To: <53b238d1-41be-e3c6-12a3-e054536d815a@arm.com> From: "Thomas Abraham" Date: Fri, 2 Oct 2020 19:42:10 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: TimerLib based RngLib for CryptoPkg To: devel@edk2.groups.io, Ard Biesheuvel Cc: Sami Mujawar , Leif Lindholm , Matteo.Carlini@arm.com, Ben.Adderson@arm.com, nd@arm.com Content-Type: text/plain; charset="UTF-8" On Fri, Oct 2, 2020 at 1:49 PM Ard Biesheuvel wrote: > > On 10/2/20 1:15 AM, Sami Mujawar wrote: > > The commit at "b5701a4c7a0f CryptoPkg: OpensslLib: Use RngLib to > > generate entropy in rand_pool" updated CryptoPkg\OpenSSL to no > > longer depend on TimerLib and instead use RngLib. This is done so > > that platforms can choose the desired entropy source. However, this > > change breaks the builds for platforms under Platform/ARM. > > > > To fix this, update ArmVExpress.dsc.inc to use a TimerLib based > > implementation of RngLib. > > > > Note: The TimerLib based implementation of RngLib replicates past > > behavior when used with OpenSSL. However, this should not be used > > in production as a real source of entropy. > > > > Signed-off-by: Sami Mujawar > > Reviewed-by: Ard Biesheuvel Tested for SGI/RD platforms and it resolves the build issue. Tested-by: Thomas Abraham > > > > --- > > > > The changes can be seen at: > > https://github.com/samimujawar/edk2-platforms/tree/1441_fix_platform_arm_build_break_v1 > > > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > index bde3437b56d71be9259b18bc0501976695639c62..6f4621393a9713705e360a1c9ad019a6ad93a0a4 100644 > > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > @@ -1,5 +1,5 @@ > > # > > -# Copyright (c) 2011-2019, ARM Limited. All rights reserved. > > +# Copyright (c) 2011-2020, Arm Limited. All rights reserved. > > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > # > > @@ -138,6 +138,7 @@ [LibraryClasses.common] > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > > > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > > > > > > >