From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 4296B2117B552 for ; Wed, 21 Nov 2018 05:48:39 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 108BE1DC8 for ; Wed, 21 Nov 2018 05:48:39 -0800 (PST) Received: from mail-io1-f51.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EBAB73F575 for ; Wed, 21 Nov 2018 05:48:38 -0800 (PST) Received: by mail-io1-f51.google.com with SMTP id s22so4065393ioc.8 for ; Wed, 21 Nov 2018 05:48:38 -0800 (PST) X-Gm-Message-State: AA+aEWYEOAXybx86GV6xGHFIVw/TDFHnYD6oY9aKJ3AQ+XKNOoVicN8Q CzsW/9Wjcz6HpnaLxdFOo6+oWnczwru2ie2RWMk= X-Google-Smtp-Source: AFSGD/VCvDe9aeEaLWmy7CRHJoYwsnPxuyDnPTma3odLX4RWZuT62PFmoy2k1YbAUtIvehDAGuaW3FulvdzB+HRwygs= X-Received: by 2002:a6b:1681:: with SMTP id 123-v6mr4559148iow.209.1542808118220; Wed, 21 Nov 2018 05:48:38 -0800 (PST) MIME-Version: 1.0 References: <20181121120145.3148-1-ard.biesheuvel@linaro.org> In-Reply-To: <20181121120145.3148-1-ard.biesheuvel@linaro.org> From: Thomas Abraham Date: Wed, 21 Nov 2018 19:18:26 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, Nariman Poushin Subject: Re: [PATCH edk2-platforms 0/3] drop GUIDs from NOR flash bank descriptors X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 13:48:39 -0000 Content-Type: text/plain; charset="UTF-8" Hi Ard, On Wed, Nov 21, 2018 at 5:31 PM Ard Biesheuvel wrote: > > Align edk2-platform with upcoming changes to EDK2 to get rid of per-bank > NOR flash GUIDs. > > Ard Biesheuvel (3): > Platform/ARM: replace hardcoded VenHW() device paths referring to NOR > flash > Silicon/SynQuacer: drop per-bank NOR flash GUIDs > Platform/ARM: drop per-bank NOR flash GUIDs > > Platform/ARM/JunoPkg/ArmJuno.dec | 2 +- > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +- > .../JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c | 2 -- > .../ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.c | 2 -- > Platform/ARM/SgiPkg/SgiPlatform.dsc | 2 +- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 2 +- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 2 +- > .../NorFlashArmVExpressLib/NorFlashArmVExpress.c | 4 ---- > .../SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c | 14 +++++++------- > .../SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h | 3 +++ > .../NorFlashSynQuacerLib/NorFlashSynQuacer.c | 6 ------ > 11 files changed, 15 insertions(+), 26 deletions(-) Tested this patch series and "[PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB" patch series on the Juno board. With these patches applied, the boot fails on Juno board with the following messages. I have not yet tried to debug the issue but wanted to let you know this. [...] Loading driver at 0x000F830C000 EntryPoint=0x000F831B2AC IScsiDxe.efi add-symbol-file /home/thopan01/devel/juno/uefi/uefi/edk2/Build/ArmJuno/DEBUG_GCC5/AARCH64/MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe/DEBUG/Udp4Dxe.dll 0xF8300000 Loading driver at 0x000F82FF000 EntryPoint=0x000F8306DF0 Udp4Dxe.efi add-symbol-file /home/thopan01/devel/juno/uefi/uefi/edk2/Build/ArmJuno/DEBUG_GCC5/AARCH64/Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe/DEBUG/FdtPlatformDxe.dll 0xF82EE000 Loading driver at 0x000F82ED000 EntryPoint=0x000F82F76EC FdtPlatformDxe.efi Found image: fip in block 5. Found image: norkern in block 20. Found image: ramdisk.img in block 116. Found image: hdlcdclk in block 151. Found image: selftest in block 152. Found image: board.dtb in block 156. Found image: scp_bl1 in block 249. Found image: bl1 in block 251. Found image: startup.nsh in block 252. ASSERT [BootMonFs] /home/thopan01/devel/juno/uefi/uefi/edk2/MdePkg/Library/BaseLib/String.c(173): ((UINTN) String & 0x00000001) == 0 Thanks, Thomas. > > -- > 2.17.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel