From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 36F1421193789 for ; Wed, 21 Nov 2018 08:37:58 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9CED7361E for ; Wed, 21 Nov 2018 08:37:58 -0800 (PST) Received: from mail-it1-f169.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 849F83F7F4 for ; Wed, 21 Nov 2018 08:37:58 -0800 (PST) Received: by mail-it1-f169.google.com with SMTP id b5so9778246iti.2 for ; Wed, 21 Nov 2018 08:37:58 -0800 (PST) X-Gm-Message-State: AGRZ1gKNd2aGKyIHv1fdm3m3SYlEd7tBbl+Su2hq/ZZ/wthxQwo+rNtf QytQw+lp7iIj+PZeuylZ5rfKAcKqD+9qvwc3N7E= X-Google-Smtp-Source: AJdET5cykp2xXIh74DLamwsmJVsSEMr36biiUksqDZ9eKRztZbwGGfndxp6yRPvFaq+Sd3L2W1J9qT9PpzyRu/5GS7E= X-Received: by 2002:a24:28d2:: with SMTP id h201mr6348846ith.136.1542818277777; Wed, 21 Nov 2018 08:37:57 -0800 (PST) MIME-Version: 1.0 References: <20181121154723.12514-1-vijayenthiran.subramaniam@arm.com> In-Reply-To: <20181121154723.12514-1-vijayenthiran.subramaniam@arm.com> From: Thomas Abraham Date: Wed, 21 Nov 2018 22:07:45 +0530 X-Gmail-Original-Message-ID: Message-ID: To: vijayenthiran.subramaniam@arm.com Cc: edk2-devel@lists.01.org, Ard Biesheuvel , Leif Lindholm Subject: Re: [PATCH] Platform/ARM/Juno: increase max variable size to 8KB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 16:37:59 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, Nov 21, 2018 at 9:26 PM Vijayenthiran Subramaniam wrote: > > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg > package. This driver requires the platform to support a maximum variable > size of atleast 4KB. > > So increase the maximum supported variable size to 8KB on the Juno > platform. Without this, the iSCSI driver fails to load. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Thomas Abraham > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vijayenthiran Subramaniam > --- > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 ++ > 1 file changed, 2 insertions(+) Tested-by: Thomas Abraham > > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc > index ac3d63b..ac85dc0 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc > @@ -103,6 +103,8 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x0BFE0000 > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x00010000 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > + > # System Memory (2GB - 16MB of Trusted DRAM at the top of the 32bit address space) > gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000 > > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel