From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.30992.1585500121658704345 for ; Sun, 29 Mar 2020 09:42:01 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: thomas.abraham@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 32F33101E for ; Sun, 29 Mar 2020 09:42:01 -0700 (PDT) Received: from mail-il1-f182.google.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1AAED3F7D8 for ; Sun, 29 Mar 2020 09:42:01 -0700 (PDT) Received: by mail-il1-f182.google.com with SMTP id p13so13467474ilp.3 for ; Sun, 29 Mar 2020 09:42:01 -0700 (PDT) X-Gm-Message-State: ANhLgQ30K+Nm8+ohZ3vKs4HzhK1mNrVJD3bP8hDOlTe6w/OatsnSt7DD CeKbVa4h3LMWzfo5BSkXXhWuMhB7hf7NosG2P0o= X-Google-Smtp-Source: ADFU+vvGRCvvK/20QJqqBzlLBJCd8VZRK6Zucg6Y0frPGpnnHaPD1/3U85RVpDcYE8X2phEcgW15ZcA5SeVhaHwD8lo= X-Received: by 2002:a92:91c3:: with SMTP id e64mr1222162ill.68.1585500116592; Sun, 29 Mar 2020 09:41:56 -0700 (PDT) MIME-Version: 1.0 References: <20200325105252.13905-1-aditya.angadi@arm.com> In-Reply-To: <20200325105252.13905-1-aditya.angadi@arm.com> From: "Thomas Abraham" Date: Sun, 29 Mar 2020 22:11:45 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-platforms][PATCH v3 0/8] Add platform support for RD-Daniel To: devel@edk2.groups.io, aditya.angadi@arm.com Content-Type: text/plain; charset="UTF-8" Hi Aditya, On Wed, Mar 25, 2020 at 4:23 PM Aditya Angadi wrote: > > This patch series adds support for Arm's RD-Daniel platform. There are two > configurations of this platform being added in this series - Config-M and > Config-XLR. RD-Daniel is the next Arm's reference design subsystem. > > The first four patches consolidate the code in SgiPkg in preparation for > adding support for the RD-Daniel platform. The next four patches add support > for the RD-Daniel platforms. > > Aditya Angadi (7): > Platform/ARM/SgiPkg: move the GIC related ACPI helper macros > Platform/ARM/SgiPkg: move common platform description to SSDT > Platform/ARM/SgiPkg: remove PcdCoreCount and PcdClusterCount > Platform/ARM/SgiPkg: add ACPI tables for Rd-Daniel Config-M > Platform/ARM/Sgi: add initial support for RD-Daniel Config-M platform > Platform/ARM/SgiPkg: add ACPI tables for RD-Daniel Config-XLR > Platform/ARM/Sgi: add initial support for RD-Daniel Config-XLR > platform > > Thomas Abraham (1): > Maintainers.txt: Update Arm platform reviewers list > > Vijayenthiran Subramaniam (1): > Platform/ARM/SgiPkg: create individual Platform Description File Few comments on this patch series. - The patch subject of all the patches seem to be have been truncated. - Copyright message in patches that add new files is incorrect. - Patches 2/9 and 4/9 are missing on the list. Could you check about these and post the next version. Thanks, Thomas. > > Maintainers.txt | 1 + > .../SgiPkg/AcpiTables/RdDanielCfgM/Dsdt.asl | 118 ++++++++++++++ > .../SgiPkg/AcpiTables/RdDanielCfgM/Madt.aslc | 134 ++++++++++++++++ > ...iTables.inf => RdDanielCfgMAcpiTables.inf} | 20 ++- > .../SgiPkg/AcpiTables/RdDanielCfgXlr/Dsdt.asl | 125 +++++++++++++++ > .../AcpiTables/RdDanielCfgXlr/Madt.aslc | 150 ++++++++++++++++++ > ...ables.inf => RdDanielCfgXlrAcpiTables.inf} | 20 ++- > .../ARM/SgiPkg/AcpiTables/RdE1Edge/Dsdt.asl | 70 +------- > .../ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc | 73 +-------- > .../SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf | 5 +- > .../ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl | 69 +------- > .../ARM/SgiPkg/AcpiTables/RdN1Edge/Madt.aslc | 75 +-------- > .../SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf | 5 +- > .../SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 69 +------- > .../AcpiTables/RdN1EdgeX2AcpiTables.inf | 3 +- > .../ARM/SgiPkg/AcpiTables/Sgi575/Madt.aslc | 9 +- > .../SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 4 +- > .../{RdN1Edge/Dsdt.asl => SsdtRos.asl} | 67 ++------ > .../SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 10 ++ > .../Drivers/PlatformDxe/PlatformDxe.inf | 2 + > Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 70 +++++++- > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 12 +- > .../Library/PlatformLib/PlatformLib.inf | 6 +- > .../Library/PlatformLib/PlatformLibMem.c | 8 +- > Platform/ARM/SgiPkg/RdDaniel.dsc | 37 +++++ > Platform/ARM/SgiPkg/RdE1Edge.dsc | 37 +++++ > Platform/ARM/SgiPkg/RdN1Edge.dsc | 37 +++++ > Platform/ARM/SgiPkg/Sgi575.dsc | 37 +++++ > Platform/ARM/SgiPkg/SgiPlatform.dec | 7 +- > Platform/ARM/SgiPkg/SgiPlatform.dsc | 31 +--- > Platform/ARM/SgiPkg/SgiPlatform.fdf | 2 + > 31 files changed, 848 insertions(+), 465 deletions(-) > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgM/Dsdt.asl > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgM/Madt.aslc > copy Platform/ARM/SgiPkg/AcpiTables/{RdN1EdgeX2AcpiTables.inf => RdDanielCfgMAcpiTables.inf} (67%) > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgXlr/Dsdt.asl > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgXlr/Madt.aslc > copy Platform/ARM/SgiPkg/AcpiTables/{RdN1EdgeX2AcpiTables.inf => RdDanielCfgXlrAcpiTables.inf} (67%) > copy Platform/ARM/SgiPkg/AcpiTables/{RdN1Edge/Dsdt.asl => SsdtRos.asl} (57%) > create mode 100644 Platform/ARM/SgiPkg/RdDaniel.dsc > create mode 100644 Platform/ARM/SgiPkg/RdE1Edge.dsc > create mode 100644 Platform/ARM/SgiPkg/RdN1Edge.dsc > create mode 100644 Platform/ARM/SgiPkg/Sgi575.dsc > > -- > 2.17.1 > > > ------------ > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#56274): https://edk2.groups.io/g/devel/message/56274 > Mute This Topic: https://groups.io/mt/72538017/1785013 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ta.omasab@gmail.com] > ------------ >