From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.1977.1595356318857491226 for ; Tue, 21 Jul 2020 11:31:59 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: thomas.abraham@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CEF371045 for ; Tue, 21 Jul 2020 11:31:57 -0700 (PDT) Received: from mail-il1-f175.google.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B8B433F66F for ; Tue, 21 Jul 2020 11:31:57 -0700 (PDT) Received: by mail-il1-f175.google.com with SMTP id r12so17295919ilh.4 for ; Tue, 21 Jul 2020 11:31:57 -0700 (PDT) X-Gm-Message-State: AOAM533nlWFtQdC5qauz4hdVr2IZjG8SCMRM04FB1wZHcZsB5eNrEkfD bwPEZNaWbP13RktKQCdL3goRC+gyKZ4J/rK3fb4= X-Google-Smtp-Source: ABdhPJz8JvF1sn0HSMg5kVQN/ghjHOJ4y4fIjkV9EFB0r9gHbh8xQEDOB1wQROCEAXoXuuprq5w9tbIIJpI4afOMFJs= X-Received: by 2002:a92:6a02:: with SMTP id f2mr26759109ilc.68.1595356313269; Tue, 21 Jul 2020 11:31:53 -0700 (PDT) MIME-Version: 1.0 References: <1595148523-22302-1-git-send-email-pranav.madhu@arm.com> In-Reply-To: <1595148523-22302-1-git-send-email-pranav.madhu@arm.com> From: "Thomas Abraham" Date: Wed, 22 Jul 2020 00:01:42 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 0/5] Platform: Add initial support for N1SDP board To: devel@edk2.groups.io, pranav.madhu@arm.com Cc: Ard Biesheuvel , Leif Lindholm Content-Type: text/plain; charset="UTF-8" Hi Pranav, On Sun, Jul 19, 2020 at 2:19 PM Pranav Madhu wrote: > > Changes since v3: > - Addressed all the comments from Leif. As part of the clean up that > resulted from addressing the comments, some of the comments where not > applicable anymore (due to fragments of code that had comments were > removed during cleanup). > - Included detailed description of the workarounds applied to the > Neoverse N1 SoC specific PciExpressLib library. > - Updated Maintainers.txt to add Silicon/ARM/ directory under ARM entry. > - Picked up Leif's Reviewed-by tag for the 4th patch of this series. > - Addressed all the comments from Ard. > > Changes since v2: > - Addressed comments from Thomas. > - Renamed Silicon/ARM/N1SDP to Silicon/ARM/NeoverseN1Soc. > > Changes since v1: > - Addressed comments from Ard. > - Split the code between Silicon and Platform directories. > > Arm's N1SDP is a Arm v8.2-A Neoverse N1 CPU based reference design platform > primariliy intended for development on Arm64 based platform. This patch series > adds initial platform support for this board. > > The first patch in this series adds the platform libary implementation. The > second patch adds a custom implementation of the PciExpressLib due to a PCIe > integration issue which results in all config space accesses to non-existing > BDFs resulting in a Serror (bus abort). To avoid this, the N1SDP specific > PciExpressLib implementation provides a workaround for this issue. The third > patch in this series adds the platform library for the PciHostBridge. The > fourth patch adds the initial platform support for the N1SDP platform. The > fifth patch adds Silicon/ARM/ to ARM entry in maintainers file. > > > Deepak Pandey (4): > Silicon/ARM/N1SoC: Add platform library implementation > Silicon/ARM/N1SoC: Implement Neoverse N1 Soc specific PciExpressLib > Silicon/ARM/N1SoC: Implement the PciHostBridgeLib library > Platform/ARM/N1SDP: Add initial N1SDP platform support > > Pranav Madhu (1): > Maintainers.txt: Add Silicon/ARM directory Apart from the comment on the second patch, this series looks okay. Could you fix those and repost this series. - Thomas. > > Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec | 46 + > Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 245 +++ > Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 294 ++++ > Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/PciExpressLib.inf | 56 + > Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 49 + > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.inf | 54 + > Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h | 66 + > Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/PciExpressLib.c | 1589 ++++++++++++++++++++ > Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c | 184 +++ > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c | 67 + > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c | 151 ++ > Maintainers.txt | 1 + > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/AArch64/Helper.S | 84 ++ > 13 files changed, 2886 insertions(+) > create mode 100644 Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec > create mode 100644 Platform/ARM/N1Sdp/N1SdpPlatform.dsc > create mode 100644 Platform/ARM/N1Sdp/N1SdpPlatform.fdf > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/PciExpressLib.inf > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.inf > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.inf > create mode 100644 Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/PciExpressLib.c > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/AArch64/Helper.S > > -- > 2.7.4 > > > ------------ > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#62792): https://edk2.groups.io/g/devel/message/62792 > Mute This Topic: https://groups.io/mt/75658676/1785013 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ta.omasab@gmail.com] > ------------ >