From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 92365211935A4 for ; Fri, 23 Nov 2018 06:16:06 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BE526362E for ; Fri, 23 Nov 2018 06:16:05 -0800 (PST) Received: from mail-io1-f47.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A528A3F575 for ; Fri, 23 Nov 2018 06:16:05 -0800 (PST) Received: by mail-io1-f47.google.com with SMTP id x6so8903935ioa.9 for ; Fri, 23 Nov 2018 06:16:05 -0800 (PST) X-Gm-Message-State: AA+aEWYsvPDaoQ7j0sEh63fgPLIVUVOdtUTKbvuZyStnpEVHbHz39QvF BB+LYQqEZEgD7SI3IZKi7mPcT9n7lnXS2qfdscw= X-Google-Smtp-Source: AFSGD/VPYyFwFE2J2wUJtdhKdY+UVoctClY8UI7/I6jg2Gt5+MhFJrsU6ZTBNvSFqYVGf+l5kYvA/09hTdKkuxUulh4= X-Received: by 2002:a6b:1681:: with SMTP id 123-v6mr11115174iow.209.1542982564943; Fri, 23 Nov 2018 06:16:04 -0800 (PST) MIME-Version: 1.0 References: <20181123084406.27192-1-ard.biesheuvel@linaro.org> In-Reply-To: <20181123084406.27192-1-ard.biesheuvel@linaro.org> From: Thomas Abraham Date: Fri, 23 Nov 2018 19:45:53 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, lersek@redhat.com, Nariman Poushin Subject: Re: [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 14:16:06 -0000 Content-Type: text/plain; charset="UTF-8" Hi Ard, On Fri, Nov 23, 2018 at 2:16 PM Ard Biesheuvel wrote: > > The deprecated BdsLib library class in ArmPkg is still depended upon, but > only a single implementation exists, which now resides in edk2-platforms. > > This implementation has some issues in how it deals with Device Paths, > so let's fix those, but first move over the library interface declaration > and get rid of the parts that are no longer used. This will permit dropping > it from ArmPkg in EDK2. > > Changes since v1: > - add Laszlo's ack to #1 > - update #2 to remove everything we no longer need from BdsLib > - drop #3 which was bogus > - update #4 to ensure that we only duplicate the device path when we > are about to return EFI_SUCCESS > > Ard Biesheuvel (3): > Platform/ARM: import ARM platform specific BdsLib header > Platform/ARM/BdsLib: drop unused functions > Platform/ARM/BdsLib: maintain alignment for DevicePaths > > Platform/ARM/ARM.dec | 3 + > .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 2 +- > Platform/ARM/Include/Library/BdsLib.h | 26 ++ > Platform/ARM/Library/BdsLib/BdsAppLoader.c | 253 ---------------- > Platform/ARM/Library/BdsLib/BdsFilePath.c | 95 +----- > Platform/ARM/Library/BdsLib/BdsHelper.c | 122 -------- > Platform/ARM/Library/BdsLib/BdsInternal.h | 16 +- > Platform/ARM/Library/BdsLib/BdsLib.inf | 4 +- > Platform/ARM/Library/BdsLib/BdsLoadOption.c | 272 ------------------ > 9 files changed, 52 insertions(+), 741 deletions(-) > create mode 100644 Platform/ARM/Include/Library/BdsLib.h > delete mode 100644 Platform/ARM/Library/BdsLib/BdsAppLoader.c > delete mode 100644 Platform/ARM/Library/BdsLib/BdsLoadOption.c Tested this patch series with the following two patch series applied on the Juno board. - [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB - [PATCH edk2-platforms 0/3] drop GUIDs from NOR flash bank descriptors Boot on Juno board works fine. For this and the other two patch series Tested-by: Thomas Abraham > > -- > 2.17.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel