From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.74345.1584379992081858379 for ; Mon, 16 Mar 2020 10:33:12 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: thomas.abraham@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AB43A1045 for ; Mon, 16 Mar 2020 10:33:11 -0700 (PDT) Received: from mail-io1-f51.google.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 96C5F3F67D for ; Mon, 16 Mar 2020 10:33:11 -0700 (PDT) Received: by mail-io1-f51.google.com with SMTP id h8so18006287iob.2 for ; Mon, 16 Mar 2020 10:33:11 -0700 (PDT) X-Gm-Message-State: ANhLgQ3C3T3/BYJibLiYztwfDqIFZoFzbpEKsOoF6RbxvKrySKM9xTp5 A4qX3e9K2ZcNzlq4mSK5HbydfmFbkNrNzequRSU= X-Google-Smtp-Source: ADFU+vtVmVzcriZ3pth+bv6/2/NZazU4X+IIFBO3AtYSQYVPz5qscFb4+ixeS3MuH/UUCq7bWQfVdVM275AKUCljWOo= X-Received: by 2002:a02:c7cd:: with SMTP id s13mr957763jao.81.1584379982974; Mon, 16 Mar 2020 10:33:02 -0700 (PDT) MIME-Version: 1.0 References: <20200312143520.16918-1-aditya.angadi@arm.com> <20200312143520.16918-9-aditya.angadi@arm.com> In-Reply-To: <20200312143520.16918-9-aditya.angadi@arm.com> From: "Thomas Abraham" Date: Mon, 16 Mar 2020 23:02:51 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-platforms][PATCH 8/8] Platform/ARM/Sgi: Add initial support for RD-Daniel Config-XLR platform To: devel@edk2.groups.io, aditya.angadi@arm.com Cc: leif@nuviainc.com, michael.d.kinney@intel.com, vijayenthiran.subramaniam@arm.com Content-Type: text/plain; charset="UTF-8" On Thu, Mar 12, 2020 at 8:06 PM Aditya Angadi wrote: > > For RD-Daniel Config-XLR, use multichip mode information from the SGI > platform descriptor HOB to pick the correct ACPI table to be installed. > > Signed-off-by: Aditya Angadi Reviewed-by: Thomas Abraham > --- > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 5 +++++ > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 + > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 1 + > 3 files changed, 7 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > index 7e0de765f7..b1f5714b93 100644 > --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > @@ -51,6 +51,11 @@ STATIC SGI_PLATFORM_ACPI_TABLE_GUID_LOOKUP AcpiTableGuidLookup[] = { > RD_DANIEL_CFGM_CONF_ID, > MULTI_CHIP_MODE_DISABLED, > &gRdDanielCfgMAcpiTablesFileGuid), > + ACPI_GUID_LOOKUP ( > + RD_DANIEL_PART_NUM, > + RD_DANIEL_CFGXLR_CONF_ID, > + MULTI_CHIP_MODE_ENABLED, > + &gRdDanielCfgXlrAcpiTablesFileGuid), > }; > > VOID > diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf > index 82569820b7..00cbe608c2 100644 > --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf > +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf > @@ -35,6 +35,7 @@ > gRdN1EdgeX2AcpiTablesFileGuid > gRdE1EdgeAcpiTablesFileGuid > gRdDanielCfgMAcpiTablesFileGuid > + gRdDanielCfgXlrAcpiTablesFileGuid > > [FeaturePcd] > gArmSgiTokenSpaceGuid.PcdVirtioBlkSupported > diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > index b6a427b8b6..9822858f6e 100644 > --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h > +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > @@ -73,6 +73,7 @@ > //RDDANIEL Platform Identification values > #define RD_DANIEL_PART_NUM 0x78A > #define RD_DANIEL_CFGM_CONF_ID 0x1 > +#define RD_DANIEL_CFGXLR_CONF_ID 0x2 > > #define SGI_CONFIG_MASK 0x0F > #define SGI_CONFIG_SHIFT 0x1C > -- > 2.17.1 > > > >