From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 8D1F22116821B for ; Tue, 27 Nov 2018 01:23:50 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D4693563 for ; Tue, 27 Nov 2018 01:23:50 -0800 (PST) Received: from mail-it1-f173.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 042893F575 for ; Tue, 27 Nov 2018 01:23:50 -0800 (PST) Received: by mail-it1-f173.google.com with SMTP id p197so7190964itp.0 for ; Tue, 27 Nov 2018 01:23:49 -0800 (PST) X-Gm-Message-State: AA+aEWbzoluYaETasta/ddTpBYGfpbZYRWl+eQ8Ys7MLxuL5A84+J2HD QjNOmd65ROyXRNxk/lJL5adimGUFPdfiDzsKtVE= X-Google-Smtp-Source: AFSGD/X3ZVf1wowQ72pV1iungeqLD2eTP76pBbSYXgNbnZrEWZXIHJrxCgnWERcYFwkLC2K7jQe9CIUaGEIAbX9KUNU= X-Received: by 2002:a05:660c:283:: with SMTP id s3mr18366012itl.135.1543310629238; Tue, 27 Nov 2018 01:23:49 -0800 (PST) MIME-Version: 1.0 References: <20181105013310.79948-1-siyuan.fu@intel.com> <20181105013310.79948-3-siyuan.fu@intel.com> <20181107082512.g2eelvz6idzgrdhs@bivouac.eciton.net> In-Reply-To: From: Thomas Abraham Date: Tue, 27 Nov 2018 14:53:37 +0530 X-Gmail-Original-Message-ID: Message-ID: To: siyuan.fu@intel.com Cc: Leif Lindholm , michael.d.kinney@intel.com, edk2-devel@lists.01.org Subject: Re: [PATCH v2 2/2] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg drivers. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 09:23:50 -0000 Content-Type: text/plain; charset="UTF-8" Hi Siyuan, On Tue, Nov 27, 2018 at 2:22 PM Fu, Siyuan wrote: > > Hi, Thomas > > > -----Original Message----- > > From: Thomas Abraham [mailto:thomas.abraham@arm.com] > > Sent: Friday, November 9, 2018 9:56 PM > > To: Leif Lindholm > > Cc: Fu, Siyuan ; Kinney, Michael D > > ; edk2-devel@lists.01.org > > Subject: Re: [edk2] [PATCH v2 2/2] Edk2Platforms: Replace MdeModulePkg > > PXE/iSCSI/TCP with NetworkPkg drivers. > > > > On Wed, Nov 7, 2018 at 1:55 PM Leif Lindholm wrote: > > > > > > Hi Fu Siyan, > > > > > > On Wed, Nov 07, 2018 at 08:12:55AM +0000, Fu, Siyuan wrote: > > > > Hi, Leif and Ard > > > > > > > > I just realized that you may not be CCed in this email. I resent these > > patches a few minutes ago, my Git Bash send-email reports it added you to CC > > receiver, but the Outlook received email still doesn't have your name in CC > > list. > > > > > > > > Do you have any comments for this v2 patch of the edk2platforms? > > > > > > > > > > > > BestRegards > > > > Fu Siyuan > > > > > > > > > -----Original Message----- > > > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Fu > > > > > Siyuan > > > > > Sent: Monday, November 5, 2018 9:33 AM > > > > > To: edk2-devel@lists.01.org > > > > > Cc: Kinney, Michael D > > > > > Subject: [edk2] [PATCH v2 2/2] Edk2Platforms: Replace MdeModulePkg > > > > > PXE/iSCSI/TCP with NetworkPkg drivers. > > > > > > > > > > V2: > > > > > Additional fixups required for NetworkPkg migration > > > > > > Revision history like this belongs in the cover letter. > > > > > > > > The PXE/iSCSI/TCP drivers in MdeModulePkg are going to be deprecated. > > All > > > > > platform DSC/FDF files should be updated to use the dual-stack drivers > > in > > > > > NetworkPkg. > > > > > > > > > > The NetworkPkg driver have all the functionality compared with > > > > > MdeModulePkg > > > > > one, with more bug fixes and new feature added. While its image size > > will > > > > > be a little bigger because it contains both IPv4 and IPv6 stack support, > > > > > so it may cause build error in a platform if the flash space is very > > tight. > > > > > Basically, this patch won't cause any other problem if build could pass. > > > > > > > > > > I haven't built all the updated platform because the repo ReadMe doesn't > > > > > provide a method to build them on Windows Environment, so I would very > > > > > appreciate if anybody can help to test the build or tell me how to build > > > > > it on Windows. > > > > > > And comments like the paragraph above belong in the cover letter or > > > below the --- > > > If you are OK with me deleting these bits before committing: > > > Reviewed-by: Leif Lindholm > > > > > > / > > > Leif > > > > > > > > > > > > > Cc: Ard Biesheuvel > > > > > Cc: Leif Lindholm > > > > > Cc: Michael D Kinney > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > Signed-off-by: Fu Siyuan > > > > > Signed-off-by: Leif Lindholm > > > > > --- > > > > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 6 +++--- > > > > > Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 6 +++--- > > > > > Platform/ARM/SgiPkg/SgiPlatform.fdf | 6 +++--- > > > > > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 1 + > > > > > Platform/ARM/VExpressPkg/ArmVExpress-networking.fdf.inc | 6 +++--- > > > > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 13 > > +++++++- > > > > > ----- > > > > > Platform/Comcast/RDKQemu/RDKQemu.dsc | 10 +++--- > > -- > > > > > -- > > > > > Platform/Hisilicon/D03/D03.dsc | 4 ++-- > > > > > Platform/Hisilicon/D03/D03.fdf | 4 ++-- > > > > > Platform/Hisilicon/D05/D05.dsc | 11 +++--- > > -- > > > > > --- > > > > > Platform/Hisilicon/D05/D05.fdf | 9 +++--- > > -- > > > > > - > > > > > Platform/Hisilicon/D06/D06.dsc | 11 +++--- > > -- > > > > > --- > > > > > Platform/Hisilicon/D06/D06.fdf | 9 +++--- > > -- > > > > > - > > > > > Platform/Hisilicon/HiKey/HiKey.dsc | 4 ++-- > > > > > Platform/Hisilicon/HiKey/HiKey.fdf | 4 ++-- > > > > > Platform/Hisilicon/HiKey960/HiKey960.dsc | 4 ++-- > > > > > Platform/Hisilicon/HiKey960/HiKey960.fdf | 4 ++-- > > > > > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 11 > > > > > ++++++++--- > > > > > Platform/LeMaker/CelloBoard/CelloBoard.fdf | 6 +++--- > > > > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 6 +++--- > > > > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf | 6 +++--- > > > > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 4 ++-- > > > > > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 4 ++-- > > > > > 23 files changed, 68 insertions(+), 81 deletions(-) > > > > > > > > > [...] > > > > > > > # > > > > > # Core Info > > > > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf > > > > > b/Platform/ARM/SgiPkg/SgiPlatform.fdf > > > > > index fd87563246..c9129841d7 100644 > > > > > --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf > > > > > +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf > > > > > @@ -185,10 +185,10 @@ READ_LOCK_STATUS = TRUE > > > > > INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > > > > > INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > > > > > INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > > > > - INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > > > > > INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > > > > > - INF MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > > > > > - INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > > > > > + INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > > > > + INF NetworkPkg/TcpDxe/TcpDxe.inf > > > > > + INF NetworkPkg/IScsiDxe/IScsiDxe.inf > > > > > INF EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf > > > > > > > > > [...] > > > > On SGI platforms, the above change causes a crash (Synchronous > > Exception). This issue is yet to be debugged but initial observations > > are the following messages on the console. > > > > Loading driver at 0x000F7FFC000 EntryPoint=0x000F800B2AC IScsiDxe.efi > > InstallProtocolInterface: input handle at 0xFE229C98 is invalid > > InstallProtocolInterface: 18A031AB-B443-4D1A-A5C0-0C09261E9F71 > > F801AA18 failed with Invalid Parameter > > Error: Image at 000F7FFC000 start failed: Invalid Parameter > > remove-symbol-file > > /home/thopan01/devel/sgi/upstream- > > dev/uefi/edk2/Build/ArmSgi/DEBUG_GCC5/AARCH64/NetworkPkg/IScsiDxe/IScsiDxe/DEB > > UG/IScsiDxe.dll > > 0xF7FFD000 > > > > and then later crashes in the "PlatformBootManagerBeforeConsole" > > function in "ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c" file. > > > > This issue will be debugged. If there are any suggestions on possible > > fixes, please let me know. > > Have you root caused this issue for your SGI platform? Can I commit this > patch for Edk2Platforms repo? I plan to remove the MdeModulePkg PXE/iSCSI/TCP > drivers and Edk2Platforms need to be updated before that. Yes, the issue has been root caused and fixed. The issue was related to use of a variable of size 4K in iSCSI driver whereas the SGI platform had a limit of 1K for the variable. The patch to fix this issue is merged in edk2-platforms repo. Thanks, Thomas. > > Thanks. > > > > > Thanks, > > Thomas. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel