From: "Thomas Abraham" <thomas.abraham@arm.com>
To: devel@edk2.groups.io, pranav.madhu@arm.com
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>,
Leif Lindholm <leif@nuviainc.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v3 0/4] Platform: Add initial support for N1SDP board
Date: Mon, 6 Jul 2020 19:57:33 +0530 [thread overview]
Message-ID: <CAJuA9aiccLC1A0PhLFFwztz3vGp73QJCcYUZEr=0J+PnC+=8nA@mail.gmail.com> (raw)
In-Reply-To: <1593775136-17859-1-git-send-email-pranav.madhu@arm.com>
On Fri, Jul 3, 2020 at 4:49 PM Pranav Madhu <pranav.madhu@arm.com> wrote:
>
> Changes since v2:
> - Addressed comments from Thomas.
> - Renamed Silicon/ARM/N1SDP to Silicon/ARM/NeoverseN1Soc.
>
> Changes since v1:
> - Addressed comments from Ard.
> - Split the code between Silicon and Platform directories.
>
> Arm's N1SDP is a Arm v8.2-A Neoverse N1 CPU based reference design platform
> primariliy intended for development on Arm64 based platform. This patch series
> adds initial platform support for this board.
>
> The first patch in this series adds the platform libary implementation. The
> second patch adds a custom implementation of the PciExpressLib due to a PCIe
> integration issue which results in all config space accesses to non-existing
> BDFs resulting in a Serror (bus abort). To avoid this, the N1SDP specific
> PciExpressLib implementation provides a workaround for this issue. The third
> patch in this series adds the platform library for the PciHostBridge. The
> fourth patch adds the initial platform support for the N1SDP platform.
>
> Deepak Pandey (4):
> Silicon/ARM/N1SoC: Add platform library implementation
> Silicon/ARM/N1SoC: Implement Neoverse N1 Soc specific PciExpressLib
> Silicon/ARM/N1SoC: Implement the PciHostBridgeLib library
> Platform/ARM/N1SDP: Add initial N1SDP platform support
For this series:
Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
>
> Silicon/ARM/NeoverseN1Soc/NeoverseN1SocPlatform.dec | 46 +
> Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 245 ++++
> Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 294 ++++
> Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/NeoverseN1SocPciExpressLib.inf | 39 +
> Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 49 +
> Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.inf | 54 +
> Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1SocPlatform.h | 68 +
> Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/NeoverseN1SocPciExpressLib.c | 1545 ++++++++++++++++++++
> Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c | 187 +++
> Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c | 67 +
> Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c | 152 ++
> Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/AArch64/Helper.S | 84 ++
> 12 files changed, 2830 insertions(+)
> create mode 100644 Silicon/ARM/NeoverseN1Soc/NeoverseN1SocPlatform.dec
> create mode 100644 Platform/ARM/N1Sdp/N1SdpPlatform.dsc
> create mode 100644 Platform/ARM/N1Sdp/N1SdpPlatform.fdf
> create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/NeoverseN1SocPciExpressLib.inf
> create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.inf
> create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.inf
> create mode 100644 Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1SocPlatform.h
> create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/NeoverseN1SocPciExpressLib.c
> create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c
> create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c
> create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c
> create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/AArch64/Helper.S
>
> --
> 2.7.4
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#62019): https://edk2.groups.io/g/devel/message/62019
> Mute This Topic: https://groups.io/mt/75274945/1785013
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ta.omasab@gmail.com]
> ------------
>
next prev parent reply other threads:[~2020-07-06 14:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 11:18 [edk2-platforms][PATCH v3 0/4] Platform: Add initial support for N1SDP board Pranav Madhu
2020-07-03 11:18 ` [edk2-platforms][PATCH v3 1/4] Silicon/ARM/N1SoC: Add platform library implementation Pranav Madhu
2020-07-13 17:18 ` Leif Lindholm
2020-07-03 11:18 ` [edk2-platforms][PATCH v3 2/4] Silicon/ARM/N1SoC: Implement Neoverse N1 Soc specific PciExpressLib Pranav Madhu
2020-07-13 19:10 ` Leif Lindholm
2020-07-03 11:18 ` [edk2-platforms][PATCH v3 3/4] Silicon/ARM/N1SoC: Implement the PciHostBridgeLib library Pranav Madhu
2020-07-14 10:46 ` Leif Lindholm
2020-07-03 11:18 ` [edk2-platforms][PATCH v3 4/4] Platform/ARM/N1SDP: Add initial N1SDP platform support Pranav Madhu
2020-07-14 11:19 ` Leif Lindholm
2020-07-06 14:27 ` Thomas Abraham [this message]
2020-07-13 16:57 ` [edk2-platforms][PATCH v3 0/4] Platform: Add initial support for N1SDP board Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJuA9aiccLC1A0PhLFFwztz3vGp73QJCcYUZEr=0J+PnC+=8nA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox